All of lore.kernel.org
 help / color / mirror / Atom feed
From: patchwork-bot+netdevbpf@kernel.org
To: Jisheng Zhang <jszhang@kernel.org>
Cc: peppe.cavallaro@st.com, alexandre.torgue@foss.st.com,
	joabreu@synopsys.com, davem@davemloft.net, kuba@kernel.org,
	mcoquelin.stm32@gmail.com, qiangqing.zhang@nxp.com,
	netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: stmmac: properly handle with runtime pm in stmmac_dvr_remove()
Date: Fri, 28 Jan 2022 15:20:10 +0000	[thread overview]
Message-ID: <164338321073.8810.2377370074085228481.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20220128141550.2350-1-jszhang@kernel.org>

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:

On Fri, 28 Jan 2022 22:15:50 +0800 you wrote:
> There are two issues with runtime pm handling in stmmac_dvr_remove():
> 
> 1. the mac is runtime suspended before stopping dma and rx/tx. We
> need to ensure the device is properly resumed back.
> 
> 2. the stmmaceth clk enable/disable isn't balanced in both exit and
> error handling code path. Take the exit code path for example, when we
> unbind the driver or rmmod the driver module, the mac is runtime
> suspended as said above, so the stmmaceth clk is disabled, but
> 	stmmac_dvr_remove()
> 	  stmmac_remove_config_dt()
> 	    clk_disable_unprepare()
> CCF will complain this time. The error handling code path suffers
> from the similar situtaion.
> 
> [...]

Here is the summary with links:
  - net: stmmac: properly handle with runtime pm in stmmac_dvr_remove()
    https://git.kernel.org/netdev/net/c/6449520391df

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: patchwork-bot+netdevbpf@kernel.org
To: Jisheng Zhang <jszhang@kernel.org>
Cc: peppe.cavallaro@st.com, alexandre.torgue@foss.st.com,
	joabreu@synopsys.com, davem@davemloft.net, kuba@kernel.org,
	mcoquelin.stm32@gmail.com, qiangqing.zhang@nxp.com,
	netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: stmmac: properly handle with runtime pm in stmmac_dvr_remove()
Date: Fri, 28 Jan 2022 15:20:10 +0000	[thread overview]
Message-ID: <164338321073.8810.2377370074085228481.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20220128141550.2350-1-jszhang@kernel.org>

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:

On Fri, 28 Jan 2022 22:15:50 +0800 you wrote:
> There are two issues with runtime pm handling in stmmac_dvr_remove():
> 
> 1. the mac is runtime suspended before stopping dma and rx/tx. We
> need to ensure the device is properly resumed back.
> 
> 2. the stmmaceth clk enable/disable isn't balanced in both exit and
> error handling code path. Take the exit code path for example, when we
> unbind the driver or rmmod the driver module, the mac is runtime
> suspended as said above, so the stmmaceth clk is disabled, but
> 	stmmac_dvr_remove()
> 	  stmmac_remove_config_dt()
> 	    clk_disable_unprepare()
> CCF will complain this time. The error handling code path suffers
> from the similar situtaion.
> 
> [...]

Here is the summary with links:
  - net: stmmac: properly handle with runtime pm in stmmac_dvr_remove()
    https://git.kernel.org/netdev/net/c/6449520391df

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



  reply	other threads:[~2022-01-28 15:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-28 14:15 [PATCH] net: stmmac: properly handle with runtime pm in stmmac_dvr_remove() Jisheng Zhang
2022-01-28 14:15 ` Jisheng Zhang
2022-01-28 15:20 ` patchwork-bot+netdevbpf [this message]
2022-01-28 15:20   ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=164338321073.8810.2377370074085228481.git-patchwork-notify@kernel.org \
    --to=patchwork-bot+netdevbpf@kernel.org \
    --cc=alexandre.torgue@foss.st.com \
    --cc=davem@davemloft.net \
    --cc=joabreu@synopsys.com \
    --cc=jszhang@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=peppe.cavallaro@st.com \
    --cc=qiangqing.zhang@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.