Re: [PATCH v4 01/15] dt-bindings: soc: bcm: bcm2835-pm: Convert bindings to DT schema

From: Rob Herring <robh@kernel.org>
To: Peter Robinson <pbrobinson@gmail.com>
Cc: devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	Emma Anholt <emma@anholt.net>,
	bcm-kernel-feedback-list@broadcom.com,
	Arnd Bergmann <arnd@arndb.de>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Lee Jones <lee.jones@linaro.org>,
	Russell King <linux@armlinux.org.uk>,
	Scott Branden <sbranden@broadcom.com>,
	Will Deacon <will@kernel.org>, David Airlie <airlied@linux.ie>,
	linux-rpi-kernel@lists.infradead.org,
	Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
	Ray Jui <rjui@broadcom.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Nicolas Saenz Julienne <nsaenz@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH v4 01/15] dt-bindings: soc: bcm: bcm2835-pm: Convert bindings to DT schema
Date: Tue, 15 Feb 2022 09:22:45 -0600	[thread overview]
Message-ID: <1644938565.082103.3450863.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20220213225646.67761-2-pbrobinson@gmail.com>

On Sun, 13 Feb 2022 22:56:33 +0000, Peter Robinson wrote:
> From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> 
> This converts the brcm,bcm2835-pm bindings from text to proper schema.
> 
> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> ---
>  .../bindings/soc/bcm/brcm,bcm2835-pm.txt      | 46 -----------
>  .../bindings/soc/bcm/brcm,bcm2835-pm.yaml     | 79 +++++++++++++++++++
>  2 files changed, 79 insertions(+), 46 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.txt
>  create mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml: properties:reg: {'minItems': 1, 'maxItems': 2, 'items': [{'description': 'PM registers'}, {'description': 'ASB registers'}]} should not be valid under {'required': ['maxItems']}
	hint: "maxItems" is not needed with an "items" list
	from schema $id: http://devicetree.org/meta-schemas/items.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml: ignoring, error in schema: properties: reg
Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.example.dt.yaml:0:0: /example-0/watchdog@7e100000: failed to match any schema with compatible: ['brcm,bcm2835-pm', 'brcm,bcm2835-pm-wdt']
Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.example.dt.yaml:0:0: /example-0/watchdog@7e100000: failed to match any schema with compatible: ['brcm,bcm2835-pm', 'brcm,bcm2835-pm-wdt']

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/1592167

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel