From: Adrien Thierry <athierry@redhat.com>
To: Peter Robinson <pbrobinson@gmail.com>
Cc: Nicolas Saenz Julienne <nsaenz@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Lee Jones <lee.jones@linaro.org>, Emma Anholt <emma@anholt.net>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Russell King <linux@armlinux.org.uk>,
Arnd Bergmann <arnd@arndb.de>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Subject: Re: [PATCH v4 12/15] drm/v3d: Add support for bcm2711
Date: Thu, 24 Feb 2022 14:56:04 -0500 [thread overview]
Message-ID: <Yhfi1DdlHPXzWAGc@fedora> (raw)
In-Reply-To: <20220213225646.67761-13-pbrobinson@gmail.com>
Hi,
> @@ -193,6 +193,7 @@ static const struct drm_driver v3d_drm_driver = {
> static const struct of_device_id v3d_of_match[] = {
> { .compatible = "brcm,7268-v3d" },
> { .compatible = "brcm,7278-v3d" },
> + { .compatible = "brcm,bcm2711-v3d" },
> {},
> };
The downstream tree [1] uses 'brcm,2711-v3d'. Is there a reason for not
using the same compatible string ? Having the same string would allow
using downstream dtbs (and overlays) with the upstream kernel.
Adrien
[1] https://github.com/raspberrypi/linux/blob/rpi-5.15.y/drivers/gpu/drm/v3d/v3d_drv.c
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Adrien Thierry <athierry@redhat.com>
To: Peter Robinson <pbrobinson@gmail.com>
Cc: Nicolas Saenz Julienne <nsaenz@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Lee Jones <lee.jones@linaro.org>, Emma Anholt <emma@anholt.net>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Russell King <linux@armlinux.org.uk>,
Arnd Bergmann <arnd@arndb.de>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Subject: Re: [PATCH v4 12/15] drm/v3d: Add support for bcm2711
Date: Thu, 24 Feb 2022 14:56:04 -0500 [thread overview]
Message-ID: <Yhfi1DdlHPXzWAGc@fedora> (raw)
In-Reply-To: <20220213225646.67761-13-pbrobinson@gmail.com>
Hi,
> @@ -193,6 +193,7 @@ static const struct drm_driver v3d_drm_driver = {
> static const struct of_device_id v3d_of_match[] = {
> { .compatible = "brcm,7268-v3d" },
> { .compatible = "brcm,7278-v3d" },
> + { .compatible = "brcm,bcm2711-v3d" },
> {},
> };
The downstream tree [1] uses 'brcm,2711-v3d'. Is there a reason for not
using the same compatible string ? Having the same string would allow
using downstream dtbs (and overlays) with the upstream kernel.
Adrien
[1] https://github.com/raspberrypi/linux/blob/rpi-5.15.y/drivers/gpu/drm/v3d/v3d_drv.c
next prev parent reply other threads:[~2022-02-24 19:57 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-13 22:56 [PATCH v4 00/15] Raspberry PI 4 V3D enablement Peter Robinson
2022-02-13 22:56 ` Peter Robinson
2022-02-13 22:56 ` [PATCH v4 01/15] dt-bindings: soc: bcm: bcm2835-pm: Convert bindings to DT schema Peter Robinson
2022-02-13 22:56 ` Peter Robinson
2022-02-15 15:22 ` Rob Herring
2022-02-15 15:22 ` Rob Herring
2022-02-13 22:56 ` [PATCH v4 02/15] dt-bindings: soc: bcm: bcm2835-pm: Introduce reg-names Peter Robinson
2022-02-13 22:56 ` Peter Robinson
2022-02-13 22:56 ` [PATCH v4 03/15] dt-bindings: soc: bcm: bcm2835-pm: Add support for bcm2711 Peter Robinson
2022-02-13 22:56 ` Peter Robinson
2022-02-14 12:11 ` Stefan Wahren
2022-02-14 12:11 ` Stefan Wahren
2022-02-13 22:56 ` [PATCH v4 04/15] ARM: dts: bcm2835/bcm2711: Introduce reg-names in watchdog node Peter Robinson
2022-02-13 22:56 ` Peter Robinson
2022-02-13 22:56 ` [PATCH v4 05/15] ARM: dts: bcm2711: Use proper compatible in PM/Watchdog node Peter Robinson
2022-02-13 22:56 ` Peter Robinson
2022-02-13 22:56 ` [PATCH v4 06/15] mfd: bcm2835-pm: Use 'reg-names' to get resources Peter Robinson
2022-02-13 22:56 ` Peter Robinson
2022-02-13 22:56 ` [PATCH v4 07/15] mfd: bcm2835-pm: Add support for BCM2711 Peter Robinson
2022-02-13 22:56 ` Peter Robinson
2022-02-19 15:21 ` Stefan Wahren
2022-02-19 15:21 ` Stefan Wahren
2022-02-13 22:56 ` [PATCH v4 08/15] soc: bcm: bcm2835-power: Add support for BCM2711's RPiVid ASB Peter Robinson
2022-02-13 22:56 ` Peter Robinson
2022-02-19 15:39 ` Stefan Wahren
2022-02-19 15:39 ` Stefan Wahren
2022-02-20 19:27 ` Peter Robinson
2022-02-20 19:27 ` Peter Robinson
2022-02-20 21:14 ` Stefan Wahren
2022-02-20 21:14 ` Stefan Wahren
2022-02-13 22:56 ` [PATCH v4 09/15] soc: bcm: bcm2835-power: Bypass power_on/off() calls Peter Robinson
2022-02-13 22:56 ` Peter Robinson
2022-02-13 22:56 ` [PATCH v4 10/15] dt-bindings: gpu: v3d: Add BCM2711's compatible Peter Robinson
2022-02-13 22:56 ` Peter Robinson
2022-02-13 22:56 ` [PATCH v4 11/15] drm/v3d: Get rid of pm code Peter Robinson
2022-02-13 22:56 ` Peter Robinson
2022-02-13 22:56 ` [PATCH v4 12/15] drm/v3d: Add support for bcm2711 Peter Robinson
2022-02-13 22:56 ` Peter Robinson
2022-02-24 19:56 ` Adrien Thierry [this message]
2022-02-24 19:56 ` Adrien Thierry
2022-02-13 22:56 ` [PATCH v4 13/15] ARM: dts: bcm2711: Enable V3D Peter Robinson
2022-02-13 22:56 ` Peter Robinson
2022-02-19 15:43 ` Stefan Wahren
2022-02-19 15:43 ` Stefan Wahren
2022-02-13 22:56 ` [PATCH v4 14/15] ARM: configs: Enable DRM_V3D Peter Robinson
2022-02-13 22:56 ` Peter Robinson
2022-02-19 15:48 ` Stefan Wahren
2022-02-19 15:48 ` Stefan Wahren
2022-02-13 22:56 ` [PATCH v4 15/15] arm64: config: " Peter Robinson
2022-02-13 22:56 ` Peter Robinson
2022-02-19 12:12 ` [PATCH v4 00/15] Raspberry PI 4 V3D enablement Stefan Wahren
2022-02-19 12:12 ` Stefan Wahren
2022-02-19 12:50 ` Peter Robinson
2022-02-19 12:50 ` Peter Robinson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yhfi1DdlHPXzWAGc@fedora \
--to=athierry@redhat.com \
--cc=airlied@linux.ie \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=catalin.marinas@arm.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=emma@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=nsaenz@kernel.org \
--cc=nsaenzjulienne@suse.de \
--cc=pbrobinson@gmail.com \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.