All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
To: Jeffy Chen <jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	dgreid-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
	briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
	mka-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
	dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Klaus Goger
	<klaus.goger-SN7IsUiht6C/RdPyistoZJqQE7yCjDx5@public.gmane.org>,
	linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Caesar Wang <wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
	Catalin Marinas <catalin.marinas-5wv7dgnIgG8@public.gmane.org>
Subject: Re: [RESENT PATCH v7 3/7] arm64: dts: rockchip: Update rt5514 devices' compatible for Gru
Date: Wed, 30 Aug 2017 15:30:59 +0200	[thread overview]
Message-ID: <1649093.IvC24TsujL@diego> (raw)
In-Reply-To: <20170824045227.15504-4-jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>

Hi Jeffy,

Am Donnerstag, 24. August 2017, 12:52:23 CEST schrieb Jeffy Chen:
> Currently the rt5514 i2c driver and rt5514 spi driver are using the same
> compatible string.
> 
> Add additional unused compatible strings to identify them for Gru
> boards.
> 
> Signed-off-by: Jeffy Chen <jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
> ---
> 
> Changes in v7: None
> Changes in v6: None
> Changes in v3: None
> Changes in v2: None
> 
>  arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi
> b/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi index
> 5772c52fbfd3..50fb11ad9f17 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi
> @@ -611,7 +611,7 @@ ap_i2c_mic: &i2c1 {
>  	i2c-scl-rising-time-ns = <300>;
> 
>  	headsetcodec: rt5514@57 {
> -		compatible = "realtek,rt5514";
> +		compatible = "realtek,rt5514", "realtek,rt5514-i2c";

the rt5514-i2c and -spi compatibles should be documented in the binding-txt
of the chip, but I haven't found any mention of this.


Heiko

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESENT PATCH v7 3/7] arm64: dts: rockchip: Update rt5514 devices' compatible for Gru
Date: Wed, 30 Aug 2017 15:30:59 +0200	[thread overview]
Message-ID: <1649093.IvC24TsujL@diego> (raw)
In-Reply-To: <20170824045227.15504-4-jeffy.chen@rock-chips.com>

Hi Jeffy,

Am Donnerstag, 24. August 2017, 12:52:23 CEST schrieb Jeffy Chen:
> Currently the rt5514 i2c driver and rt5514 spi driver are using the same
> compatible string.
> 
> Add additional unused compatible strings to identify them for Gru
> boards.
> 
> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
> ---
> 
> Changes in v7: None
> Changes in v6: None
> Changes in v3: None
> Changes in v2: None
> 
>  arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi
> b/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi index
> 5772c52fbfd3..50fb11ad9f17 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi
> @@ -611,7 +611,7 @@ ap_i2c_mic: &i2c1 {
>  	i2c-scl-rising-time-ns = <300>;
> 
>  	headsetcodec: rt5514 at 57 {
> -		compatible = "realtek,rt5514";
> +		compatible = "realtek,rt5514", "realtek,rt5514-i2c";

the rt5514-i2c and -spi compatibles should be documented in the binding-txt
of the chip, but I haven't found any mention of this.


Heiko

WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: Jeffy Chen <jeffy.chen@rock-chips.com>
Cc: linux-kernel@vger.kernel.org, dgreid@chromium.org,
	briannorris@chromium.org, mka@chromium.org,
	dianders@chromium.org, devicetree@vger.kernel.org,
	Klaus Goger <klaus.goger@theobroma-systems.com>,
	linux-rockchip@lists.infradead.org,
	Rob Herring <robh+dt@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	Will Deacon <will.deacon@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Caesar Wang <wxt@rock-chips.com>,
	Catalin Marinas <catalin.marinas@arm.com>
Subject: Re: [RESENT PATCH v7 3/7] arm64: dts: rockchip: Update rt5514 devices' compatible for Gru
Date: Wed, 30 Aug 2017 15:30:59 +0200	[thread overview]
Message-ID: <1649093.IvC24TsujL@diego> (raw)
In-Reply-To: <20170824045227.15504-4-jeffy.chen@rock-chips.com>

Hi Jeffy,

Am Donnerstag, 24. August 2017, 12:52:23 CEST schrieb Jeffy Chen:
> Currently the rt5514 i2c driver and rt5514 spi driver are using the same
> compatible string.
> 
> Add additional unused compatible strings to identify them for Gru
> boards.
> 
> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
> ---
> 
> Changes in v7: None
> Changes in v6: None
> Changes in v3: None
> Changes in v2: None
> 
>  arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi
> b/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi index
> 5772c52fbfd3..50fb11ad9f17 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi
> @@ -611,7 +611,7 @@ ap_i2c_mic: &i2c1 {
>  	i2c-scl-rising-time-ns = <300>;
> 
>  	headsetcodec: rt5514@57 {
> -		compatible = "realtek,rt5514";
> +		compatible = "realtek,rt5514", "realtek,rt5514-i2c";

the rt5514-i2c and -spi compatibles should be documented in the binding-txt
of the chip, but I haven't found any mention of this.


Heiko

  parent reply	other threads:[~2017-08-30 13:30 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-24  4:52 [RESENT PATCH v7 0/7] ASoC: rockchip: Parse dai links from dts Jeffy Chen
2017-08-24  4:52 ` Jeffy Chen
2017-08-24  4:52 ` Jeffy Chen
2017-08-24  4:52 ` [RESENT PATCH v7 1/7] ASoC: rockchip: Use codec of_node and dai_name for rt5514 dsp Jeffy Chen
2017-08-24  4:52   ` Jeffy Chen
2017-08-24 21:19   ` Matthias Kaehlcke
2017-08-24 21:19     ` Matthias Kaehlcke
2017-08-29 19:29   ` Applied "ASoC: rockchip: Use codec of_node and dai_name for rt5514 dsp" to the asoc tree Mark Brown
2017-08-29 19:29     ` Mark Brown
2017-08-29 19:29     ` Mark Brown
2017-08-29 19:29     ` Mark Brown
2017-08-24  4:52 ` [RESENT PATCH v7 2/7] arm64: dts: rockchip: Add rt5514 dsp for Gru Jeffy Chen
2017-08-24  4:52   ` Jeffy Chen
     [not found]   ` <20170824045227.15504-3-jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-09-09 11:13     ` Heiko Stuebner
2017-09-09 11:13       ` Heiko Stuebner
2017-09-09 11:13       ` Heiko Stuebner
2017-09-09 11:45       ` Heiko Stuebner
2017-09-09 11:45         ` Heiko Stuebner
2017-09-09 11:45         ` Heiko Stuebner
2017-08-24  4:52 ` [RESENT PATCH v7 3/7] arm64: dts: rockchip: Update rt5514 devices' compatible " Jeffy Chen
2017-08-24  4:52   ` Jeffy Chen
     [not found]   ` <20170824045227.15504-4-jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-08-30 13:30     ` Heiko Stübner [this message]
2017-08-30 13:30       ` Heiko Stübner
2017-08-30 13:30       ` Heiko Stübner
2017-08-30 17:00       ` jeffy
2017-08-30 17:00         ` jeffy
2017-08-30 17:00         ` jeffy
     [not found]         ` <59A6EF3C.5090308-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-09-04 22:33           ` Heiko Stübner
2017-09-04 22:33             ` Heiko Stübner
2017-09-04 22:33             ` Heiko Stübner
2017-09-05  4:26             ` jeffy
2017-09-05  4:26               ` jeffy
2017-08-24  4:52 ` [RESENT PATCH v7 4/7] ASoC: rockchip: Parse dai links from dts Jeffy Chen
2017-08-24  4:52   ` Jeffy Chen
2017-08-29 19:28   ` Applied "ASoC: rockchip: Parse dai links from dts" to the asoc tree Mark Brown
2017-08-29 19:28     ` Mark Brown
2017-08-29 19:28     ` Mark Brown
2017-08-29 19:28     ` Mark Brown
2017-08-24  4:52 ` [RESENT PATCH v7 5/7] ASoC: rockchip: Add support for DP codec Jeffy Chen
2017-08-24  4:52   ` Jeffy Chen
2017-08-24  4:52 ` [RESENT PATCH v7 6/7] ASoC: rockchip: Add support for DMIC codec Jeffy Chen
2017-08-24  4:52   ` Jeffy Chen
2017-08-24  4:52 ` [RESENT PATCH v7 7/7] dt-bindings: ASoC: rockchip: Update description of rockchip,codec Jeffy Chen
2017-08-24  4:52   ` [RESENT PATCH v7 7/7] dt-bindings: ASoC: rockchip: Update description of rockchip, codec Jeffy Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1649093.IvC24TsujL@diego \
    --to=heiko-4mtyjxux2i+zqb+pc5nmwq@public.gmane.org \
    --cc=briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=catalin.marinas-5wv7dgnIgG8@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=dgreid-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
    --cc=klaus.goger-SN7IsUiht6C/RdPyistoZJqQE7yCjDx5@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=mka-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=will.deacon-5wv7dgnIgG8@public.gmane.org \
    --cc=wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.