All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: paul@paul-moore.com, yepeilin.cs@gmail.com, eparis@redhat.com,
	asml.silence@gmail.com
Cc: linux-audit@redhat.com, peilin.ye@bytedance.com,
	io-uring@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] audit, io_uring, io-wq: Fix memory leak in io_sq_thread() and io_wqe_worker()
Date: Thu, 04 Aug 2022 08:36:17 -0600	[thread overview]
Message-ID: <165962377794.930556.772272743019429536.b4-ty@kernel.dk> (raw)
In-Reply-To: <20220803222343.31673-1-yepeilin.cs@gmail.com>

On Wed, 3 Aug 2022 15:23:43 -0700, Peilin Ye wrote:
> From: Peilin Ye <peilin.ye@bytedance.com>
> 
> Currently @audit_context is allocated twice for io_uring workers:
> 
>   1. copy_process() calls audit_alloc();
>   2. io_sq_thread() or io_wqe_worker() calls audit_alloc_kernel() (which
>      is effectively audit_alloc()) and overwrites @audit_context,
>      causing:
> 
> [...]

Applied, thanks!

[1/1] audit, io_uring, io-wq: Fix memory leak in io_sq_thread() and io_wqe_worker()
      commit: f482aa98652795846cc55da98ebe331eb74f3d0b

Best regards,
-- 
Jens Axboe



WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <axboe@kernel.dk>
To: paul@paul-moore.com, yepeilin.cs@gmail.com, eparis@redhat.com,
	asml.silence@gmail.com
Cc: linux-audit@redhat.com, peilin.ye@bytedance.com,
	io-uring@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] audit, io_uring, io-wq: Fix memory leak in io_sq_thread() and io_wqe_worker()
Date: Thu, 04 Aug 2022 08:36:17 -0600	[thread overview]
Message-ID: <165962377794.930556.772272743019429536.b4-ty@kernel.dk> (raw)
In-Reply-To: <20220803222343.31673-1-yepeilin.cs@gmail.com>

On Wed, 3 Aug 2022 15:23:43 -0700, Peilin Ye wrote:
> From: Peilin Ye <peilin.ye@bytedance.com>
> 
> Currently @audit_context is allocated twice for io_uring workers:
> 
>   1. copy_process() calls audit_alloc();
>   2. io_sq_thread() or io_wqe_worker() calls audit_alloc_kernel() (which
>      is effectively audit_alloc()) and overwrites @audit_context,
>      causing:
> 
> [...]

Applied, thanks!

[1/1] audit, io_uring, io-wq: Fix memory leak in io_sq_thread() and io_wqe_worker()
      commit: f482aa98652795846cc55da98ebe331eb74f3d0b

Best regards,
-- 
Jens Axboe


--
Linux-audit mailing list
Linux-audit@redhat.com
https://listman.redhat.com/mailman/listinfo/linux-audit


  parent reply	other threads:[~2022-08-04 14:36 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-03  5:02 [PATCH] audit, io_uring, io-wq: Fix memory leak in io_sq_thread() and io_wqe_worker() Peilin Ye
2022-08-03  5:02 ` Peilin Ye
2022-08-03 13:16 ` Paul Moore
2022-08-03 13:16   ` Paul Moore
2022-08-03 19:28   ` Paul Moore
2022-08-03 19:28     ` Paul Moore
2022-08-03 19:39     ` Jens Axboe
2022-08-03 19:39       ` Jens Axboe
2022-08-03 20:24     ` Peilin Ye
2022-08-03 20:24       ` Peilin Ye
2022-08-03 22:23 ` [PATCH v2] " Peilin Ye
2022-08-03 22:23   ` Peilin Ye
2022-08-04 13:51   ` Paul Moore
2022-08-04 13:51     ` Paul Moore
2022-08-04 14:32     ` Jens Axboe
2022-08-04 14:32       ` Jens Axboe
2022-08-04 14:44       ` Paul Moore
2022-08-04 14:44         ` Paul Moore
2022-08-04 14:36   ` Jens Axboe [this message]
2022-08-04 14:36     ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=165962377794.930556.772272743019429536.b4-ty@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=asml.silence@gmail.com \
    --cc=eparis@redhat.com \
    --cc=io-uring@vger.kernel.org \
    --cc=linux-audit@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paul@paul-moore.com \
    --cc=peilin.ye@bytedance.com \
    --cc=yepeilin.cs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.