All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@kernel.org>
To: Heiko Stuebner <heiko@sntech.de>,
	kever.yang@rock-chips.com, mturquette@baylibre.com
Cc: linux-clk@vger.kernel.org, linux-rockchip@lists.infradead.org
Subject: Re: [GIT PULL] Rockchip clock changes for 6.15 #1
Date: Wed, 12 Mar 2025 16:16:59 -0700	[thread overview]
Message-ID: <166bb0476a377d8159ce669007e49689.sboyd@kernel.org> (raw)
In-Reply-To: <2216284.irdbgypaU6@phil>

Quoting Heiko Stuebner (2025-03-11 23:03:00)
> Am Dienstag, 11. März 2025, 19:05:50 MEZ schrieb Stephen Boyd:
> > 
> > Did you see this warning?
> > 
> > drivers/clk/rockchip/rst-rk3562.c:21:57: error: initialized field overwritten [-Werror=override-init]
> >    21 | #define RK3562_DDRCRU_RESET_OFFSET(id, reg, bit) [id] = (0x20000*4 + reg * 16 + bit)
> >       |                                                         ^
> > drivers/clk/rockchip/rst-rk3562.c:266:9: note: in expansion of macro 'RK3562_DDRCRU_RESET_OFFSET'
> >   266 |         RK3562_DDRCRU_RESET_OFFSET(SRST_P_DDR_PHY, 0, 8),
> >       |         ^~~~~~~~~~~~~~~~~~~~~~~~~~
> > drivers/clk/rockchip/rst-rk3562.c:21:57: note: (near initialization for 'rk3562_register_offset[173]')
> >    21 | #define RK3562_DDRCRU_RESET_OFFSET(id, reg, bit) [id] = (0x20000*4 + reg * 16 + bit)
> >       |                                                         ^
> > drivers/clk/rockchip/rst-rk3562.c:266:9: note: in expansion of macro 'RK3562_DDRCRU_RESET_OFFSET'
> >   266 |         RK3562_DDRCRU_RESET_OFFSET(SRST_P_DDR_PHY, 0, 8),
> >       |         ^~~~~~~~~~~~~~~~~~~~~~~~~~
> > cc1: all warnings being treated as errors
> 
> 
> interestingly, this did not turn up in my build test.
> But that splat is really helpful too, because it made it easy to see
> that one of the ids is doubled in the dt-binding header.
> 
> include/dt-bindings/reset/rockchip,rk3562-cru.h:
> 
> #define SRST_P_DDR_HWLP         173
> #define SRST_P_DDR_PHY                  173
> 
> 
> I'll fix up the double id.

Thanks.

> 
> 
> Out of curiosity, what toolchain was that?
> 

$ ~/compilers/gcc-12.2.0-nolibc/aarch64-linux/bin/aarch64-linux-gcc --version
aarch64-linux-gcc (GCC) 12.2.0
Copyright (C) 2022 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@kernel.org>
To: Heiko Stuebner <heiko@sntech.de>,
	kever.yang@rock-chips.com, mturquette@baylibre.com
Cc: linux-clk@vger.kernel.org, linux-rockchip@lists.infradead.org
Subject: Re: [GIT PULL] Rockchip clock changes for 6.15 #1
Date: Wed, 12 Mar 2025 16:16:59 -0700	[thread overview]
Message-ID: <166bb0476a377d8159ce669007e49689.sboyd@kernel.org> (raw)
In-Reply-To: <2216284.irdbgypaU6@phil>

Quoting Heiko Stuebner (2025-03-11 23:03:00)
> Am Dienstag, 11. März 2025, 19:05:50 MEZ schrieb Stephen Boyd:
> > 
> > Did you see this warning?
> > 
> > drivers/clk/rockchip/rst-rk3562.c:21:57: error: initialized field overwritten [-Werror=override-init]
> >    21 | #define RK3562_DDRCRU_RESET_OFFSET(id, reg, bit) [id] = (0x20000*4 + reg * 16 + bit)
> >       |                                                         ^
> > drivers/clk/rockchip/rst-rk3562.c:266:9: note: in expansion of macro 'RK3562_DDRCRU_RESET_OFFSET'
> >   266 |         RK3562_DDRCRU_RESET_OFFSET(SRST_P_DDR_PHY, 0, 8),
> >       |         ^~~~~~~~~~~~~~~~~~~~~~~~~~
> > drivers/clk/rockchip/rst-rk3562.c:21:57: note: (near initialization for 'rk3562_register_offset[173]')
> >    21 | #define RK3562_DDRCRU_RESET_OFFSET(id, reg, bit) [id] = (0x20000*4 + reg * 16 + bit)
> >       |                                                         ^
> > drivers/clk/rockchip/rst-rk3562.c:266:9: note: in expansion of macro 'RK3562_DDRCRU_RESET_OFFSET'
> >   266 |         RK3562_DDRCRU_RESET_OFFSET(SRST_P_DDR_PHY, 0, 8),
> >       |         ^~~~~~~~~~~~~~~~~~~~~~~~~~
> > cc1: all warnings being treated as errors
> 
> 
> interestingly, this did not turn up in my build test.
> But that splat is really helpful too, because it made it easy to see
> that one of the ids is doubled in the dt-binding header.
> 
> include/dt-bindings/reset/rockchip,rk3562-cru.h:
> 
> #define SRST_P_DDR_HWLP         173
> #define SRST_P_DDR_PHY                  173
> 
> 
> I'll fix up the double id.

Thanks.

> 
> 
> Out of curiosity, what toolchain was that?
> 

$ ~/compilers/gcc-12.2.0-nolibc/aarch64-linux/bin/aarch64-linux-gcc --version
aarch64-linux-gcc (GCC) 12.2.0
Copyright (C) 2022 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  reply	other threads:[~2025-03-12 23:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-08 18:23 [GIT PULL] Rockchip clock changes for 6.15 #1 Heiko Stuebner
2025-03-08 18:23 ` Heiko Stuebner
2025-03-11 18:05 ` Stephen Boyd
2025-03-11 18:05   ` Stephen Boyd
2025-03-12  6:03   ` Heiko Stuebner
2025-03-12  6:03     ` Heiko Stuebner
2025-03-12 23:16     ` Stephen Boyd [this message]
2025-03-12 23:16       ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=166bb0476a377d8159ce669007e49689.sboyd@kernel.org \
    --to=sboyd@kernel.org \
    --cc=heiko@sntech.de \
    --cc=kever.yang@rock-chips.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mturquette@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.