All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Cc: linux-renesas-soc@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: rcar-du: of: Include header to define prototypes
Date: Thu, 26 Apr 2018 13:46:50 +0300	[thread overview]
Message-ID: <1671050.mdHx6Eelbf@avalon> (raw)
In-Reply-To: <20180424153942.2526-1-kieran.bingham+renesas@ideasonboard.com>

Hi Kieran,

Thank you for the patch.

On Tuesday, 24 April 2018 18:39:42 EEST Kieran Bingham wrote:
> The symbol 'rcar_du_of_init' is defined by the rcar_du_of module header,
> but it is not included by the C implementation.
> 
> Include the header to correctly define the function prototypes.
> 
> Fixes the following warning:
> 
> linux/drivers/gpu/drm/rcar-du/rcar_du_of.c:319:13:
>    warning: symbol 'rcar_du_of_init' was not declared. Should it be static?
>     CC      drivers/gpu/drm/rcar-du/rcar_du_of.o
> 
> Fixes: 81c0e3dd8292 ("drm: rcar-du: Fix legacy DT to create LVDS encoder
> nodes") Signed-off-by: Kieran Bingham
> <kieran.bingham+renesas@ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

and applied to my tree.

> ---
>  drivers/gpu/drm/rcar-du/rcar_du_of.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_of.c
> b/drivers/gpu/drm/rcar-du/rcar_du_of.c index 68a0b82cb17e..afef69669bb4
> 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_of.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_of.c
> @@ -18,6 +18,7 @@
> 
>  #include "rcar_du_crtc.h"
>  #include "rcar_du_drv.h"
> +#include "rcar_du_of.h"
> 
>  /*
> ---------------------------------------------------------------------------
> -- * Generic Overlay Handling


-- 
Regards,

Laurent Pinchart

WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Cc: linux-renesas-soc@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: rcar-du: of: Include header to define prototypes
Date: Thu, 26 Apr 2018 13:46:50 +0300	[thread overview]
Message-ID: <1671050.mdHx6Eelbf@avalon> (raw)
In-Reply-To: <20180424153942.2526-1-kieran.bingham+renesas@ideasonboard.com>

Hi Kieran,

Thank you for the patch.

On Tuesday, 24 April 2018 18:39:42 EEST Kieran Bingham wrote:
> The symbol 'rcar_du_of_init' is defined by the rcar_du_of module header,
> but it is not included by the C implementation.
> 
> Include the header to correctly define the function prototypes.
> 
> Fixes the following warning:
> 
> linux/drivers/gpu/drm/rcar-du/rcar_du_of.c:319:13:
>    warning: symbol 'rcar_du_of_init' was not declared. Should it be static?
>     CC      drivers/gpu/drm/rcar-du/rcar_du_of.o
> 
> Fixes: 81c0e3dd8292 ("drm: rcar-du: Fix legacy DT to create LVDS encoder
> nodes") Signed-off-by: Kieran Bingham
> <kieran.bingham+renesas@ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

and applied to my tree.

> ---
>  drivers/gpu/drm/rcar-du/rcar_du_of.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_of.c
> b/drivers/gpu/drm/rcar-du/rcar_du_of.c index 68a0b82cb17e..afef69669bb4
> 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_of.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_of.c
> @@ -18,6 +18,7 @@
> 
>  #include "rcar_du_crtc.h"
>  #include "rcar_du_drv.h"
> +#include "rcar_du_of.h"
> 
>  /*
> ---------------------------------------------------------------------------
> -- * Generic Overlay Handling


-- 
Regards,

Laurent Pinchart



_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2018-04-26 10:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-24 15:39 [PATCH] drm: rcar-du: of: Include header to define prototypes Kieran Bingham
2018-04-24 15:39 ` Kieran Bingham
2018-04-24 19:55 ` Vaishali Thakkar
2018-04-24 19:55   ` Vaishali Thakkar
2018-04-25  1:02 ` kbuild test robot
2018-04-25  1:02   ` kbuild test robot
2018-04-26 10:46 ` Laurent Pinchart [this message]
2018-04-26 10:46   ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1671050.mdHx6Eelbf@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kieran.bingham+renesas@ideasonboard.com \
    --cc=linux-renesas-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.