From: Heiko Stuebner <heiko@sntech.de>
To: Mark Yao <mark.yao@rock-chips.com>
Cc: Russell King <linux@arm.linux.org.uk>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drm/rockchip: vop: fix window origin calculation
Date: Tue, 10 Nov 2015 12:42:21 +0100 [thread overview]
Message-ID: <1671071.tld3k90Oeo@phil> (raw)
In-Reply-To: <1447149550-18595-1-git-send-email-mark.yao@rock-chips.com>
Am Dienstag, 10. November 2015, 17:59:10 schrieb Mark Yao:
> From: Dominik Behr <dbehr@chromium.org>
>
> VOP_WINx_DSP_ST does not require subtracting 1 from the values written to
> it. It actually causes the screen to be shifted by one pixel.
>
> Signed-off-by: Mark Yao <mark.yao@rock-chips.com>
funny I never noticed that shift, but now that you mention it, I see it too
on my Chromebook and the patch fixes this. I've also looked up the
matching data in the TRM, so
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Tested-by: Heiko Stuebner <heiko@sntech.de>
Heiko
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stuebner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] drm/rockchip: vop: fix window origin calculation
Date: Tue, 10 Nov 2015 12:42:21 +0100 [thread overview]
Message-ID: <1671071.tld3k90Oeo@phil> (raw)
In-Reply-To: <1447149550-18595-1-git-send-email-mark.yao@rock-chips.com>
Am Dienstag, 10. November 2015, 17:59:10 schrieb Mark Yao:
> From: Dominik Behr <dbehr@chromium.org>
>
> VOP_WINx_DSP_ST does not require subtracting 1 from the values written to
> it. It actually causes the screen to be shifted by one pixel.
>
> Signed-off-by: Mark Yao <mark.yao@rock-chips.com>
funny I never noticed that shift, but now that you mention it, I see it too
on my Chromebook and the patch fixes this. I've also looked up the
matching data in the TRM, so
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Tested-by: Heiko Stuebner <heiko@sntech.de>
Heiko
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Mark Yao <mark.yao@rock-chips.com>
Cc: David Airlie <airlied@linux.ie>,
Russell King <linux@arm.linux.org.uk>,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Dominik Behr <dbehr@chromium.org>
Subject: Re: [PATCH] drm/rockchip: vop: fix window origin calculation
Date: Tue, 10 Nov 2015 12:42:21 +0100 [thread overview]
Message-ID: <1671071.tld3k90Oeo@phil> (raw)
In-Reply-To: <1447149550-18595-1-git-send-email-mark.yao@rock-chips.com>
Am Dienstag, 10. November 2015, 17:59:10 schrieb Mark Yao:
> From: Dominik Behr <dbehr@chromium.org>
>
> VOP_WINx_DSP_ST does not require subtracting 1 from the values written to
> it. It actually causes the screen to be shifted by one pixel.
>
> Signed-off-by: Mark Yao <mark.yao@rock-chips.com>
funny I never noticed that shift, but now that you mention it, I see it too
on my Chromebook and the patch fixes this. I've also looked up the
matching data in the TRM, so
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Tested-by: Heiko Stuebner <heiko@sntech.de>
Heiko
next prev parent reply other threads:[~2015-11-10 11:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-10 9:59 [PATCH] drm/rockchip: vop: fix window origin calculation Mark Yao
2015-11-10 9:59 ` Mark Yao
2015-11-10 9:59 ` Mark Yao
2015-11-10 10:07 ` Yakir Yang
2015-11-10 10:07 ` Yakir Yang
2015-11-10 10:07 ` Yakir Yang
2015-11-10 11:42 ` Heiko Stuebner [this message]
2015-11-10 11:42 ` Heiko Stuebner
2015-11-10 11:42 ` Heiko Stuebner
2015-11-10 14:57 ` Heiko Stuebner
2015-11-10 14:57 ` Heiko Stuebner
2015-11-10 14:57 ` Heiko Stuebner
2015-11-11 0:30 ` Mark yao
2015-11-11 0:30 ` Mark yao
2015-11-11 0:30 ` Mark yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1671071.tld3k90Oeo@phil \
--to=heiko@sntech.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.yao@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.