All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sven Eckelmann <sven@narfation.org>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCHv2] ath9k_hw: Handle AR_INTR_SYNC_HOST1_FATAL on AR9003
Date: Fri, 05 Oct 2012 18:05:13 +0200	[thread overview]
Message-ID: <1705773.eSZj456rS3@bentobox> (raw)
In-Reply-To: <506EF975.7040909@openwrt.org>

On Friday 05 October 2012 17:15:01 Felix Fietkau wrote:
> Thanks for testing, but for submitting I'd prefer something simple,
> how about this:
> ---
> --- a/drivers/net/wireless/ath/ath9k/ar9003_phy.c
> +++ b/drivers/net/wireless/ath/ath9k/ar9003_phy.c
> @@ -1035,6 +1035,10 @@ static bool ar9003_hw_ani_control(struct
>  		 * is_on == 0 means MRC CCK is OFF (more noise imm)
>  		 */
>  		bool is_on = param ? 1 : 0;
> +
> +		if (ah->caps.rx_chainmask == 1)
> +			break;
> +
>  		REG_RMW_FIELD(ah, AR_PHY_MRC_CCK_CTRL,
>  			      AR_PHY_MRC_CCK_ENABLE, is_on);
>  		REG_RMW_FIELD(ah, AR_PHY_MRC_CCK_CTRL,

Yes, looks good.

Kind regards,
	Sven
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.ath9k.org/pipermail/ath9k-devel/attachments/20121005/7828b49d/attachment.pgp 

WARNING: multiple messages have this Message-ID (diff)
From: Sven Eckelmann <sven@narfation.org>
To: Felix Fietkau <nbd@openwrt.org>
Cc: Adrian Chadd <adrian@freebsd.org>,
	Simon Wunderlich <simon.wunderlich@s2003.tu-chemnitz.de>,
	linux-wireless@vger.kernel.org, linville@tuxdriver.com,
	mcgrof@qca.qualcomm.com, ath9k-devel@lists.ath9k.org,
	lindner_marek@yahoo.de
Subject: Re: [ath9k-devel] [PATCHv2] ath9k_hw: Handle AR_INTR_SYNC_HOST1_FATAL on AR9003
Date: Fri, 05 Oct 2012 18:05:13 +0200	[thread overview]
Message-ID: <1705773.eSZj456rS3@bentobox> (raw)
In-Reply-To: <506EF975.7040909@openwrt.org>

[-- Attachment #1: Type: text/plain, Size: 646 bytes --]

On Friday 05 October 2012 17:15:01 Felix Fietkau wrote:
> Thanks for testing, but for submitting I'd prefer something simple,
> how about this:
> ---
> --- a/drivers/net/wireless/ath/ath9k/ar9003_phy.c
> +++ b/drivers/net/wireless/ath/ath9k/ar9003_phy.c
> @@ -1035,6 +1035,10 @@ static bool ar9003_hw_ani_control(struct
>  		 * is_on == 0 means MRC CCK is OFF (more noise imm)
>  		 */
>  		bool is_on = param ? 1 : 0;
> +
> +		if (ah->caps.rx_chainmask == 1)
> +			break;
> +
>  		REG_RMW_FIELD(ah, AR_PHY_MRC_CCK_CTRL,
>  			      AR_PHY_MRC_CCK_ENABLE, is_on);
>  		REG_RMW_FIELD(ah, AR_PHY_MRC_CCK_CTRL,

Yes, looks good.

Kind regards,
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2012-10-05 16:05 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-27 14:41 [ath9k-devel] [PATCH] ath9k_hw: Handle AR_INTR_SYNC_HOST1_(FATAL|PERR) on AR9003 Sven Eckelmann
2012-09-27 14:41 ` Sven Eckelmann
2012-10-02 10:33 ` [ath9k-devel] [PATCHv2] ath9k_hw: Handle AR_INTR_SYNC_HOST1_FATAL " Sven Eckelmann
2012-10-02 10:33   ` Sven Eckelmann
2012-10-02 13:13   ` [ath9k-devel] " Adrian Chadd
2012-10-02 13:13     ` Adrian Chadd
2012-10-02 13:33     ` [ath9k-devel] " Felix Fietkau
2012-10-02 13:33       ` Felix Fietkau
2012-10-02 13:35     ` Simon Wunderlich
2012-10-02 13:35       ` Simon Wunderlich
2012-10-02 14:06       ` [ath9k-devel] " Adrian Chadd
2012-10-02 14:06         ` Adrian Chadd
2012-10-02 15:02         ` [ath9k-devel] " Sven Eckelmann
2012-10-02 15:02           ` Sven Eckelmann
2012-10-02 15:20           ` [ath9k-devel] " Felix Fietkau
2012-10-02 15:20             ` Felix Fietkau
2012-10-03 14:51             ` Adrian Chadd
2012-10-03 14:51               ` Adrian Chadd
2012-10-05 11:08               ` Sven Eckelmann
2012-10-05 11:08                 ` Sven Eckelmann
2012-10-05 12:34                 ` Felix Fietkau
2012-10-05 12:34                   ` Felix Fietkau
2012-10-05 13:07                   ` Sven Eckelmann
2012-10-05 13:07                     ` Sven Eckelmann
2012-10-05 13:24                     ` Felix Fietkau
2012-10-05 13:24                       ` Felix Fietkau
2012-10-05 15:03                       ` Sven Eckelmann
2012-10-05 15:03                         ` Sven Eckelmann
2012-10-05 15:15                         ` Felix Fietkau
2012-10-05 15:15                           ` Felix Fietkau
2012-10-05 16:05                           ` Sven Eckelmann [this message]
2012-10-05 16:05                             ` Sven Eckelmann
2012-10-05 16:21                   ` Adrian Chadd
2012-10-05 16:21                     ` Adrian Chadd
2012-10-05 16:51                     ` Sven Eckelmann
2012-10-05 16:51                       ` Sven Eckelmann
2012-10-05 23:48                       ` Adrian Chadd
2012-10-05 23:48                         ` Adrian Chadd
2012-10-06  9:03                         ` Felix Fietkau
2012-10-06  9:03                           ` Felix Fietkau
2013-02-21 11:14                           ` Felix Liao
2013-02-21 11:14                             ` Felix Liao
2013-02-21 20:38                             ` Adrian Chadd
2013-02-22  1:19                               ` Felix Liao
2013-02-22  5:16                                 ` Adrian Chadd
2013-02-22  6:43                                   ` Felix Liao
2013-02-22  7:18                                     ` Adrian Chadd
2013-02-22  7:31                                       ` Felix Liao
2013-02-22  8:08                                       ` Felix Liao
2013-02-22  1:33                               ` Felix Liao
2013-02-22  2:22                               ` Felix Liao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1705773.eSZj456rS3@bentobox \
    --to=sven@narfation.org \
    --cc=ath9k-devel@lists.ath9k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.