From: Christian Schoenebeck <qemu_oss@crudebyte.com>
To: qemu-devel@nongnu.org
Cc: "Daniel P. Berrange" <berrange@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
virtio-fs@redhat.com, "Xie Yongji" <xieyongji@bytedance.com>,
"Marc-André Lureau" <marcandre.lureau@gmail.com>
Subject: Re: [Virtio-fs] [External] Re: [RFC PATCH 0/9] Support for Virtio-fs daemon crash reconnection
Date: Wed, 17 Mar 2021 12:49:37 +0100 [thread overview]
Message-ID: <1709993.NBFj2RoZ23@silver> (raw)
In-Reply-To: <YFHUbEdszo4nursr@stefanha-x1.localdomain>
On Mittwoch, 17. März 2021 11:05:32 CET Stefan Hajnoczi wrote:
> On Fri, Dec 18, 2020 at 05:39:34PM +0800, Jiachen Zhang wrote:
> > Thanks for the suggestions. Actually, we choose to save all state
> > information to QEMU because a virtiofsd has the same lifecycle as its
> > QEMU master. However, saving things to a file do avoid communication with
> > QEMU, and we no longer need to increase the complexity of vhost-user
> > protocol. The suggestion to save fds to the systemd is also very
> > reasonable
> > if we don't consider the lifecycle issues, we will try it.
>
> Hi,
> We recently discussed crash recovery in the virtio-fs bi-weekly call and
> I read some of this email thread because it's a topic I'm interested in.
I just had a quick fly over the patches so far. Shouldn't there be some kind
of constraint for an automatic reconnection feature after a crash to prevent
this being exploited by ROP brute force attacks?
E.g. adding some (maybe continuously increasing) delay and/or limiting the
amount of reconnects within a certain time frame would come to my mind.
Best regards,
Christian Schoenebeck
WARNING: multiple messages have this Message-ID (diff)
From: Christian Schoenebeck <qemu_oss@crudebyte.com>
To: qemu-devel@nongnu.org
Cc: "Stefan Hajnoczi" <stefanha@redhat.com>,
"Jiachen Zhang" <zhangjiachen.jaycee@bytedance.com>,
"Daniel P. Berrange" <berrange@redhat.com>,
slp@redhat.com, "Michael S . Tsirkin" <mst@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
virtio-fs@redhat.com, "Xie Yongji" <xieyongji@bytedance.com>,
"Marc-André Lureau" <marcandre.lureau@gmail.com>
Subject: Re: [External] Re: [RFC PATCH 0/9] Support for Virtio-fs daemon crash reconnection
Date: Wed, 17 Mar 2021 12:49:37 +0100 [thread overview]
Message-ID: <1709993.NBFj2RoZ23@silver> (raw)
In-Reply-To: <YFHUbEdszo4nursr@stefanha-x1.localdomain>
On Mittwoch, 17. März 2021 11:05:32 CET Stefan Hajnoczi wrote:
> On Fri, Dec 18, 2020 at 05:39:34PM +0800, Jiachen Zhang wrote:
> > Thanks for the suggestions. Actually, we choose to save all state
> > information to QEMU because a virtiofsd has the same lifecycle as its
> > QEMU master. However, saving things to a file do avoid communication with
> > QEMU, and we no longer need to increase the complexity of vhost-user
> > protocol. The suggestion to save fds to the systemd is also very
> > reasonable
> > if we don't consider the lifecycle issues, we will try it.
>
> Hi,
> We recently discussed crash recovery in the virtio-fs bi-weekly call and
> I read some of this email thread because it's a topic I'm interested in.
I just had a quick fly over the patches so far. Shouldn't there be some kind
of constraint for an automatic reconnection feature after a crash to prevent
this being exploited by ROP brute force attacks?
E.g. adding some (maybe continuously increasing) delay and/or limiting the
amount of reconnects within a certain time frame would come to my mind.
Best regards,
Christian Schoenebeck
next prev parent reply other threads:[~2021-03-17 11:49 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 16:21 [Virtio-fs] [RFC PATCH 0/9] Support for Virtio-fs daemon crash reconnection Jiachen Zhang
2020-12-15 16:21 ` Jiachen Zhang
2020-12-15 16:21 ` [Virtio-fs] [RFC PATCH 1/9] vhost-user-fs: Add support for reconnection of vhost-user-fs backend Jiachen Zhang
2020-12-15 16:21 ` Jiachen Zhang
2020-12-15 16:21 ` [Virtio-fs] [RFC PATCH 2/9] vhost: Add vhost-user message types for sending shared memory and file fds Jiachen Zhang
2020-12-15 16:21 ` Jiachen Zhang
2020-12-15 16:21 ` [Virtio-fs] [RFC PATCH 3/9] vhost-user-fs: Support virtiofsd crash reconnection Jiachen Zhang
2020-12-15 16:21 ` Jiachen Zhang
2020-12-15 16:21 ` [Virtio-fs] [RFC PATCH 4/9] libvhost-user: Add vhost-user message types for sending shared memory and file fds Jiachen Zhang
2020-12-15 16:21 ` Jiachen Zhang
2020-12-15 16:21 ` [Virtio-fs] [RFC PATCH 5/9] virtiofsd: Convert the struct lo_map array to a more flatten layout Jiachen Zhang
2020-12-15 16:21 ` Jiachen Zhang
2020-12-15 16:21 ` [Virtio-fs] [RFC PATCH 6/9] virtiofsd: Add two new options for crash reconnection Jiachen Zhang
2020-12-15 16:21 ` Jiachen Zhang
2021-02-04 12:08 ` [Virtio-fs] " Dr. David Alan Gilbert
2021-02-04 12:08 ` Dr. David Alan Gilbert
2021-02-04 14:16 ` [Virtio-fs] [External] " Jiachen Zhang
2021-02-04 14:16 ` Jiachen Zhang
2020-12-15 16:21 ` [Virtio-fs] [RFC PATCH 7/9] virtiofsd: Persist/restore lo_map and opened fds to/from QEMU Jiachen Zhang
2020-12-15 16:21 ` Jiachen Zhang
2020-12-15 16:21 ` [Virtio-fs] [RFC PATCH 8/9] virtiofsd: Ensure crash consistency after reconnection Jiachen Zhang
2020-12-15 16:21 ` Jiachen Zhang
2020-12-15 16:21 ` [Virtio-fs] [RFC PATCH 9/9] virtiofsd: (work around) Comment qsort in inflight I/O tracking Jiachen Zhang
2020-12-15 16:21 ` Jiachen Zhang
2021-02-04 12:15 ` [Virtio-fs] " Dr. David Alan Gilbert
2021-02-04 12:15 ` Dr. David Alan Gilbert
2021-02-04 14:20 ` [Virtio-fs] [External] " Jiachen Zhang
2021-02-04 14:20 ` Jiachen Zhang
2020-12-15 22:51 ` [Virtio-fs] [RFC PATCH 0/9] Support for Virtio-fs daemon crash reconnection no-reply
2020-12-15 22:51 ` no-reply
2020-12-16 15:36 ` [Virtio-fs] " Marc-André Lureau
2020-12-16 15:36 ` Marc-André Lureau
2020-12-18 9:39 ` [Virtio-fs] [External] " Jiachen Zhang
2020-12-18 9:39 ` Jiachen Zhang
2021-03-17 10:05 ` [Virtio-fs] " Stefan Hajnoczi
2021-03-17 10:05 ` Stefan Hajnoczi
2021-03-17 11:49 ` Christian Schoenebeck [this message]
2021-03-17 11:49 ` Christian Schoenebeck
2021-03-17 12:57 ` [Virtio-fs] " Jiachen Zhang
2021-03-17 12:57 ` Jiachen Zhang
2021-03-18 11:58 ` [Virtio-fs] " Christian Schoenebeck
2021-03-18 11:58 ` Christian Schoenebeck
2021-03-22 10:54 ` [Virtio-fs] " Stefan Hajnoczi
2021-03-22 10:54 ` Stefan Hajnoczi
2021-03-23 12:54 ` [Virtio-fs] " Christian Schoenebeck
2021-03-23 12:54 ` Christian Schoenebeck
2021-03-23 14:25 ` [Virtio-fs] " Stefan Hajnoczi
2021-03-23 14:25 ` Stefan Hajnoczi
2021-03-17 12:32 ` [Virtio-fs] " Jiachen Zhang
2021-03-17 12:32 ` Jiachen Zhang
2021-03-22 11:00 ` [Virtio-fs] " Stefan Hajnoczi
2021-03-22 11:00 ` Stefan Hajnoczi
2021-03-22 20:13 ` [Virtio-fs] " Vivek Goyal
2021-03-22 20:13 ` Vivek Goyal
2021-03-23 13:45 ` Stefan Hajnoczi
2021-03-23 13:45 ` Stefan Hajnoczi
2021-05-10 14:38 ` [Virtio-fs] " Jiachen Zhang
2021-05-10 14:38 ` Jiachen Zhang
2021-05-13 15:17 ` [Virtio-fs] " Stefan Hajnoczi
2021-05-13 15:17 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1709993.NBFj2RoZ23@silver \
--to=qemu_oss@crudebyte.com \
--cc=berrange@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=virtio-fs@redhat.com \
--cc=xieyongji@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.