All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: "Daniel P. Berrange" <berrange@redhat.com>,
	"Michael S . Tsirkin" <mst@redhat.com>,
	QEMU <qemu-devel@nongnu.org>,
	virtio-fs@redhat.com, "Xie Yongji" <xieyongji@bytedance.com>,
	"Marc-André Lureau" <marcandre.lureau@gmail.com>
Subject: Re: [Virtio-fs] [External] Re: [RFC PATCH 0/9] Support for Virtio-fs daemon crash reconnection
Date: Mon, 22 Mar 2021 16:13:26 -0400	[thread overview]
Message-ID: <20210322201326.GH446288@redhat.com> (raw)
In-Reply-To: <YFh45AUkh1OzbE6H@stefanha-x1.localdomain>

On Mon, Mar 22, 2021 at 11:00:52AM +0000, Stefan Hajnoczi wrote:
> On Wed, Mar 17, 2021 at 08:32:31PM +0800, Jiachen Zhang wrote:
> > On Wed, Mar 17, 2021 at 6:05 PM Stefan Hajnoczi <stefanha@redhat.com> wrote:
> > > On Fri, Dec 18, 2020 at 05:39:34PM +0800, Jiachen Zhang wrote:
> > I agreed with you that a virtiofsd must be launched by a software like
> > systemd. So we are planning to define more generic persist/restore
> > interfaces (callbacks). Then anyone can implement their own persist/restore
> > callbacks to store states to proper places.  And I think in the next
> > version we will implement default callbacks for the interfaces. Instead of
> > vhost-user messages, systemd's sd_notify(3) will be the default method for
> > storing fds, and several tmpfs files can be the default place to store the
> > shm regions.
> 
> Okay, great!
> 
> I was thinking about how to make the crash recovery mechanism reusable
> as a C library or Rust crate. The mechanism is a combination of:
> 1. sd_listen_fds(3) for restoring the fds on restart.
> 2. sd_notify(3) for storing the fds.
> 3. memfd or tmpfs for storing state (could be mmapped).
> 
> I'm not sure if there is enough common behavior to create a reusable API
> or if this is quite application-specific.

I am wondering what will happen for use cases where virtiofsd is running
inside a container (with no systemd inside containers).

Do container managers offer systemd like services to save and restore
state.

Vivek


WARNING: multiple messages have this Message-ID (diff)
From: Vivek Goyal <vgoyal@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: "Daniel P. Berrange" <berrange@redhat.com>,
	"Michael S . Tsirkin" <mst@redhat.com>,
	QEMU <qemu-devel@nongnu.org>,
	virtio-fs@redhat.com, "Xie Yongji" <xieyongji@bytedance.com>,
	"Jiachen Zhang" <zhangjiachen.jaycee@bytedance.com>,
	"Marc-André Lureau" <marcandre.lureau@gmail.com>
Subject: Re: [Virtio-fs] [External] Re: [RFC PATCH 0/9] Support for Virtio-fs daemon crash reconnection
Date: Mon, 22 Mar 2021 16:13:26 -0400	[thread overview]
Message-ID: <20210322201326.GH446288@redhat.com> (raw)
In-Reply-To: <YFh45AUkh1OzbE6H@stefanha-x1.localdomain>

On Mon, Mar 22, 2021 at 11:00:52AM +0000, Stefan Hajnoczi wrote:
> On Wed, Mar 17, 2021 at 08:32:31PM +0800, Jiachen Zhang wrote:
> > On Wed, Mar 17, 2021 at 6:05 PM Stefan Hajnoczi <stefanha@redhat.com> wrote:
> > > On Fri, Dec 18, 2020 at 05:39:34PM +0800, Jiachen Zhang wrote:
> > I agreed with you that a virtiofsd must be launched by a software like
> > systemd. So we are planning to define more generic persist/restore
> > interfaces (callbacks). Then anyone can implement their own persist/restore
> > callbacks to store states to proper places.  And I think in the next
> > version we will implement default callbacks for the interfaces. Instead of
> > vhost-user messages, systemd's sd_notify(3) will be the default method for
> > storing fds, and several tmpfs files can be the default place to store the
> > shm regions.
> 
> Okay, great!
> 
> I was thinking about how to make the crash recovery mechanism reusable
> as a C library or Rust crate. The mechanism is a combination of:
> 1. sd_listen_fds(3) for restoring the fds on restart.
> 2. sd_notify(3) for storing the fds.
> 3. memfd or tmpfs for storing state (could be mmapped).
> 
> I'm not sure if there is enough common behavior to create a reusable API
> or if this is quite application-specific.

I am wondering what will happen for use cases where virtiofsd is running
inside a container (with no systemd inside containers).

Do container managers offer systemd like services to save and restore
state.

Vivek



  reply	other threads:[~2021-03-22 20:13 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-15 16:21 [Virtio-fs] [RFC PATCH 0/9] Support for Virtio-fs daemon crash reconnection Jiachen Zhang
2020-12-15 16:21 ` Jiachen Zhang
2020-12-15 16:21 ` [Virtio-fs] [RFC PATCH 1/9] vhost-user-fs: Add support for reconnection of vhost-user-fs backend Jiachen Zhang
2020-12-15 16:21   ` Jiachen Zhang
2020-12-15 16:21 ` [Virtio-fs] [RFC PATCH 2/9] vhost: Add vhost-user message types for sending shared memory and file fds Jiachen Zhang
2020-12-15 16:21   ` Jiachen Zhang
2020-12-15 16:21 ` [Virtio-fs] [RFC PATCH 3/9] vhost-user-fs: Support virtiofsd crash reconnection Jiachen Zhang
2020-12-15 16:21   ` Jiachen Zhang
2020-12-15 16:21 ` [Virtio-fs] [RFC PATCH 4/9] libvhost-user: Add vhost-user message types for sending shared memory and file fds Jiachen Zhang
2020-12-15 16:21   ` Jiachen Zhang
2020-12-15 16:21 ` [Virtio-fs] [RFC PATCH 5/9] virtiofsd: Convert the struct lo_map array to a more flatten layout Jiachen Zhang
2020-12-15 16:21   ` Jiachen Zhang
2020-12-15 16:21 ` [Virtio-fs] [RFC PATCH 6/9] virtiofsd: Add two new options for crash reconnection Jiachen Zhang
2020-12-15 16:21   ` Jiachen Zhang
2021-02-04 12:08   ` [Virtio-fs] " Dr. David Alan Gilbert
2021-02-04 12:08     ` Dr. David Alan Gilbert
2021-02-04 14:16     ` [Virtio-fs] [External] " Jiachen Zhang
2021-02-04 14:16       ` Jiachen Zhang
2020-12-15 16:21 ` [Virtio-fs] [RFC PATCH 7/9] virtiofsd: Persist/restore lo_map and opened fds to/from QEMU Jiachen Zhang
2020-12-15 16:21   ` Jiachen Zhang
2020-12-15 16:21 ` [Virtio-fs] [RFC PATCH 8/9] virtiofsd: Ensure crash consistency after reconnection Jiachen Zhang
2020-12-15 16:21   ` Jiachen Zhang
2020-12-15 16:21 ` [Virtio-fs] [RFC PATCH 9/9] virtiofsd: (work around) Comment qsort in inflight I/O tracking Jiachen Zhang
2020-12-15 16:21   ` Jiachen Zhang
2021-02-04 12:15   ` [Virtio-fs] " Dr. David Alan Gilbert
2021-02-04 12:15     ` Dr. David Alan Gilbert
2021-02-04 14:20     ` [Virtio-fs] [External] " Jiachen Zhang
2021-02-04 14:20       ` Jiachen Zhang
2020-12-15 22:51 ` [Virtio-fs] [RFC PATCH 0/9] Support for Virtio-fs daemon crash reconnection no-reply
2020-12-15 22:51   ` no-reply
2020-12-16 15:36 ` [Virtio-fs] " Marc-André Lureau
2020-12-16 15:36   ` Marc-André Lureau
2020-12-18  9:39   ` [Virtio-fs] [External] " Jiachen Zhang
2020-12-18  9:39     ` Jiachen Zhang
2021-03-17 10:05     ` [Virtio-fs] " Stefan Hajnoczi
2021-03-17 10:05       ` Stefan Hajnoczi
2021-03-17 11:49       ` [Virtio-fs] " Christian Schoenebeck
2021-03-17 11:49         ` Christian Schoenebeck
2021-03-17 12:57         ` [Virtio-fs] " Jiachen Zhang
2021-03-17 12:57           ` Jiachen Zhang
2021-03-18 11:58           ` [Virtio-fs] " Christian Schoenebeck
2021-03-18 11:58             ` Christian Schoenebeck
2021-03-22 10:54             ` [Virtio-fs] " Stefan Hajnoczi
2021-03-22 10:54               ` Stefan Hajnoczi
2021-03-23 12:54               ` [Virtio-fs] " Christian Schoenebeck
2021-03-23 12:54                 ` Christian Schoenebeck
2021-03-23 14:25                 ` [Virtio-fs] " Stefan Hajnoczi
2021-03-23 14:25                   ` Stefan Hajnoczi
2021-03-17 12:32       ` [Virtio-fs] " Jiachen Zhang
2021-03-17 12:32         ` Jiachen Zhang
2021-03-22 11:00         ` [Virtio-fs] " Stefan Hajnoczi
2021-03-22 11:00           ` Stefan Hajnoczi
2021-03-22 20:13           ` Vivek Goyal [this message]
2021-03-22 20:13             ` [Virtio-fs] " Vivek Goyal
2021-03-23 13:45             ` Stefan Hajnoczi
2021-03-23 13:45               ` Stefan Hajnoczi
2021-05-10 14:38 ` [Virtio-fs] " Jiachen Zhang
2021-05-10 14:38   ` Jiachen Zhang
2021-05-13 15:17   ` [Virtio-fs] " Stefan Hajnoczi
2021-05-13 15:17     ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210322201326.GH446288@redhat.com \
    --to=vgoyal@redhat.com \
    --cc=berrange@redhat.com \
    --cc=marcandre.lureau@gmail.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=virtio-fs@redhat.com \
    --cc=xieyongji@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.