All of lore.kernel.org
 help / color / mirror / Atom feed
From: patchwork-bot+netdevbpf@kernel.org
To: Sean Anderson <sean.anderson@linux.dev>
Cc: s.trumtrar@pengutronix.de, linux-kernel@vger.kernel.org,
	madalin.bucur@nxp.com, vladimir.oltean@nxp.com,
	roy.pledge@nxp.com, claudiu.manoil@nxp.com, leoyang.li@nxp.com,
	oss@buserror.net, edumazet@google.com, camelia.groza@nxp.com,
	netdev@vger.kernel.org, kuba@kernel.org, stable@vger.kernel.org,
	pabeni@redhat.com, linuxppc-dev@lists.ozlabs.org,
	davem@davemloft.net, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net v5 1/2] soc: fsl: qbman: Always disable interrupts when taking cgr_lock
Date: Wed, 13 Mar 2024 08:20:29 +0000	[thread overview]
Message-ID: <171031802931.29357.17308276522742025565.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20240311163830.12952-1-sean.anderson@linux.dev>

Hello:

This series was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:

On Mon, 11 Mar 2024 12:38:29 -0400 you wrote:
> smp_call_function_single disables IRQs when executing the callback. To
> prevent deadlocks, we must disable IRQs when taking cgr_lock elsewhere.
> This is already done by qman_update_cgr and qman_delete_cgr; fix the
> other lockers.
> 
> Fixes: 96f413f47677 ("soc/fsl/qbman: fix issue in qman_delete_cgr_safe()")
> CC: stable@vger.kernel.org
> Signed-off-by: Sean Anderson <sean.anderson@linux.dev>
> Reviewed-by: Camelia Groza <camelia.groza@nxp.com>
> Tested-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> 
> [...]

Here is the summary with links:
  - [net,v5,1/2] soc: fsl: qbman: Always disable interrupts when taking cgr_lock
    https://git.kernel.org/netdev/net/c/584c2a9184a3
  - [net,v5,2/2] soc: fsl: qbman: Use raw spinlock for cgr_lock
    https://git.kernel.org/netdev/net/c/fbec4e7fed89

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



WARNING: multiple messages have this Message-ID (diff)
From: patchwork-bot+netdevbpf@kernel.org
To: Sean Anderson <sean.anderson@linux.dev>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, netdev@vger.kernel.org,
	vladimir.oltean@nxp.com, christophe.leroy@csgroup.eu,
	roy.pledge@nxp.com, linuxppc-dev@lists.ozlabs.org,
	madalin.bucur@nxp.com, s.trumtrar@pengutronix.de,
	claudiu.manoil@nxp.com, leoyang.li@nxp.com, oss@buserror.net,
	camelia.groza@nxp.com, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH net v5 1/2] soc: fsl: qbman: Always disable interrupts when taking cgr_lock
Date: Wed, 13 Mar 2024 08:20:29 +0000	[thread overview]
Message-ID: <171031802931.29357.17308276522742025565.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20240311163830.12952-1-sean.anderson@linux.dev>

Hello:

This series was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:

On Mon, 11 Mar 2024 12:38:29 -0400 you wrote:
> smp_call_function_single disables IRQs when executing the callback. To
> prevent deadlocks, we must disable IRQs when taking cgr_lock elsewhere.
> This is already done by qman_update_cgr and qman_delete_cgr; fix the
> other lockers.
> 
> Fixes: 96f413f47677 ("soc/fsl/qbman: fix issue in qman_delete_cgr_safe()")
> CC: stable@vger.kernel.org
> Signed-off-by: Sean Anderson <sean.anderson@linux.dev>
> Reviewed-by: Camelia Groza <camelia.groza@nxp.com>
> Tested-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> 
> [...]

Here is the summary with links:
  - [net,v5,1/2] soc: fsl: qbman: Always disable interrupts when taking cgr_lock
    https://git.kernel.org/netdev/net/c/584c2a9184a3
  - [net,v5,2/2] soc: fsl: qbman: Use raw spinlock for cgr_lock
    https://git.kernel.org/netdev/net/c/fbec4e7fed89

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



WARNING: multiple messages have this Message-ID (diff)
From: patchwork-bot+netdevbpf@kernel.org
To: Sean Anderson <sean.anderson@linux.dev>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, netdev@vger.kernel.org,
	vladimir.oltean@nxp.com, christophe.leroy@csgroup.eu,
	roy.pledge@nxp.com, linuxppc-dev@lists.ozlabs.org,
	madalin.bucur@nxp.com, s.trumtrar@pengutronix.de,
	claudiu.manoil@nxp.com, leoyang.li@nxp.com, oss@buserror.net,
	camelia.groza@nxp.com, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH net v5 1/2] soc: fsl: qbman: Always disable interrupts when taking cgr_lock
Date: Wed, 13 Mar 2024 08:20:29 +0000	[thread overview]
Message-ID: <171031802931.29357.17308276522742025565.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20240311163830.12952-1-sean.anderson@linux.dev>

Hello:

This series was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:

On Mon, 11 Mar 2024 12:38:29 -0400 you wrote:
> smp_call_function_single disables IRQs when executing the callback. To
> prevent deadlocks, we must disable IRQs when taking cgr_lock elsewhere.
> This is already done by qman_update_cgr and qman_delete_cgr; fix the
> other lockers.
> 
> Fixes: 96f413f47677 ("soc/fsl/qbman: fix issue in qman_delete_cgr_safe()")
> CC: stable@vger.kernel.org
> Signed-off-by: Sean Anderson <sean.anderson@linux.dev>
> Reviewed-by: Camelia Groza <camelia.groza@nxp.com>
> Tested-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> 
> [...]

Here is the summary with links:
  - [net,v5,1/2] soc: fsl: qbman: Always disable interrupts when taking cgr_lock
    https://git.kernel.org/netdev/net/c/584c2a9184a3
  - [net,v5,2/2] soc: fsl: qbman: Use raw spinlock for cgr_lock
    https://git.kernel.org/netdev/net/c/fbec4e7fed89

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2024-03-13  8:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-11 16:38 [PATCH net v5 1/2] soc: fsl: qbman: Always disable interrupts when taking cgr_lock Sean Anderson
2024-03-11 16:38 ` Sean Anderson
2024-03-11 16:38 ` Sean Anderson
2024-03-11 16:38 ` [PATCH net v5 2/2] soc: fsl: qbman: Use raw spinlock for cgr_lock Sean Anderson
2024-03-11 16:38   ` Sean Anderson
2024-03-11 16:38   ` Sean Anderson
2024-03-13  8:20 ` patchwork-bot+netdevbpf [this message]
2024-03-13  8:20   ` [PATCH net v5 1/2] soc: fsl: qbman: Always disable interrupts when taking cgr_lock patchwork-bot+netdevbpf
2024-03-13  8:20   ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=171031802931.29357.17308276522742025565.git-patchwork-notify@kernel.org \
    --to=patchwork-bot+netdevbpf@kernel.org \
    --cc=camelia.groza@nxp.com \
    --cc=claudiu.manoil@nxp.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=leoyang.li@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=madalin.bucur@nxp.com \
    --cc=netdev@vger.kernel.org \
    --cc=oss@buserror.net \
    --cc=pabeni@redhat.com \
    --cc=roy.pledge@nxp.com \
    --cc=s.trumtrar@pengutronix.de \
    --cc=sean.anderson@linux.dev \
    --cc=stable@vger.kernel.org \
    --cc=vladimir.oltean@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.