* [PATCH] arm64: dts: qcom: sa8775p: Add 'global' IRQ for PCIe controllers @ 2025-02-09 15:39 Manivannan Sadhasivam 2025-02-10 16:22 ` Rob Herring (Arm) 0 siblings, 1 reply; 4+ messages in thread From: Manivannan Sadhasivam @ 2025-02-09 15:39 UTC (permalink / raw) To: andersson, konradybcio, robh, krzk+dt, conor+dt Cc: linux-arm-msm, devicetree, linux-kernel, Manivannan Sadhasivam 'global' IRQ is used to receive vendor specific events from the PCIe controller. Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> --- arch/arm64/boot/dts/qcom/sa8775p.dtsi | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi index 3394ae2d1300..7355ef9bac21 100644 --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi @@ -6421,9 +6421,10 @@ pcie0: pcie@1c00000 { <GIC_SPI 313 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 314 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 374 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 375 IRQ_TYPE_LEVEL_HIGH>; + <GIC_SPI 375 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 306 IRQ_TYPE_LEVEL_HIGH>; interrupt-names = "msi0", "msi1", "msi2", "msi3", - "msi4", "msi5", "msi6", "msi7"; + "msi4", "msi5", "msi6", "msi7", "global"; #interrupt-cells = <1>; interrupt-map-mask = <0 0 0 0x7>; interrupt-map = <0 0 0 1 &intc GIC_SPI 434 IRQ_TYPE_LEVEL_HIGH>, @@ -6579,9 +6580,10 @@ pcie1: pcie@1c10000 { <GIC_SPI 143 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 144 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 145 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 146 IRQ_TYPE_LEVEL_HIGH>; + <GIC_SPI 146 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 518 IRQ_TYPE_LEVEL_HIGH>; interrupt-names = "msi0", "msi1", "msi2", "msi3", - "msi4", "msi5", "msi6", "msi7"; + "msi4", "msi5", "msi6", "msi7", "global"; #interrupt-cells = <1>; interrupt-map-mask = <0 0 0 0x7>; interrupt-map = <0 0 0 1 &intc GIC_SPI 148 IRQ_TYPE_LEVEL_HIGH>, -- 2.25.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sa8775p: Add 'global' IRQ for PCIe controllers 2025-02-09 15:39 [PATCH] arm64: dts: qcom: sa8775p: Add 'global' IRQ for PCIe controllers Manivannan Sadhasivam @ 2025-02-10 16:22 ` Rob Herring (Arm) 2025-02-10 16:58 ` Manivannan Sadhasivam 0 siblings, 1 reply; 4+ messages in thread From: Rob Herring (Arm) @ 2025-02-10 16:22 UTC (permalink / raw) To: Manivannan Sadhasivam Cc: krzk+dt, linux-kernel, linux-arm-msm, conor+dt, andersson, konradybcio, devicetree On Sun, 09 Feb 2025 21:09:40 +0530, Manivannan Sadhasivam wrote: > 'global' IRQ is used to receive vendor specific events from the PCIe > controller. > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > --- > arch/arm64/boot/dts/qcom/sa8775p.dtsi | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/qcom/' for 20250209153940.3489-1-manivannan.sadhasivam@linaro.org: arch/arm64/boot/dts/qcom/qcs9100-ride.dtb: pcie@1c00000: interrupts: [[0, 307, 4], [0, 308, 4], [0, 309, 4], [0, 312, 4], [0, 313, 4], [0, 314, 4], [0, 374, 4], [0, 375, 4], [0, 306, 4]] is too long from schema $id: http://devicetree.org/schemas/pci/qcom,pcie-sa8775p.yaml# arch/arm64/boot/dts/qcom/qcs9100-ride.dtb: pcie@1c00000: interrupt-names: ['msi0', 'msi1', 'msi2', 'msi3', 'msi4', 'msi5', 'msi6', 'msi7', 'global'] is too long from schema $id: http://devicetree.org/schemas/pci/qcom,pcie-sa8775p.yaml# arch/arm64/boot/dts/qcom/qcs9100-ride.dtb: pcie@1c10000: interrupts: [[0, 519, 4], [0, 140, 4], [0, 141, 4], [0, 142, 4], [0, 143, 4], [0, 144, 4], [0, 145, 4], [0, 146, 4], [0, 518, 4]] is too long from schema $id: http://devicetree.org/schemas/pci/qcom,pcie-sa8775p.yaml# arch/arm64/boot/dts/qcom/qcs9100-ride.dtb: pcie@1c10000: interrupt-names: ['msi0', 'msi1', 'msi2', 'msi3', 'msi4', 'msi5', 'msi6', 'msi7', 'global'] is too long from schema $id: http://devicetree.org/schemas/pci/qcom,pcie-sa8775p.yaml# arch/arm64/boot/dts/qcom/sa8775p-ride.dtb: pcie@1c00000: interrupts: [[0, 307, 4], [0, 308, 4], [0, 309, 4], [0, 312, 4], [0, 313, 4], [0, 314, 4], [0, 374, 4], [0, 375, 4], [0, 306, 4]] is too long from schema $id: http://devicetree.org/schemas/pci/qcom,pcie-sa8775p.yaml# arch/arm64/boot/dts/qcom/sa8775p-ride.dtb: pcie@1c00000: interrupt-names: ['msi0', 'msi1', 'msi2', 'msi3', 'msi4', 'msi5', 'msi6', 'msi7', 'global'] is too long from schema $id: http://devicetree.org/schemas/pci/qcom,pcie-sa8775p.yaml# arch/arm64/boot/dts/qcom/sa8775p-ride.dtb: pcie@1c10000: interrupts: [[0, 519, 4], [0, 140, 4], [0, 141, 4], [0, 142, 4], [0, 143, 4], [0, 144, 4], [0, 145, 4], [0, 146, 4], [0, 518, 4]] is too long from schema $id: http://devicetree.org/schemas/pci/qcom,pcie-sa8775p.yaml# arch/arm64/boot/dts/qcom/sa8775p-ride.dtb: pcie@1c10000: interrupt-names: ['msi0', 'msi1', 'msi2', 'msi3', 'msi4', 'msi5', 'msi6', 'msi7', 'global'] is too long from schema $id: http://devicetree.org/schemas/pci/qcom,pcie-sa8775p.yaml# arch/arm64/boot/dts/qcom/qcs9100-ride-r3.dtb: pcie@1c00000: interrupts: [[0, 307, 4], [0, 308, 4], [0, 309, 4], [0, 312, 4], [0, 313, 4], [0, 314, 4], [0, 374, 4], [0, 375, 4], [0, 306, 4]] is too long from schema $id: http://devicetree.org/schemas/pci/qcom,pcie-sa8775p.yaml# arch/arm64/boot/dts/qcom/qcs9100-ride-r3.dtb: pcie@1c00000: interrupt-names: ['msi0', 'msi1', 'msi2', 'msi3', 'msi4', 'msi5', 'msi6', 'msi7', 'global'] is too long from schema $id: http://devicetree.org/schemas/pci/qcom,pcie-sa8775p.yaml# arch/arm64/boot/dts/qcom/qcs9100-ride-r3.dtb: pcie@1c10000: interrupts: [[0, 519, 4], [0, 140, 4], [0, 141, 4], [0, 142, 4], [0, 143, 4], [0, 144, 4], [0, 145, 4], [0, 146, 4], [0, 518, 4]] is too long from schema $id: http://devicetree.org/schemas/pci/qcom,pcie-sa8775p.yaml# arch/arm64/boot/dts/qcom/qcs9100-ride-r3.dtb: pcie@1c10000: interrupt-names: ['msi0', 'msi1', 'msi2', 'msi3', 'msi4', 'msi5', 'msi6', 'msi7', 'global'] is too long from schema $id: http://devicetree.org/schemas/pci/qcom,pcie-sa8775p.yaml# arch/arm64/boot/dts/qcom/sa8775p-ride-r3.dtb: pcie@1c00000: interrupts: [[0, 307, 4], [0, 308, 4], [0, 309, 4], [0, 312, 4], [0, 313, 4], [0, 314, 4], [0, 374, 4], [0, 375, 4], [0, 306, 4]] is too long from schema $id: http://devicetree.org/schemas/pci/qcom,pcie-sa8775p.yaml# arch/arm64/boot/dts/qcom/sa8775p-ride-r3.dtb: pcie@1c00000: interrupt-names: ['msi0', 'msi1', 'msi2', 'msi3', 'msi4', 'msi5', 'msi6', 'msi7', 'global'] is too long from schema $id: http://devicetree.org/schemas/pci/qcom,pcie-sa8775p.yaml# arch/arm64/boot/dts/qcom/sa8775p-ride-r3.dtb: pcie@1c10000: interrupts: [[0, 519, 4], [0, 140, 4], [0, 141, 4], [0, 142, 4], [0, 143, 4], [0, 144, 4], [0, 145, 4], [0, 146, 4], [0, 518, 4]] is too long from schema $id: http://devicetree.org/schemas/pci/qcom,pcie-sa8775p.yaml# arch/arm64/boot/dts/qcom/sa8775p-ride-r3.dtb: pcie@1c10000: interrupt-names: ['msi0', 'msi1', 'msi2', 'msi3', 'msi4', 'msi5', 'msi6', 'msi7', 'global'] is too long from schema $id: http://devicetree.org/schemas/pci/qcom,pcie-sa8775p.yaml# ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sa8775p: Add 'global' IRQ for PCIe controllers 2025-02-10 16:22 ` Rob Herring (Arm) @ 2025-02-10 16:58 ` Manivannan Sadhasivam 2025-02-10 17:55 ` Konrad Dybcio 0 siblings, 1 reply; 4+ messages in thread From: Manivannan Sadhasivam @ 2025-02-10 16:58 UTC (permalink / raw) To: Rob Herring (Arm) Cc: krzk+dt, linux-kernel, linux-arm-msm, conor+dt, andersson, konradybcio, devicetree On Mon, Feb 10, 2025 at 10:22:43AM -0600, Rob Herring (Arm) wrote: > > On Sun, 09 Feb 2025 21:09:40 +0530, Manivannan Sadhasivam wrote: > > 'global' IRQ is used to receive vendor specific events from the PCIe > > controller. > > > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > > --- > > arch/arm64/boot/dts/qcom/sa8775p.dtsi | 10 ++++++---- > > 1 file changed, 6 insertions(+), 4 deletions(-) > > > > > My bot found new DTB warnings on the .dts files added or changed in this > series. > Ah. I didn't run dtbs check. Please ignore this one, I'll post along with bindings change. - Mani > Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings > are fixed by another series. Ultimately, it is up to the platform > maintainer whether these warnings are acceptable or not. No need to reply > unless the platform maintainer has comments. > > If you already ran DT checks and didn't see these error(s), then > make sure dt-schema is up to date: > > pip3 install dtschema --upgrade > > > New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/qcom/' for 20250209153940.3489-1-manivannan.sadhasivam@linaro.org: > > arch/arm64/boot/dts/qcom/qcs9100-ride.dtb: pcie@1c00000: interrupts: [[0, 307, 4], [0, 308, 4], [0, 309, 4], [0, 312, 4], [0, 313, 4], [0, 314, 4], [0, 374, 4], [0, 375, 4], [0, 306, 4]] is too long > from schema $id: http://devicetree.org/schemas/pci/qcom,pcie-sa8775p.yaml# > arch/arm64/boot/dts/qcom/qcs9100-ride.dtb: pcie@1c00000: interrupt-names: ['msi0', 'msi1', 'msi2', 'msi3', 'msi4', 'msi5', 'msi6', 'msi7', 'global'] is too long > from schema $id: http://devicetree.org/schemas/pci/qcom,pcie-sa8775p.yaml# > arch/arm64/boot/dts/qcom/qcs9100-ride.dtb: pcie@1c10000: interrupts: [[0, 519, 4], [0, 140, 4], [0, 141, 4], [0, 142, 4], [0, 143, 4], [0, 144, 4], [0, 145, 4], [0, 146, 4], [0, 518, 4]] is too long > from schema $id: http://devicetree.org/schemas/pci/qcom,pcie-sa8775p.yaml# > arch/arm64/boot/dts/qcom/qcs9100-ride.dtb: pcie@1c10000: interrupt-names: ['msi0', 'msi1', 'msi2', 'msi3', 'msi4', 'msi5', 'msi6', 'msi7', 'global'] is too long > from schema $id: http://devicetree.org/schemas/pci/qcom,pcie-sa8775p.yaml# > arch/arm64/boot/dts/qcom/sa8775p-ride.dtb: pcie@1c00000: interrupts: [[0, 307, 4], [0, 308, 4], [0, 309, 4], [0, 312, 4], [0, 313, 4], [0, 314, 4], [0, 374, 4], [0, 375, 4], [0, 306, 4]] is too long > from schema $id: http://devicetree.org/schemas/pci/qcom,pcie-sa8775p.yaml# > arch/arm64/boot/dts/qcom/sa8775p-ride.dtb: pcie@1c00000: interrupt-names: ['msi0', 'msi1', 'msi2', 'msi3', 'msi4', 'msi5', 'msi6', 'msi7', 'global'] is too long > from schema $id: http://devicetree.org/schemas/pci/qcom,pcie-sa8775p.yaml# > arch/arm64/boot/dts/qcom/sa8775p-ride.dtb: pcie@1c10000: interrupts: [[0, 519, 4], [0, 140, 4], [0, 141, 4], [0, 142, 4], [0, 143, 4], [0, 144, 4], [0, 145, 4], [0, 146, 4], [0, 518, 4]] is too long > from schema $id: http://devicetree.org/schemas/pci/qcom,pcie-sa8775p.yaml# > arch/arm64/boot/dts/qcom/sa8775p-ride.dtb: pcie@1c10000: interrupt-names: ['msi0', 'msi1', 'msi2', 'msi3', 'msi4', 'msi5', 'msi6', 'msi7', 'global'] is too long > from schema $id: http://devicetree.org/schemas/pci/qcom,pcie-sa8775p.yaml# > arch/arm64/boot/dts/qcom/qcs9100-ride-r3.dtb: pcie@1c00000: interrupts: [[0, 307, 4], [0, 308, 4], [0, 309, 4], [0, 312, 4], [0, 313, 4], [0, 314, 4], [0, 374, 4], [0, 375, 4], [0, 306, 4]] is too long > from schema $id: http://devicetree.org/schemas/pci/qcom,pcie-sa8775p.yaml# > arch/arm64/boot/dts/qcom/qcs9100-ride-r3.dtb: pcie@1c00000: interrupt-names: ['msi0', 'msi1', 'msi2', 'msi3', 'msi4', 'msi5', 'msi6', 'msi7', 'global'] is too long > from schema $id: http://devicetree.org/schemas/pci/qcom,pcie-sa8775p.yaml# > arch/arm64/boot/dts/qcom/qcs9100-ride-r3.dtb: pcie@1c10000: interrupts: [[0, 519, 4], [0, 140, 4], [0, 141, 4], [0, 142, 4], [0, 143, 4], [0, 144, 4], [0, 145, 4], [0, 146, 4], [0, 518, 4]] is too long > from schema $id: http://devicetree.org/schemas/pci/qcom,pcie-sa8775p.yaml# > arch/arm64/boot/dts/qcom/qcs9100-ride-r3.dtb: pcie@1c10000: interrupt-names: ['msi0', 'msi1', 'msi2', 'msi3', 'msi4', 'msi5', 'msi6', 'msi7', 'global'] is too long > from schema $id: http://devicetree.org/schemas/pci/qcom,pcie-sa8775p.yaml# > arch/arm64/boot/dts/qcom/sa8775p-ride-r3.dtb: pcie@1c00000: interrupts: [[0, 307, 4], [0, 308, 4], [0, 309, 4], [0, 312, 4], [0, 313, 4], [0, 314, 4], [0, 374, 4], [0, 375, 4], [0, 306, 4]] is too long > from schema $id: http://devicetree.org/schemas/pci/qcom,pcie-sa8775p.yaml# > arch/arm64/boot/dts/qcom/sa8775p-ride-r3.dtb: pcie@1c00000: interrupt-names: ['msi0', 'msi1', 'msi2', 'msi3', 'msi4', 'msi5', 'msi6', 'msi7', 'global'] is too long > from schema $id: http://devicetree.org/schemas/pci/qcom,pcie-sa8775p.yaml# > arch/arm64/boot/dts/qcom/sa8775p-ride-r3.dtb: pcie@1c10000: interrupts: [[0, 519, 4], [0, 140, 4], [0, 141, 4], [0, 142, 4], [0, 143, 4], [0, 144, 4], [0, 145, 4], [0, 146, 4], [0, 518, 4]] is too long > from schema $id: http://devicetree.org/schemas/pci/qcom,pcie-sa8775p.yaml# > arch/arm64/boot/dts/qcom/sa8775p-ride-r3.dtb: pcie@1c10000: interrupt-names: ['msi0', 'msi1', 'msi2', 'msi3', 'msi4', 'msi5', 'msi6', 'msi7', 'global'] is too long > from schema $id: http://devicetree.org/schemas/pci/qcom,pcie-sa8775p.yaml# > > > > > -- மணிவண்ணன் சதாசிவம் ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sa8775p: Add 'global' IRQ for PCIe controllers 2025-02-10 16:58 ` Manivannan Sadhasivam @ 2025-02-10 17:55 ` Konrad Dybcio 0 siblings, 0 replies; 4+ messages in thread From: Konrad Dybcio @ 2025-02-10 17:55 UTC (permalink / raw) To: Manivannan Sadhasivam, Rob Herring (Arm) Cc: krzk+dt, linux-kernel, linux-arm-msm, conor+dt, andersson, konradybcio, devicetree On 10.02.2025 5:58 PM, Manivannan Sadhasivam wrote: > On Mon, Feb 10, 2025 at 10:22:43AM -0600, Rob Herring (Arm) wrote: >> >> On Sun, 09 Feb 2025 21:09:40 +0530, Manivannan Sadhasivam wrote: >>> 'global' IRQ is used to receive vendor specific events from the PCIe >>> controller. >>> >>> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> >>> --- >>> arch/arm64/boot/dts/qcom/sa8775p.dtsi | 10 ++++++---- >>> 1 file changed, 6 insertions(+), 4 deletions(-) >>> >> >> >> My bot found new DTB warnings on the .dts files added or changed in this >> series. >> > > Ah. I didn't run dtbs check. Please ignore this one, I'll post along with > bindings change. I'd be grateful if you turned interrupt-names into a vertical list in the next resend Konrad ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-02-10 17:55 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2025-02-09 15:39 [PATCH] arm64: dts: qcom: sa8775p: Add 'global' IRQ for PCIe controllers Manivannan Sadhasivam 2025-02-10 16:22 ` Rob Herring (Arm) 2025-02-10 16:58 ` Manivannan Sadhasivam 2025-02-10 17:55 ` Konrad Dybcio
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.