All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: stable@vger.kernel.org
Cc: Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH v5.10] scsi: pm80xx: Fix memory leak during rmmod
Date: Mon, 11 Aug 2025 18:30:27 -0400	[thread overview]
Message-ID: <1754925250-783d021d@stable.kernel.org> (raw)
In-Reply-To: <20250811052035.145021-1-shivani.agarwal@broadcom.com>

[ Sasha's backport helper bot ]

Hi,

✅ All tests passed successfully. No issues detected.
No action required from the submitter.

The upstream commit SHA1 provided is correct: 51e6ed83bb4ade7c360551fa4ae55c4eacea354b

WARNING: Author mismatch between patch and upstream commit:
Backport author: Shivani Agarwal <shivani.agarwal@broadcom.com>
Commit author: Ajish Koshy <Ajish.Koshy@microchip.com>

Status in newer kernel trees:
6.15.y | Present (exact SHA1)
6.12.y | Present (exact SHA1)
6.6.y | Present (exact SHA1)
6.1.y | Present (exact SHA1)
5.15.y | Present (different SHA1: 269a4311b15f)

Note: The patch differs from the upstream commit:
---
1:  51e6ed83bb4a ! 1:  1652f92390bb scsi: pm80xx: Fix memory leak during rmmod
    @@ Metadata
      ## Commit message ##
         scsi: pm80xx: Fix memory leak during rmmod
     
    +    [ Upstream commit 51e6ed83bb4ade7c360551fa4ae55c4eacea354b ]
    +
         Driver failed to release all memory allocated. This would lead to memory
         leak during driver removal.
     
    @@ Commit message
         Signed-off-by: Ajish Koshy <Ajish.Koshy@microchip.com>
         Signed-off-by: Viswas G <Viswas.G@microchip.com>
         Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    +    Signed-off-by: Sasha Levin <sashal@kernel.org>
    +    [Shivani: Modified to apply on 5.10.y]
    +    Signed-off-by: Shivani Agarwal <shivani.agarwal@broadcom.com>
     
      ## drivers/scsi/pm8001/pm8001_init.c ##
     @@ drivers/scsi/pm8001/pm8001_init.c: pm8001_init_ccb_tag(struct pm8001_hba_info *pm8001_ha, struct Scsi_Host *shost,
    @@ drivers/scsi/pm8001/pm8001_init.c: pm8001_init_ccb_tag(struct pm8001_hba_info *p
      
      	/* Memory region for ccb_info*/
     +	pm8001_ha->ccb_count = ccb_count;
    - 	pm8001_ha->ccb_info =
    + 	pm8001_ha->ccb_info = (struct pm8001_ccb_info *)
      		kcalloc(ccb_count, sizeof(struct pm8001_ccb_info), GFP_KERNEL);
      	if (!pm8001_ha->ccb_info) {
     @@ drivers/scsi/pm8001/pm8001_init.c: static void pm8001_pci_remove(struct pci_dev *pdev)

---

Results of testing on various branches:

| Branch                    | Patch Apply | Build Test |
|---------------------------|-------------|------------|
| origin/linux-5.10.y       | Success     | Success    |

      parent reply	other threads:[~2025-08-11 22:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-11  5:20 [PATCH v5.10] scsi: pm80xx: Fix memory leak during rmmod Shivani Agarwal
2025-08-11  8:00 ` Markus Elfring
2025-08-11 10:36   ` Shivani Agarwal
2025-08-11 10:50     ` Markus Elfring
2025-08-11 11:20       ` Greg Kroah-Hartman
2025-08-11 22:30 ` Sasha Levin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1754925250-783d021d@stable.kernel.org \
    --to=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.