From: Markus Elfring <Markus.Elfring@web.de>
To: Shivani Agarwal <shivani.agarwal@broadcom.com>,
Sasha Levin <sashal@kernel.org>,
Viswas G <Viswas.G@microchip.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Ajish Koshy <Ajish.Koshy@microchip.com>,
Jack Wang <jinpu.wang@ionos.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-scsi@vger.kernel.org
Cc: bcm-kernel-feedback-list@broadcom.com, stable@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Ajay Kaher <ajay.kaher@broadcom.com>,
Alexey Makhalov <alexey.makhalov@broadcom.com>,
Jack Wang <jinpu.wang@cloud.ionos.com>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
Tapas Kundu <tapas.kundu@broadcom.com>
Subject: Re: [PATCH v5.10] scsi: pm80xx: Fix memory leak during rmmod
Date: Mon, 11 Aug 2025 10:00:40 +0200 [thread overview]
Message-ID: <7c7aedbf-389d-4e5a-83d0-33c51cda1d8a@web.de> (raw)
In-Reply-To: <20250811052035.145021-1-shivani.agarwal@broadcom.com>
…
> +++ b/drivers/scsi/pm8001/pm8001_init.c
…
> @@ -1226,6 +1227,16 @@ static void pm8001_pci_remove(struct pci_dev *pdev)
> tasklet_kill(&pm8001_ha->tasklet[j]);
> #endif
> scsi_host_put(pm8001_ha->shost);
> +
> + for (i = 0; i < pm8001_ha->ccb_count; i++) {
> + dma_free_coherent(&pm8001_ha->pdev->dev,
> + sizeof(struct pm8001_prd) * PM8001_MAX_DMA_SG,
> + pm8001_ha->ccb_info[i].buf_prd,
> + pm8001_ha->ccb_info[i].ccb_dma_handle);
> + }
May curly brackets be omitted here?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.16#n197
Regards,
Markus
next prev parent reply other threads:[~2025-08-11 8:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-11 5:20 [PATCH v5.10] scsi: pm80xx: Fix memory leak during rmmod Shivani Agarwal
2025-08-11 8:00 ` Markus Elfring [this message]
2025-08-11 10:36 ` Shivani Agarwal
2025-08-11 10:50 ` Markus Elfring
2025-08-11 11:20 ` Greg Kroah-Hartman
2025-08-11 22:30 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c7aedbf-389d-4e5a-83d0-33c51cda1d8a@web.de \
--to=markus.elfring@web.de \
--cc=Ajish.Koshy@microchip.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=Viswas.G@microchip.com \
--cc=ajay.kaher@broadcom.com \
--cc=alexey.makhalov@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=jinpu.wang@cloud.ionos.com \
--cc=jinpu.wang@ionos.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sashal@kernel.org \
--cc=shivani.agarwal@broadcom.com \
--cc=stable@vger.kernel.org \
--cc=tapas.kundu@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.