From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Shivani Agarwal <shivani.agarwal@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
linux-scsi@vger.kernel.org, Sasha Levin <sashal@kernel.org>,
Viswas G <Viswas.G@microchip.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Ajish Koshy <Ajish.Koshy@microchip.com>,
Jack Wang <jinpu.wang@ionos.com>,
stable@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Ajay Kaher <ajay.kaher@broadcom.com>,
Alexey Makhalov <alexey.makhalov@broadcom.com>,
Jack Wang <jinpu.wang@cloud.ionos.com>,
James Bottomley <James.Bottomley@hansenpartnership.com>,
Tapas Kundu <tapas.kundu@broadcom.com>
Subject: Re: [PATCH v5.10] scsi: pm80xx: Fix memory leak during rmmod
Date: Mon, 11 Aug 2025 13:20:47 +0200 [thread overview]
Message-ID: <2025081141-voltage-tribesman-350d@gregkh> (raw)
In-Reply-To: <7010c6e0-009c-49d7-9621-b20ff5122602@web.de>
On Mon, Aug 11, 2025 at 12:50:24PM +0200, Markus Elfring wrote:
> >> May curly brackets be omitted here?
> >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.16#n197
> >
> > Thanks, Markus. I agree with you and have no objection. However, for
> > the stable branches, we usually keep the patches unchanged.
>
> I am unsure how many source code adjustments would be supported
> also according to coding style concerns.
>
>
> > I think it would be good to remove these curly braces in the Linux
> > master branch as well. Should I go ahead and submit a patch for the
> > master branch too?
>
> Corresponding refinements would be nice.
> https://elixir.bootlin.com/linux/v6.16/source/drivers/scsi/pm8001/pm8001_init.c#L1311-L1316
Hi,
This is the semi-friendly patch-bot of Greg Kroah-Hartman.
Markus, you seem to have sent a nonsensical or otherwise pointless
review comment to a patch submission on a Linux kernel developer mailing
list. I strongly suggest that you not do this anymore. Please do not
bother developers who are actively working to produce patches and
features with comments that, in the end, are a waste of time.
Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all. The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback. Please feel free to also ignore emails
from them.
thanks,
greg k-h's patch email bot
next prev parent reply other threads:[~2025-08-11 11:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-11 5:20 [PATCH v5.10] scsi: pm80xx: Fix memory leak during rmmod Shivani Agarwal
2025-08-11 8:00 ` Markus Elfring
2025-08-11 10:36 ` Shivani Agarwal
2025-08-11 10:50 ` Markus Elfring
2025-08-11 11:20 ` Greg Kroah-Hartman [this message]
2025-08-11 22:30 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025081141-voltage-tribesman-350d@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=Ajish.Koshy@microchip.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=Markus.Elfring@web.de \
--cc=Viswas.G@microchip.com \
--cc=ajay.kaher@broadcom.com \
--cc=alexey.makhalov@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=jinpu.wang@cloud.ionos.com \
--cc=jinpu.wang@ionos.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sashal@kernel.org \
--cc=shivani.agarwal@broadcom.com \
--cc=stable@vger.kernel.org \
--cc=tapas.kundu@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.