From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [Urgent PATCH] arm64: dts: uniphier: fix IRQ trigger type of ARMv8 timer
Date: Wed, 10 Aug 2016 22:52:13 +0200 [thread overview]
Message-ID: <1769666.3m3onKVFl3@wuerfel> (raw)
In-Reply-To: <1470039140-3801-1-git-send-email-yamada.masahiro@socionext.com>
On Monday, August 1, 2016 5:12:20 PM CEST Masahiro Yamada wrote:
> Since commit 1e2a7d78499e ("irqdomain: Don't set type when mapping
> an IRQ"), the interrupt type is strictly checked. Without this
> patch, this board would not boot any more.
>
> Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt
> says that the 3rd cell should be either 1 (edge) or 4 (level)
> depending on the trigger type. As the CA72 Generic Timer provides
> active-low interrupts, the value of the 3rd cell should be 4.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> Suggested-by: Marc Zyngier <marc.zyngier@arm.com>
>
I've added it to the fixes branch now, sorry for the delay.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: Masahiro Yamada
<yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>
Cc: arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Catalin Marinas <catalin.marinas-5wv7dgnIgG8@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [Urgent PATCH] arm64: dts: uniphier: fix IRQ trigger type of ARMv8 timer
Date: Wed, 10 Aug 2016 22:52:13 +0200 [thread overview]
Message-ID: <1769666.3m3onKVFl3@wuerfel> (raw)
In-Reply-To: <1470039140-3801-1-git-send-email-yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>
On Monday, August 1, 2016 5:12:20 PM CEST Masahiro Yamada wrote:
> Since commit 1e2a7d78499e ("irqdomain: Don't set type when mapping
> an IRQ"), the interrupt type is strictly checked. Without this
> patch, this board would not boot any more.
>
> Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt
> says that the 3rd cell should be either 1 (edge) or 4 (level)
> depending on the trigger type. As the CA72 Generic Timer provides
> active-low interrupts, the value of the 3rd cell should be 4.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>
> Suggested-by: Marc Zyngier <marc.zyngier-5wv7dgnIgG8@public.gmane.org>
>
I've added it to the fixes branch now, sorry for the delay.
Arnd
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: arm@kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Will Deacon <will.deacon@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [Urgent PATCH] arm64: dts: uniphier: fix IRQ trigger type of ARMv8 timer
Date: Wed, 10 Aug 2016 22:52:13 +0200 [thread overview]
Message-ID: <1769666.3m3onKVFl3@wuerfel> (raw)
In-Reply-To: <1470039140-3801-1-git-send-email-yamada.masahiro@socionext.com>
On Monday, August 1, 2016 5:12:20 PM CEST Masahiro Yamada wrote:
> Since commit 1e2a7d78499e ("irqdomain: Don't set type when mapping
> an IRQ"), the interrupt type is strictly checked. Without this
> patch, this board would not boot any more.
>
> Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt
> says that the 3rd cell should be either 1 (edge) or 4 (level)
> depending on the trigger type. As the CA72 Generic Timer provides
> active-low interrupts, the value of the 3rd cell should be 4.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> Suggested-by: Marc Zyngier <marc.zyngier@arm.com>
>
I've added it to the fixes branch now, sorry for the delay.
Arnd
next prev parent reply other threads:[~2016-08-10 20:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-01 8:12 [Urgent PATCH] arm64: dts: uniphier: fix IRQ trigger type of ARMv8 timer Masahiro Yamada
2016-08-01 8:12 ` Masahiro Yamada
2016-08-01 8:12 ` Masahiro Yamada
2016-08-01 8:18 ` Marc Zyngier
2016-08-01 8:18 ` Marc Zyngier
2016-08-01 8:26 ` Masahiro Yamada
2016-08-01 8:26 ` Masahiro Yamada
2016-08-01 8:26 ` Masahiro Yamada
2016-08-11 2:25 ` Masahiro Yamada
2016-08-11 2:25 ` Masahiro Yamada
2016-08-11 6:44 ` Arnd Bergmann
2016-08-11 6:44 ` Arnd Bergmann
2016-08-11 6:44 ` Arnd Bergmann
2016-08-10 20:52 ` Arnd Bergmann [this message]
2016-08-10 20:52 ` Arnd Bergmann
2016-08-10 20:52 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1769666.3m3onKVFl3@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.