From: marc.zyngier@arm.com (Marc Zyngier)
To: linux-arm-kernel@lists.infradead.org
Subject: [Urgent PATCH] arm64: dts: uniphier: fix IRQ trigger type of ARMv8 timer
Date: Mon, 1 Aug 2016 09:18:41 +0100 [thread overview]
Message-ID: <579F05E1.9020300@arm.com> (raw)
In-Reply-To: <1470039140-3801-1-git-send-email-yamada.masahiro@socionext.com>
Please keep me cc-ed on this.
On 01/08/16 09:12, Masahiro Yamada wrote:
> Since commit 1e2a7d78499e ("irqdomain: Don't set type when mapping
> an IRQ"), the interrupt type is strictly checked. Without this
> patch, this board would not boot any more.
>
> Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt
> says that the 3rd cell should be either 1 (edge) or 4 (level)
> depending on the trigger type. As the CA72 Generic Timer provides
> active-low interrupts, the value of the 3rd cell should be 4.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> Suggested-by: Marc Zyngier <marc.zyngier@arm.com>
> ---
> Arnd, Olof,
>
> I guess you are about to send pull-reqs for v4.8 cycle.
> Could you include this one in them?
> After IRQ updates for 4.8 were merged, my board would not
> boot at all. I consulted experts and looks like my DT
> was wrong.
>
> I could do this after -rc1 is out because it is apparently a
> bug fix, but in that case the for-next branch in ASOC will be
> broken for me, which would make bisect-ability difficult for me.
I have a patch that addresses all platforms in one go (there is really
no point in fixing one at a time for a bug that is so widespread).
I'll repost it later today.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <marc.zyngier@arm.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>, arm@kernel.org
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [Urgent PATCH] arm64: dts: uniphier: fix IRQ trigger type of ARMv8 timer
Date: Mon, 1 Aug 2016 09:18:41 +0100 [thread overview]
Message-ID: <579F05E1.9020300@arm.com> (raw)
In-Reply-To: <1470039140-3801-1-git-send-email-yamada.masahiro@socionext.com>
Please keep me cc-ed on this.
On 01/08/16 09:12, Masahiro Yamada wrote:
> Since commit 1e2a7d78499e ("irqdomain: Don't set type when mapping
> an IRQ"), the interrupt type is strictly checked. Without this
> patch, this board would not boot any more.
>
> Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt
> says that the 3rd cell should be either 1 (edge) or 4 (level)
> depending on the trigger type. As the CA72 Generic Timer provides
> active-low interrupts, the value of the 3rd cell should be 4.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> Suggested-by: Marc Zyngier <marc.zyngier@arm.com>
> ---
> Arnd, Olof,
>
> I guess you are about to send pull-reqs for v4.8 cycle.
> Could you include this one in them?
> After IRQ updates for 4.8 were merged, my board would not
> boot at all. I consulted experts and looks like my DT
> was wrong.
>
> I could do this after -rc1 is out because it is apparently a
> bug fix, but in that case the for-next branch in ASOC will be
> broken for me, which would make bisect-ability difficult for me.
I have a patch that addresses all platforms in one go (there is really
no point in fixing one at a time for a bug that is so widespread).
I'll repost it later today.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2016-08-01 8:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-01 8:12 [Urgent PATCH] arm64: dts: uniphier: fix IRQ trigger type of ARMv8 timer Masahiro Yamada
2016-08-01 8:12 ` Masahiro Yamada
2016-08-01 8:12 ` Masahiro Yamada
2016-08-01 8:18 ` Marc Zyngier [this message]
2016-08-01 8:18 ` Marc Zyngier
2016-08-01 8:26 ` Masahiro Yamada
2016-08-01 8:26 ` Masahiro Yamada
2016-08-01 8:26 ` Masahiro Yamada
2016-08-11 2:25 ` Masahiro Yamada
2016-08-11 2:25 ` Masahiro Yamada
2016-08-11 6:44 ` Arnd Bergmann
2016-08-11 6:44 ` Arnd Bergmann
2016-08-11 6:44 ` Arnd Bergmann
2016-08-10 20:52 ` Arnd Bergmann
2016-08-10 20:52 ` Arnd Bergmann
2016-08-10 20:52 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=579F05E1.9020300@arm.com \
--to=marc.zyngier@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.