Re: Finding Clean-up Tasks

["Fabio M. De Francesco" <fmdefrancesco@gmail.com>]

On venerd? 1 aprile 2022 16:28:03 CEST Jaehee Park wrote:
> On Thu, Mar 31, 2022 at 11:38:05AM -0700, Alison Schofield wrote: 
> > Confidence to send the patch:
> > -----------------------------
> > Go ahead and search on this mailing list for the checkpatch
> > string. You should find many examples that match what you
> > are about to do. See what worked well, what needed rework.
> > 
> > If you have a patch AND a question, you can send the patch
> > and put your question below the scissors line. For example,
> > you might see multiple instances of something but are not sure
> > the patch will be well-received. Fix one instance - and below
> > the scissor line ask you question: "There are 10 more of these
> > in this file, just want to sanity check that my approach here
> > is wanted."  (If I were doing cleanup today, I'd use this tactic
> > for drivers/staging/iio checkpatch ERROR about octals.)
> > 
> 
> Thank you for advice! I had a question about where to put the questions
> in the patch. When you say scissor line, are we putting dashed lined
> somewhere in the patch and writing our questions? Or did you mean we
> should reply to our patch?
> 
Hi Jaehee,

Alison is talking about the three dashes that patches have soon after 
the line with the "Signed-off-by:" tag.

Look at your own patch as an example:

"Change variable name to be consistent with the naming conventions.
ssidlen was changed to ssid_len and ssidie was changed to ssid_ie to be
consistent. This makes the variables more readable. The other ssid
names in the code are separated by an underscore. For example,
bssid_filter and num_of_ssids have the ssid separated from the rest of
the words with an underscore.

Signed-off-by: Jaehee Park <jhpark1013@gmail.com>
--- 

-> Place your questions and revision history here <-

drivers/staging/wfx/hif_tx.c | 10 +++++-----
 drivers/staging/wfx/sta.c    | 20 ++++++++++----------
 2 files changed, 15 insertions(+), 15 deletions(-)"

Regards,

Fabio M. De Francesco