Re: Finding Clean-up Tasks

[Alison Schofield <alison.schofield@intel.com>]

On Fri, Apr 01, 2022 at 10:28:03AM -0400, Jaehee Park wrote:
> On Thu, Mar 31, 2022 at 11:38:05AM -0700, Alison Schofield wrote:

snip

> > Confidence to send the patch:
> > -----------------------------
> > Go ahead and search on this mailing list for the checkpatch
> > string. You should find many examples that match what you
> > are about to do. See what worked well, what needed rework.
> > 
> > If you have a patch AND a question, you can send the patch
> > and put your question below the scissors line. For example,
> > you might see multiple instances of something but are not sure
> > the patch will be well-received. Fix one instance - and below
> > the scissor line ask you question: "There are 10 more of these
> > in this file, just want to sanity check that my approach here
> > is wanted."  (If I were doing cleanup today, I'd use this tactic
> > for drivers/staging/iio checkpatch ERROR about octals.)
> > 
> 
> Thank you for advice! I had a question about where to put the questions
> in the patch. When you say scissor line, are we putting dashed lined
> somewhere in the patch and writing our questions? Or did you mean we
> should reply to our patch?   
> 
Below the 'scissor line' is the same place you would place a Changelog
when versioning the patch. Anything below the "---" and before the
diffstat gets automagically tossed when the patch is applied.
So, it looks something like this:

>> bssid_filter and num_of_ssids have the ssid separated from the rest of
>> the words with an underscore.
>> 
>> Signed-off-by: Jaehee Park <jhpark1013@gmail.com>
>> ---

Insert question, additional comment here. 
In the future, you'll learn about RFC patches, where we are sometimes
asking for a greater conceptual review before posting. But, for small
questions about a specific patch - this space works well.

>>  drivers/staging/wfx/hif_tx.c | 10 +++++-----
>>  drivers/staging/wfx/sta.c    | 20 ++++++++++----------
>>  2 files changed, 15 insertions(+), 15 deletions(-)

Alison