Re: Finding Clean-up Tasks

[Stefano Brivio <sbrivio@redhat.com>]

On Fri, 1 Apr 2022 10:28:03 -0400
Jaehee Park <jhpark1013@gmail.com> wrote:

> On Thu, Mar 31, 2022 at 11:38:05AM -0700, Alison Schofield wrote:
>
> [...]
>
> > If you have a patch AND a question, you can send the patch
> > and put your question below the scissors line. For example,
> > you might see multiple instances of something but are not sure
> > the patch will be well-received. Fix one instance - and below
> > the scissor line ask you question: "There are 10 more of these
> > in this file, just want to sanity check that my approach here
> > is wanted."  (If I were doing cleanup today, I'd use this tactic
> > for drivers/staging/iio checkpatch ERROR about octals.)
> >   
> 
> Thank you for advice! I had a question about where to put the questions
> in the patch. When you say scissor line, are we putting dashed lined
> somewhere in the patch and writing our questions?

Let's say this is the original patch as prepared by git format-patch:

--
This is a commit message.

Signed-off-by: you
---
 file.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/file.c
index 148b06a..ceb10a6 100644
--- a/file.c
+++ b/file.c
@@ -927,7 +927,6 @@ int function(void)
 
-
 
--

you can put your question (or any kind of comment, really) there:

--
This is a commit message.

Signed-off-by: you
---
I'm not sure this patch does anything. Should it do something?

 file.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/file.c
index 148b06a..ceb10a6 100644
--- a/file.c
+++ b/file.c
@@ -927,7 +927,6 @@ int function(void)
 
-
 
--

Those three dashes are also commonly called Signed-off-by-line, or
SoB-line (the term might refer to the line above, to the dashes, to the
line below, depending on whom you're speaking to :)).

> Or did you mean we should reply to our patch?   

You can also do that. If you're really unsure, you can also add [RFC]
to the subject, before [PATCH], to make it clear you're asking for
comments rather than actually submitting a change, and then write your
questions, concerns or considerations directly in the commit message.

-- 
Stefano