From: Heiko Stuebner <heiko@sntech.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
linux-rockchip@lists.infradead.org,
Chris Zhong <zyw@rock-chips.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [patch] drm: rockchip: signedness bug in dw_mipi_dsi_get_lane_bps()
Date: Wed, 20 Jan 2016 23:14:25 +0000 [thread overview]
Message-ID: <181674264.ynnWZU1Yz8@phil> (raw)
In-Reply-To: <20160120095352.GA19898@mwanda>
Hi Dan,
Am Mittwoch, 20. Januar 2016, 12:53:52 schrieb Dan Carpenter:
> "bpp" needs to be signed for the error handling to work.
>
> Fixes: 84e05408fcfe ('drm: rockchip: Support Synopsys DW MIPI DSI')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
There's also "drm/rockchip/dsi: fix handling mipi_dsi_pixel_format_to_bpp
result" from Andrzej Hajda from january the 14th doing the same change.
Heiko
>
> diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c
> b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c index 7bfe243..c35e5af 100644
> --- a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c
> +++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c
> @@ -461,7 +461,8 @@ static int dw_mipi_dsi_phy_init(struct dw_mipi_dsi
> *dsi)
>
> static int dw_mipi_dsi_get_lane_bps(struct dw_mipi_dsi *dsi)
> {
> - unsigned int bpp, i, pre;
> + int bpp;
> + unsigned int i, pre;
> unsigned long mpclk, pllref, tmp;
> unsigned int m = 1, n = 1, target_mbps = 1000;
> unsigned int max_mbps = dptdin_map[ARRAY_SIZE(dptdin_map) -
1].max_mbps;
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
linux-rockchip@lists.infradead.org,
Chris Zhong <zyw@rock-chips.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [patch] drm: rockchip: signedness bug in dw_mipi_dsi_get_lane_bps()
Date: Thu, 21 Jan 2016 00:14:25 +0100 [thread overview]
Message-ID: <181674264.ynnWZU1Yz8@phil> (raw)
In-Reply-To: <20160120095352.GA19898@mwanda>
Hi Dan,
Am Mittwoch, 20. Januar 2016, 12:53:52 schrieb Dan Carpenter:
> "bpp" needs to be signed for the error handling to work.
>
> Fixes: 84e05408fcfe ('drm: rockchip: Support Synopsys DW MIPI DSI')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
There's also "drm/rockchip/dsi: fix handling mipi_dsi_pixel_format_to_bpp
result" from Andrzej Hajda from january the 14th doing the same change.
Heiko
>
> diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c
> b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c index 7bfe243..c35e5af 100644
> --- a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c
> +++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c
> @@ -461,7 +461,8 @@ static int dw_mipi_dsi_phy_init(struct dw_mipi_dsi
> *dsi)
>
> static int dw_mipi_dsi_get_lane_bps(struct dw_mipi_dsi *dsi)
> {
> - unsigned int bpp, i, pre;
> + int bpp;
> + unsigned int i, pre;
> unsigned long mpclk, pllref, tmp;
> unsigned int m = 1, n = 1, target_mbps = 1000;
> unsigned int max_mbps = dptdin_map[ARRAY_SIZE(dptdin_map) -
1].max_mbps;
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stuebner)
To: linux-arm-kernel@lists.infradead.org
Subject: [patch] drm: rockchip: signedness bug in dw_mipi_dsi_get_lane_bps()
Date: Thu, 21 Jan 2016 00:14:25 +0100 [thread overview]
Message-ID: <181674264.ynnWZU1Yz8@phil> (raw)
In-Reply-To: <20160120095352.GA19898@mwanda>
Hi Dan,
Am Mittwoch, 20. Januar 2016, 12:53:52 schrieb Dan Carpenter:
> "bpp" needs to be signed for the error handling to work.
>
> Fixes: 84e05408fcfe ('drm: rockchip: Support Synopsys DW MIPI DSI')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
There's also "drm/rockchip/dsi: fix handling mipi_dsi_pixel_format_to_bpp
result" from Andrzej Hajda from january the 14th doing the same change.
Heiko
>
> diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c
> b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c index 7bfe243..c35e5af 100644
> --- a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c
> +++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c
> @@ -461,7 +461,8 @@ static int dw_mipi_dsi_phy_init(struct dw_mipi_dsi
> *dsi)
>
> static int dw_mipi_dsi_get_lane_bps(struct dw_mipi_dsi *dsi)
> {
> - unsigned int bpp, i, pre;
> + int bpp;
> + unsigned int i, pre;
> unsigned long mpclk, pllref, tmp;
> unsigned int m = 1, n = 1, target_mbps = 1000;
> unsigned int max_mbps = dptdin_map[ARRAY_SIZE(dptdin_map) -
1].max_mbps;
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Mark Yao <mark.yao@rock-chips.com>,
Chris Zhong <zyw@rock-chips.com>, David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] drm: rockchip: signedness bug in dw_mipi_dsi_get_lane_bps()
Date: Thu, 21 Jan 2016 00:14:25 +0100 [thread overview]
Message-ID: <181674264.ynnWZU1Yz8@phil> (raw)
In-Reply-To: <20160120095352.GA19898@mwanda>
Hi Dan,
Am Mittwoch, 20. Januar 2016, 12:53:52 schrieb Dan Carpenter:
> "bpp" needs to be signed for the error handling to work.
>
> Fixes: 84e05408fcfe ('drm: rockchip: Support Synopsys DW MIPI DSI')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
There's also "drm/rockchip/dsi: fix handling mipi_dsi_pixel_format_to_bpp
result" from Andrzej Hajda from january the 14th doing the same change.
Heiko
>
> diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c
> b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c index 7bfe243..c35e5af 100644
> --- a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c
> +++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c
> @@ -461,7 +461,8 @@ static int dw_mipi_dsi_phy_init(struct dw_mipi_dsi
> *dsi)
>
> static int dw_mipi_dsi_get_lane_bps(struct dw_mipi_dsi *dsi)
> {
> - unsigned int bpp, i, pre;
> + int bpp;
> + unsigned int i, pre;
> unsigned long mpclk, pllref, tmp;
> unsigned int m = 1, n = 1, target_mbps = 1000;
> unsigned int max_mbps = dptdin_map[ARRAY_SIZE(dptdin_map) -
1].max_mbps;
next prev parent reply other threads:[~2016-01-20 23:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 9:53 [patch] drm: rockchip: signedness bug in dw_mipi_dsi_get_lane_bps() Dan Carpenter
2016-01-20 9:53 ` Dan Carpenter
2016-01-20 9:53 ` Dan Carpenter
2016-01-20 9:53 ` Dan Carpenter
2016-01-20 23:14 ` Heiko Stuebner [this message]
2016-01-20 23:14 ` Heiko Stuebner
2016-01-20 23:14 ` Heiko Stuebner
2016-01-20 23:14 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=181674264.ynnWZU1Yz8@phil \
--to=heiko@sntech.de \
--cc=dan.carpenter@oracle.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.