From: Arnd Bergmann <arnd@arndb.de>
To: Doug Anderson <dianders@google.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Kukjin Kim <kgene.kim@samsung.com>,
Yuvaraj Kumar C D <yuvaraj.cd@samsung.com>,
"cpgs ." <cpgs@samsung.com>,
Yuvaraj Kumar C D <yuvaraj.cd@gmail.com>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Jaehoon Chung <jh80.chung@samsung.com>,
Chris Ball <cjb@laptop.org>,
Seung-Won Jeon <tgih.jun@samsung.com>,
linux-mmc <linux-mmc@vger.kernel.org>,
Sonny Rao <sonnyrao@chromium.org>,
Tomasz Figa <tomasz.figa@gmail.com>,
SUNIL JOSHI <joshi@samsung.com>,
PRASHANTH GODREHAL <prashanth.g@samsung.com>,
ALIM AKHTAR <alim.akhtar@samsung.com>,
Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
Abhilash Kesavan <a.kesavan@samsung.com>
Subject: Re: [PATCH] ARM: dts: fix MMC2 regulators for Exynos5420 Arndale Octa board
Date: Wed, 08 Oct 2014 20:28:31 +0200 [thread overview]
Message-ID: <1819182.VPTrtc9d2P@wuerfel> (raw)
In-Reply-To: <CAD=FV=VB_eK9pSmmTBRHoQmkORweHzT-OFaMWA6haFYnQuQaUQ@mail.gmail.com>
On Wednesday 08 October 2014 08:29:16 Doug Anderson wrote:
>
> On Wed, Oct 8, 2014 at 8:20 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> > Why does it cause a regression though? Does this mean you are breaking
> > any boot with an old DT file and a new kernel? That would be very
> > bad, the driver is supposed to keep working with an existing dtb.
>
> The old dts file specified completely the wrong regulator. It
> happened that the old code didn't really care, but when the code was
> fixed to care then things broke. If we need to keep old dts files
> working then the most sensible place to do it would be in a "fixup old
> broken device trees" stage somewhere in kernel boot.
Ok, got it. I guess it's better to apply this one first then.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: fix MMC2 regulators for Exynos5420 Arndale Octa board
Date: Wed, 08 Oct 2014 20:28:31 +0200 [thread overview]
Message-ID: <1819182.VPTrtc9d2P@wuerfel> (raw)
In-Reply-To: <CAD=FV=VB_eK9pSmmTBRHoQmkORweHzT-OFaMWA6haFYnQuQaUQ@mail.gmail.com>
On Wednesday 08 October 2014 08:29:16 Doug Anderson wrote:
>
> On Wed, Oct 8, 2014 at 8:20 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> > Why does it cause a regression though? Does this mean you are breaking
> > any boot with an old DT file and a new kernel? That would be very
> > bad, the driver is supposed to keep working with an existing dtb.
>
> The old dts file specified completely the wrong regulator. It
> happened that the old code didn't really care, but when the code was
> fixed to care then things broke. If we need to keep old dts files
> working then the most sensible place to do it would be in a "fixup old
> broken device trees" stage somewhere in kernel boot.
Ok, got it. I guess it's better to apply this one first then.
Arnd
next prev parent reply other threads:[~2014-10-08 18:29 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-02 16:10 [PATCH] ARM: dts: fix MMC2 regulators for Exynos5420 Arndale Octa board Bartlomiej Zolnierkiewicz
2014-10-02 16:10 ` Bartlomiej Zolnierkiewicz
2014-10-02 16:19 ` Doug Anderson
2014-10-02 16:19 ` Doug Anderson
2014-10-02 16:39 ` Bartlomiej Zolnierkiewicz
2014-10-02 16:39 ` Bartlomiej Zolnierkiewicz
2014-10-02 16:45 ` Doug Anderson
2014-10-02 16:45 ` Doug Anderson
2014-10-02 17:24 ` Bartlomiej Zolnierkiewicz
2014-10-02 17:24 ` Bartlomiej Zolnierkiewicz
2014-10-06 16:51 ` Doug Anderson
2014-10-06 16:51 ` Doug Anderson
2014-10-08 0:19 ` Jaehoon Chung
2014-10-08 0:19 ` Jaehoon Chung
2014-10-08 9:31 ` Ulf Hansson
2014-10-08 9:31 ` Ulf Hansson
2014-10-02 18:16 ` Ulf Hansson
2014-10-02 18:16 ` Ulf Hansson
2014-10-08 12:07 ` Arnd Bergmann
2014-10-08 12:07 ` Arnd Bergmann
2014-10-08 12:50 ` Ulf Hansson
2014-10-08 12:50 ` Ulf Hansson
2014-10-08 15:20 ` Arnd Bergmann
2014-10-08 15:20 ` Arnd Bergmann
2014-10-08 15:29 ` Doug Anderson
2014-10-08 15:29 ` Doug Anderson
2014-10-08 18:28 ` Arnd Bergmann [this message]
2014-10-08 18:28 ` Arnd Bergmann
2014-10-09 8:46 ` Ulf Hansson
2014-10-09 8:46 ` Ulf Hansson
2014-10-09 11:41 ` Arnd Bergmann
2014-10-09 11:41 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1819182.VPTrtc9d2P@wuerfel \
--to=arnd@arndb.de \
--cc=a.kesavan@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=cjb@laptop.org \
--cc=cpgs@samsung.com \
--cc=dianders@google.com \
--cc=javier.martinez@collabora.co.uk \
--cc=jh80.chung@samsung.com \
--cc=joshi@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=prashanth.g@samsung.com \
--cc=sonnyrao@chromium.org \
--cc=tgih.jun@samsung.com \
--cc=tomasz.figa@gmail.com \
--cc=ulf.hansson@linaro.org \
--cc=yuvaraj.cd@gmail.com \
--cc=yuvaraj.cd@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.