All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Doug Anderson <dianders@google.com>,
	Yuvaraj Kumar C D <yuvaraj.cd@samsung.com>,
	Ulf Hansson <ulf.hansson@linaro.org>, "cpgs ." <cpgs@samsung.com>,
	Yuvaraj Kumar C D <yuvaraj.cd@gmail.com>,
	linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Jaehoon Chung <jh80.chung@samsung.com>,
	Chris Ball <cjb@laptop.org>,
	Seung-Won Jeon <tgih.jun@samsung.com>,
	linux-mmc <linux-mmc@vger.kernel.org>,
	Sonny Rao <sonnyrao@chromium.org>,
	Tomasz Figa <tomasz.figa@gmail.com>,
	Kukjin Kim <kgene.kim@samsung.com>,
	SUNIL JOSHI <joshi@samsung.com>,
	PRASHANTH GODREHAL <prashanth.g@samsung.com>,
	ALIM AKHTAR <alim.akhtar@samsung.com>,
	Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
	Abhilash Kesavan <a.kesavan@samsung.com>
Subject: [PATCH] ARM: dts: fix MMC2 regulators for Exynos5420 Arndale Octa board
Date: Thu, 02 Oct 2014 18:10:06 +0200	[thread overview]
Message-ID: <2750153.I3nVqzmXTP@amdc1032> (raw)

Regulators for MMC2 (SD card) are PVDD_TFLASH_2V8 (LDO19) for vmmc
and PVDD_APIO_MMCOFF_2V8 (LDO13) for vqmmc.  Currently the device
tree entry for MMC2 uses PVDD_PRE_1V8 (LDO10) for vmmc and vqmmc is
not specified.  Fix it.

Without this patch:
- "mmc: dw_mmc: use mmc_regulator_get_supply to handle regulators"
  patch causes a SD card detection to fail
- "mmc: dw_mmc: Support voltage changes" patch causes a boot hang

This patch fixes both above problems.

Suggested-by: Doug Anderson <dianders@google.com>
Cc: Yuvaraj Kumar C D <yuvaraj.cd@samsung.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
---
 arch/arm/boot/dts/exynos5420-arndale-octa.dts |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Index: b/arch/arm/boot/dts/exynos5420-arndale-octa.dts
===================================================================
--- a/arch/arm/boot/dts/exynos5420-arndale-octa.dts	2014-10-02 15:44:53.014826886 +0200
+++ b/arch/arm/boot/dts/exynos5420-arndale-octa.dts	2014-10-02 17:35:24.110600398 +0200
@@ -74,7 +74,8 @@
 		samsung,dw-mshc-ddr-timing = <1 2>;
 		pinctrl-names = "default";
 		pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_cd &sd2_bus4>;
-		vmmc-supply = <&ldo10_reg>;
+		vmmc-supply = <&ldo19_reg>;
+		vqmmc-supply = <&ldo13_reg>;
 
 		slot@0 {
 			reg = <0>;

WARNING: multiple messages have this Message-ID (diff)
From: b.zolnierkie@samsung.com (Bartlomiej Zolnierkiewicz)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: fix MMC2 regulators for Exynos5420 Arndale Octa board
Date: Thu, 02 Oct 2014 18:10:06 +0200	[thread overview]
Message-ID: <2750153.I3nVqzmXTP@amdc1032> (raw)

Regulators for MMC2 (SD card) are PVDD_TFLASH_2V8 (LDO19) for vmmc
and PVDD_APIO_MMCOFF_2V8 (LDO13) for vqmmc.  Currently the device
tree entry for MMC2 uses PVDD_PRE_1V8 (LDO10) for vmmc and vqmmc is
not specified.  Fix it.

Without this patch:
- "mmc: dw_mmc: use mmc_regulator_get_supply to handle regulators"
  patch causes a SD card detection to fail
- "mmc: dw_mmc: Support voltage changes" patch causes a boot hang

This patch fixes both above problems.

Suggested-by: Doug Anderson <dianders@google.com>
Cc: Yuvaraj Kumar C D <yuvaraj.cd@samsung.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
---
 arch/arm/boot/dts/exynos5420-arndale-octa.dts |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Index: b/arch/arm/boot/dts/exynos5420-arndale-octa.dts
===================================================================
--- a/arch/arm/boot/dts/exynos5420-arndale-octa.dts	2014-10-02 15:44:53.014826886 +0200
+++ b/arch/arm/boot/dts/exynos5420-arndale-octa.dts	2014-10-02 17:35:24.110600398 +0200
@@ -74,7 +74,8 @@
 		samsung,dw-mshc-ddr-timing = <1 2>;
 		pinctrl-names = "default";
 		pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_cd &sd2_bus4>;
-		vmmc-supply = <&ldo10_reg>;
+		vmmc-supply = <&ldo19_reg>;
+		vqmmc-supply = <&ldo13_reg>;
 
 		slot at 0 {
 			reg = <0>;

             reply	other threads:[~2014-10-02 16:10 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-02 16:10 Bartlomiej Zolnierkiewicz [this message]
2014-10-02 16:10 ` [PATCH] ARM: dts: fix MMC2 regulators for Exynos5420 Arndale Octa board Bartlomiej Zolnierkiewicz
2014-10-02 16:19 ` Doug Anderson
2014-10-02 16:19   ` Doug Anderson
2014-10-02 16:39   ` Bartlomiej Zolnierkiewicz
2014-10-02 16:39     ` Bartlomiej Zolnierkiewicz
2014-10-02 16:45     ` Doug Anderson
2014-10-02 16:45       ` Doug Anderson
2014-10-02 17:24       ` Bartlomiej Zolnierkiewicz
2014-10-02 17:24         ` Bartlomiej Zolnierkiewicz
2014-10-06 16:51         ` Doug Anderson
2014-10-06 16:51           ` Doug Anderson
2014-10-08  0:19           ` Jaehoon Chung
2014-10-08  0:19             ` Jaehoon Chung
2014-10-08  9:31             ` Ulf Hansson
2014-10-08  9:31               ` Ulf Hansson
2014-10-02 18:16 ` Ulf Hansson
2014-10-02 18:16   ` Ulf Hansson
2014-10-08 12:07   ` Arnd Bergmann
2014-10-08 12:07     ` Arnd Bergmann
2014-10-08 12:50     ` Ulf Hansson
2014-10-08 12:50       ` Ulf Hansson
2014-10-08 15:20       ` Arnd Bergmann
2014-10-08 15:20         ` Arnd Bergmann
2014-10-08 15:29         ` Doug Anderson
2014-10-08 15:29           ` Doug Anderson
2014-10-08 18:28           ` Arnd Bergmann
2014-10-08 18:28             ` Arnd Bergmann
2014-10-09  8:46             ` Ulf Hansson
2014-10-09  8:46               ` Ulf Hansson
2014-10-09 11:41               ` Arnd Bergmann
2014-10-09 11:41                 ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2750153.I3nVqzmXTP@amdc1032 \
    --to=b.zolnierkie@samsung.com \
    --cc=a.kesavan@samsung.com \
    --cc=alim.akhtar@samsung.com \
    --cc=cjb@laptop.org \
    --cc=cpgs@samsung.com \
    --cc=dianders@google.com \
    --cc=javier.martinez@collabora.co.uk \
    --cc=jh80.chung@samsung.com \
    --cc=joshi@samsung.com \
    --cc=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=prashanth.g@samsung.com \
    --cc=sonnyrao@chromium.org \
    --cc=tgih.jun@samsung.com \
    --cc=tomasz.figa@gmail.com \
    --cc=ulf.hansson@linaro.org \
    --cc=yuvaraj.cd@gmail.com \
    --cc=yuvaraj.cd@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.