[PATCH 0/2] clear out Coverity issues 384444 & 451221

[PATCH 0/2] clear out Coverity issues 384444 & 451221

[Ariel Otilibili]

Hello,

This series clears out the Coverity issues 384444 & 451221.

Being one-liners, as advised by David Marchand, it is backported onto stable.

Thank you,

Link: https://inbox.dpdk.org/dev/CAJFAV8yEaWSX2kdiANWuKx7zsvTEnrVoVjnZAOQ_ocdzM8ZTAw@mail.gmail.com/

Ariel Otilibili (2):
  examples/flow_filtering: remove unused variable
  drivers/net/sfc: remove unused value

 drivers/net/sfc/sfc_repr.c                            | 2 --
 examples/flow_filtering/snippets/snippet_match_ipv4.c | 1 -
 2 files changed, 3 deletions(-)

-- 
2.47.1

[PATCH 1/2] examples/flow_filtering: remove unused variable

[Ariel Otilibili]

Coverity issue: 451221
Fixes: 16158f3490 ("examples/flow_filtering: introduce use cases snippets")
Cc: Ori Kam <orika@nvidia.com>
Cc: stable@dpdk.org
Signed-off-by: Ariel Otilibili <otilibil@eurecom.fr>
---
 examples/flow_filtering/snippets/snippet_match_ipv4.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/examples/flow_filtering/snippets/snippet_match_ipv4.c b/examples/flow_filtering/snippets/snippet_match_ipv4.c
index 808208e7b0..65fb045e8b 100644
--- a/examples/flow_filtering/snippets/snippet_match_ipv4.c
+++ b/examples/flow_filtering/snippets/snippet_match_ipv4.c
@@ -76,7 +76,6 @@ snippet_ipv4_flow_create_actions_template(uint16_t port_id, struct rte_flow_erro
 		.ingress = 1,
 	};
 
-	tactions[0].type = RTE_FLOW_ACTION_TYPE_QUEUE;
 	tactions[0].type = RTE_FLOW_ACTION_TYPE_END;
 
 	/* This sets the masks to match the actions, indicating that all fields of the actions
-- 
2.47.1

[PATCH 2/2] drivers/net/sfc: remove unused value

[Ariel Otilibili]

Coverity issue: 384444
Fixes: a62ec90522a ("net/sfc: add port representors infrastructure")
Cc: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: stable@dpdk.org
Signed-off-by: Ariel Otilibili <otilibil@eurecom.fr>
---
 drivers/net/sfc/sfc_repr.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/sfc/sfc_repr.c b/drivers/net/sfc/sfc_repr.c
index c2e5d4eb9e..a0712bf9fb 100644
--- a/drivers/net/sfc/sfc_repr.c
+++ b/drivers/net/sfc/sfc_repr.c
@@ -769,9 +769,7 @@ static void
 sfc_repr_close(struct sfc_repr *sr)
 {
 	SFC_ASSERT(sfc_repr_lock_is_locked(sr));
-
 	SFC_ASSERT(sr->state == SFC_ETHDEV_CONFIGURED);
-	sr->state = SFC_ETHDEV_CLOSING;
 
 	/* Put representor close actions here */
 
-- 
2.47.1

Re: [PATCH 2/2] drivers/net/sfc: remove unused value

[Stephen Hemminger]

On Fri, 13 Dec 2024 22:41:55 +0100
Ariel Otilibili <otilibil@eurecom.fr> wrote:

> Coverity issue: 384444
> Fixes: a62ec90522a ("net/sfc: add port representors infrastructure")
> Cc: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> Cc: stable@dpdk.org
> Signed-off-by: Ariel Otilibili <otilibil@eurecom.fr>
> ---

This gets checkpatch warning when I merged the SHA value is not correct.

### [PATCH] net/sfc: remove unused value

WARNING:BAD_FIXES_TAG: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' - ie: 'Fixes: a62ec90522a6 ("net/sfc: add port representors infrastructure")'

Bad
 Fixes: a62ec90522a ("net/sfc: add port representors infrastructure")
Good
 Fixes: a62ec90522a6 ("net/sfc: add port representors infrastructure")

Re: [PATCH 2/2] drivers/net/sfc: remove unused value

[Ariel Otilibili-Anieli]

Hello Stephen,

On Tuesday, January 14, 2025 19:47 CET, Stephen Hemminger <stephen@networkplumber.org> wrote:

> On Fri, 13 Dec 2024 22:41:55 +0100
> Ariel Otilibili <otilibil@eurecom.fr> wrote:
> 
> > Coverity issue: 384444
> > Fixes: a62ec90522a ("net/sfc: add port representors infrastructure")
> > Cc: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> > Cc: stable@dpdk.org
> > Signed-off-by: Ariel Otilibili <otilibil@eurecom.fr>
> > ---
> 
> This gets checkpatch warning when I merged the SHA value is not correct.
> 
> ### [PATCH] net/sfc: remove unused value
> 
> WARNING:BAD_FIXES_TAG: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' - ie: 'Fixes: a62ec90522a6 ("net/sfc: add port representors infrastructure")'
>

Thanks for the heads up; I'll set the correct length in my .gitconfig
> Bad
>  Fixes: a62ec90522a ("net/sfc: add port representors infrastructure")
> Good
>  Fixes: a62ec90522a6 ("net/sfc: add port representors infrastructure")
Have a good one,
Ariel

Re: [PATCH 2/2] drivers/net/sfc: remove unused value

[Stephen Hemminger]

On Tue, 14 Jan 2025 20:54:51 +0100
"Ariel Otilibili-Anieli" <otilibil@eurecom.fr> wrote:

> Hello Stephen,
> 
> On Tuesday, January 14, 2025 19:47 CET, Stephen Hemminger <stephen@networkplumber.org> wrote:
> 
> > On Fri, 13 Dec 2024 22:41:55 +0100
> > Ariel Otilibili <otilibil@eurecom.fr> wrote:
> >   
> > > Coverity issue: 384444
> > > Fixes: a62ec90522a ("net/sfc: add port representors infrastructure")
> > > Cc: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> > > Cc: stable@dpdk.org
> > > Signed-off-by: Ariel Otilibili <otilibil@eurecom.fr>
> > > ---  
> > 
> > This gets checkpatch warning when I merged the SHA value is not correct.
> > 
> > ### [PATCH] net/sfc: remove unused value
> > 
> > WARNING:BAD_FIXES_TAG: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' - ie: 'Fixes: a62ec90522a6 ("net/sfc: add port representors infrastructure")'
> >  
> 
> Thanks for the heads up; I'll set the correct length in my .gitconfig
> > Bad
> >  Fixes: a62ec90522a ("net/sfc: add port representors infrastructure")
> > Good
> >  Fixes: a62ec90522a6 ("net/sfc: add port representors infrastructure")  
> Have a good one,
> Ariel
> 

Also, please send a patch to add your address to the .mailmap file.
Right now, check-git-log.sh script is complaining.

Re: [PATCH 2/2] drivers/net/sfc: remove unused value

[Thomas Monjalon]

15/01/2025 00:34, Stephen Hemminger:
> Also, please send a patch to add your address to the .mailmap file.
> Right now, check-git-log.sh script is complaining.

In general we don't add mailmap entries as a separate commit.
You (author or tree maintainer) can add it in the first patch.

[PATCH v2 0/3] clear out Coverity issues 384444 & 451221

[Ariel Otilibili]

Hello,

This series clears out the Coverity issues 384444 & 451221.

Being one-liners, the series is backported onto stable.

Thank you,

Link: https://inbox.dpdk.org/dev/CAJFAV8yEaWSX2kdiANWuKx7zsvTEnrVoVjnZAOQ_ocdzM8ZTAw@mail.gmail.com/
---
v2
* fixed the SHAs given for Fixes
* added a .mailmap
* reworded the cover letter
v1 (https://inbox.dpdk.org/dev/20241213214951.61974-1-otilibil@eurecom.fr/)

Ariel Otilibili (3):
  examples/flow_filtering: remove unused variable
  drivers/net/sfc: remove unused value
  Update .mailmap

 .mailmap                                              | 1 +
 drivers/net/sfc/sfc_repr.c                            | 2 --
 examples/flow_filtering/snippets/snippet_match_ipv4.c | 1 -
 3 files changed, 1 insertion(+), 3 deletions(-)

-- 
2.30.2

[PATCH v2 1/3] examples/flow_filtering: remove unused variable

[Ariel Otilibili]

Coverity issue: 451221
Fixes: 16158f349000 ("examples/flow_filtering: introduce use cases snippets")
Signed-off-by: Ariel Otilibili <otilibil@eurecom.fr>
---
 examples/flow_filtering/snippets/snippet_match_ipv4.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/examples/flow_filtering/snippets/snippet_match_ipv4.c b/examples/flow_filtering/snippets/snippet_match_ipv4.c
index 808208e7b069..65fb045e8b1e 100644
--- a/examples/flow_filtering/snippets/snippet_match_ipv4.c
+++ b/examples/flow_filtering/snippets/snippet_match_ipv4.c
@@ -76,7 +76,6 @@ snippet_ipv4_flow_create_actions_template(uint16_t port_id, struct rte_flow_erro
 		.ingress = 1,
 	};
 
-	tactions[0].type = RTE_FLOW_ACTION_TYPE_QUEUE;
 	tactions[0].type = RTE_FLOW_ACTION_TYPE_END;
 
 	/* This sets the masks to match the actions, indicating that all fields of the actions
-- 
2.30.2

[PATCH v2 2/3] drivers/net/sfc: remove unused value

[Ariel Otilibili]

Coverity issue: 384444
Fixes: a62ec90522a6 ("net/sfc: add port representors infrastructure")
Signed-off-by: Ariel Otilibili <otilibil@eurecom.fr>
---
 drivers/net/sfc/sfc_repr.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/sfc/sfc_repr.c b/drivers/net/sfc/sfc_repr.c
index c2e5d4eb9e28..a0712bf9fb90 100644
--- a/drivers/net/sfc/sfc_repr.c
+++ b/drivers/net/sfc/sfc_repr.c
@@ -769,9 +769,7 @@ static void
 sfc_repr_close(struct sfc_repr *sr)
 {
 	SFC_ASSERT(sfc_repr_lock_is_locked(sr));
-
 	SFC_ASSERT(sr->state == SFC_ETHDEV_CONFIGURED);
-	sr->state = SFC_ETHDEV_CLOSING;
 
 	/* Put representor close actions here */
 
-- 
2.30.2

[PATCH v2 3/3] Update .mailmap

[Ariel Otilibili]

For fixing a warning from devtools/check-git-log.sh

Link: https://inbox.dpdk.org/dev/20250114153419.0a2753ab@hermes.local/
Signed-off-by: Ariel Otilibili <otilibil@eurecom.fr>
---
 .mailmap | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.mailmap b/.mailmap
index 818798273fe1..735a635fc7f9 100644
--- a/.mailmap
+++ b/.mailmap
@@ -134,6 +134,7 @@ Anupam Kapoor <anupam.kapoor@gmail.com>
 Apeksha Gupta <apeksha.gupta@nxp.com>
 Archana Muniganti <marchana@marvell.com> <muniganti.archana@caviumnetworks.com>
 Archit Pandey <architpandeynitk@gmail.com>
+Ariel Otilibili <ariel.otilibili@6wind.com> <otilibil@eurecom.fr>
 Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
 Arkadiusz Kusztal <arkadiuszx.kusztal@intel.com>
 Arnaud Fiorini <arnaud.fiorini@polymtl.ca>
-- 
2.30.2