* wip-claim-2
[not found] <1582070360.233.1418075135946.JavaMail.root@thunderbeast.private.linuxbox.com>
@ 2014-12-08 21:48 ` Matt W. Benjamin
2014-12-08 21:59 ` wip-claim-2 Sage Weil
0 siblings, 1 reply; 3+ messages in thread
From: Matt W. Benjamin @ 2014-12-08 21:48 UTC (permalink / raw)
To: ceph-devel; +Cc: Sage Weil
Hi devs,
We've created a new branch wip-claim-2, and new pull request https://github.com/linuxbox2/linuxbox-ceph/pull/3
based on review feedback.
The big change is to replace "volatile" with "sharable", and replace "strong_claim()" with "clone_nonsharable()."
This may not be perfect, feedback appreciated. It does remove the overloading of "claim()", which people found
confusing.
Thanks!
Matt
--
Matt Benjamin
CohortFS, LLC.
315 West Huron Street, Suite 140A
Ann Arbor, Michigan 48103
http://cohortfs.com
tel. 734-761-4689
fax. 734-769-8938
cel. 734-216-5309
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: wip-claim-2
2014-12-08 21:48 ` wip-claim-2 Matt W. Benjamin
@ 2014-12-08 21:59 ` Sage Weil
2014-12-09 16:49 ` wip-claim-3: wip-claim-2 Matt W. Benjamin
0 siblings, 1 reply; 3+ messages in thread
From: Sage Weil @ 2014-12-08 21:59 UTC (permalink / raw)
To: Matt W. Benjamin; +Cc: ceph-devel
On Mon, 8 Dec 2014, Matt W. Benjamin wrote:
> Hi devs,
>
> We've created a new branch wip-claim-2, and new pull request https://github.com/linuxbox2/linuxbox-ceph/pull/3
> based on review feedback.
>
> The big change is to replace "volatile" with "sharable", and replace "strong_claim()" with "clone_nonsharable()."
> This may not be perfect, feedback appreciated. It does remove the overloading of "claim()", which people found
> confusing.
I made a few comments, but overall it looks okay to me. Can you make the
next pull request against the github.com/ceph/ceph repo instead of your
clone?
https://github.com/ceph/ceph/compare
Thanks!
sage
^ permalink raw reply [flat|nested] 3+ messages in thread
* wip-claim-3: Re: wip-claim-2
2014-12-08 21:59 ` wip-claim-2 Sage Weil
@ 2014-12-09 16:49 ` Matt W. Benjamin
0 siblings, 0 replies; 3+ messages in thread
From: Matt W. Benjamin @ 2014-12-09 16:49 UTC (permalink / raw)
To: Sage Weil; +Cc: ceph-devel
Pushed wip-claim-3, which makes the changes you requested in IRC, plus adds a unittest block.
Matt
----- "Sage Weil" <sage@newdream.net> wrote:
> On Mon, 8 Dec 2014, Matt W. Benjamin wrote:
> > Hi devs,
> >
> > We've created a new branch wip-claim-2, and new pull request
> https://github.com/linuxbox2/linuxbox-ceph/pull/3
> > based on review feedback.
> >
> > The big change is to replace "volatile" with "sharable", and replace
> "strong_claim()" with "clone_nonsharable()."
> > This may not be perfect, feedback appreciated. It does remove the
> overloading of "claim()", which people found
> > confusing.
>
> I made a few comments, but overall it looks okay to me. Can you make
> the
> next pull request against the github.com/ceph/ceph repo instead of
> your
> clone?
>
> https://github.com/ceph/ceph/compare
>
> Thanks!
> sage
--
Matt Benjamin
CohortFS, LLC.
315 West Huron Street, Suite 140A
Ann Arbor, Michigan 48103
http://cohortfs.com
tel. 734-761-4689
fax. 734-769-8938
cel. 734-216-5309
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-12-09 16:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1582070360.233.1418075135946.JavaMail.root@thunderbeast.private.linuxbox.com>
2014-12-08 21:48 ` wip-claim-2 Matt W. Benjamin
2014-12-08 21:59 ` wip-claim-2 Sage Weil
2014-12-09 16:49 ` wip-claim-3: wip-claim-2 Matt W. Benjamin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.