All of lore.kernel.org
 help / color / mirror / Atom feed
From: Karthikeyan periyasamy <periyasa@codeaurora.org>
To: Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>
Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
	Miles Hu <milehu@codeaurora.org>, John Crispin <john@phrozen.org>,
	pradeepc=codeaurora.org@codeaurora.org
Subject: Re: [PATCH V8 1/3] ath11k: switch to using ieee80211_tx_status_ext()
Date: Fri, 19 Mar 2021 11:01:45 +0530	[thread overview]
Message-ID: <183cd636909cec0b8d20da8515c146ab@codeaurora.org> (raw)
In-Reply-To: <1616105397-1482-2-git-send-email-pradeepc@codeaurora.org>


> -	ieee80211_tx_status(ar->hw, msdu);
> +	spin_lock_bh(&ab->base_lock);
> +	peer = ath11k_peer_find_by_id(ab, ts->peer_id);
> +	if (peer) {
> +		arsta = (struct ath11k_sta *)peer->sta->drv_priv;
> +		status.sta = peer->sta;
> +		status.skb = msdu;
> +		status.info = info;
> +		status.rate = &arsta->last_txrate;

Assigning arsta holded last_txrate pointer to status.rate create race 
condition problem b/w sta delete and ieee80211_tx_status_ext, no ?
Hw we ensure that arsta pointer is valid until ieee80211_tx_status_ext() 
processing?

Instead why don't we have local struct rate_info and assign like below 
code snippet

         struct rate_info rate;
...
         rate = arsta->last_txrate;
         status.rate = &rate;

Thanks,
Karthikeyan P

-- 
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

WARNING: multiple messages have this Message-ID (diff)
From: Karthikeyan periyasamy <periyasa@codeaurora.org>
To: Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>
Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
	Miles Hu <milehu@codeaurora.org>, John Crispin <john@phrozen.org>,
	pradeepc=codeaurora.org@codeaurora.org
Subject: Re: [PATCH V8 1/3] ath11k: switch to using ieee80211_tx_status_ext()
Date: Fri, 19 Mar 2021 11:01:45 +0530	[thread overview]
Message-ID: <183cd636909cec0b8d20da8515c146ab@codeaurora.org> (raw)
In-Reply-To: <1616105397-1482-2-git-send-email-pradeepc@codeaurora.org>


> -	ieee80211_tx_status(ar->hw, msdu);
> +	spin_lock_bh(&ab->base_lock);
> +	peer = ath11k_peer_find_by_id(ab, ts->peer_id);
> +	if (peer) {
> +		arsta = (struct ath11k_sta *)peer->sta->drv_priv;
> +		status.sta = peer->sta;
> +		status.skb = msdu;
> +		status.info = info;
> +		status.rate = &arsta->last_txrate;

Assigning arsta holded last_txrate pointer to status.rate create race 
condition problem b/w sta delete and ieee80211_tx_status_ext, no ?
Hw we ensure that arsta pointer is valid until ieee80211_tx_status_ext() 
processing?

Instead why don't we have local struct rate_info and assign like below 
code snippet

         struct rate_info rate;
...
         rate = arsta->last_txrate;
         status.rate = &rate;

Thanks,
Karthikeyan P

  reply	other threads:[~2021-03-19  5:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-18 22:09 [PATCH V8 0/3] ath11k: add HE radiotap header support Pradeep Kumar Chitrapu
2021-03-18 22:09 ` Pradeep Kumar Chitrapu
2021-03-18 22:09 ` [PATCH V8 1/3] ath11k: switch to using ieee80211_tx_status_ext() Pradeep Kumar Chitrapu
2021-03-18 22:09   ` Pradeep Kumar Chitrapu
2021-03-19  5:31   ` Karthikeyan periyasamy [this message]
2021-03-19  5:31     ` Karthikeyan periyasamy
2021-04-04 12:56     ` Pradeep Kumar Chitrapu
2021-04-04 12:56       ` Pradeep Kumar Chitrapu
2021-03-18 22:09 ` [PATCH V8 2/3] ath11k: decode HE status tlv Pradeep Kumar Chitrapu
2021-03-18 22:09   ` Pradeep Kumar Chitrapu
2021-03-18 22:09 ` [PATCH V8 3/3] ath11k: translate HE status to radiotap format Pradeep Kumar Chitrapu
2021-03-18 22:09   ` Pradeep Kumar Chitrapu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=183cd636909cec0b8d20da8515c146ab@codeaurora.org \
    --to=periyasa@codeaurora.org \
    --cc=ath11k@lists.infradead.org \
    --cc=john@phrozen.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=milehu@codeaurora.org \
    --cc=pradeepc=codeaurora.org@codeaurora.org \
    --cc=pradeepc@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.