From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>,
intel-gfx@lists.freedesktop.org,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [Intel-gfx] [PATCH igt 0/8] Non-Intel test suite fixes
Date: Tue, 20 Mar 2018 13:32:17 +0200 [thread overview]
Message-ID: <1868096.KLcM8ItYGk@avalon> (raw)
In-Reply-To: <CAO3366wA2iUko95gJghTLptZ0HvS6iZzkSKp1NezyH3_kkoEAw@mail.gmail.com>
Hello,
On Monday, 19 March 2018 18:41:05 EET Ulrich Hecht wrote:
> On Fri, Mar 16, 2018 at 9:55 AM, Daniel Vetter <daniel@ffwll.ch> wrote:
> > On Thu, Mar 15, 2018 at 03:45:36PM +0100, Ulrich Hecht wrote:
> >> Hi!
> >>
> >> I have run the tests on a Renesas R-Car M3-W's DU device, and have found
> >> a number of false negatives that mostly stem from use of Intel-specifics
> >> without checking if that makes sense first. So here's a bunch of fixes
> >> for those, hope they are generic enough for upstreaming.
> >
> > Nice, other people using this! Do you plan to maintain this actively going
> > forward, or is this more a one-off effort?
>
> For now, this is just an attempt at evaluating if this works for us.
> It has caught a few things that look like legitimate bugs to me,
> though...
That's good news ! (Not that I'm happy that we have bugs, but catching them
shows that igt is useful for us). I hope this will help convincing management
that we should keep contributing to igt going forward.
Ulrich, for the record, I agree with all of Daniel's and Ville's comments
posted so far.
--
Regards,
Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
Cc: Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH igt 0/8] Non-Intel test suite fixes
Date: Tue, 20 Mar 2018 13:32:17 +0200 [thread overview]
Message-ID: <1868096.KLcM8ItYGk@avalon> (raw)
In-Reply-To: <CAO3366wA2iUko95gJghTLptZ0HvS6iZzkSKp1NezyH3_kkoEAw@mail.gmail.com>
Hello,
On Monday, 19 March 2018 18:41:05 EET Ulrich Hecht wrote:
> On Fri, Mar 16, 2018 at 9:55 AM, Daniel Vetter <daniel@ffwll.ch> wrote:
> > On Thu, Mar 15, 2018 at 03:45:36PM +0100, Ulrich Hecht wrote:
> >> Hi!
> >>
> >> I have run the tests on a Renesas R-Car M3-W's DU device, and have found
> >> a number of false negatives that mostly stem from use of Intel-specifics
> >> without checking if that makes sense first. So here's a bunch of fixes
> >> for those, hope they are generic enough for upstreaming.
> >
> > Nice, other people using this! Do you plan to maintain this actively going
> > forward, or is this more a one-off effort?
>
> For now, this is just an attempt at evaluating if this works for us.
> It has caught a few things that look like legitimate bugs to me,
> though...
That's good news ! (Not that I'm happy that we have bugs, but catching them
shows that igt is useful for us). I hope this will help convincing management
that we should keep contributing to igt going forward.
Ulrich, for the record, I agree with all of Daniel's and Ville's comments
posted so far.
--
Regards,
Laurent Pinchart
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-03-20 11:31 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-15 14:45 [PATCH igt 0/8] Non-Intel test suite fixes Ulrich Hecht
2018-03-15 14:45 ` Ulrich Hecht
2018-03-15 14:45 ` [PATCH igt 1/8] tests/kms_addfb_basic: skip i915-specific tests on other platforms Ulrich Hecht
2018-03-15 14:45 ` Ulrich Hecht
2018-03-16 8:51 ` [Intel-gfx] " Daniel Vetter
2018-03-16 8:51 ` Daniel Vetter
2018-03-20 11:24 ` Laurent Pinchart
2018-03-20 11:24 ` Laurent Pinchart
2018-03-15 14:45 ` [PATCH igt 2/8] tests/kms_panel_fitting: check for i915 before checking version Ulrich Hecht
2018-03-15 14:45 ` Ulrich Hecht
2018-03-16 8:51 ` [Intel-gfx] " Daniel Vetter
2018-03-16 8:51 ` Daniel Vetter
2018-03-20 11:24 ` Laurent Pinchart
2018-03-20 11:24 ` Laurent Pinchart
2018-03-21 8:34 ` [Intel-gfx] " Daniel Vetter
2018-03-21 8:34 ` Daniel Vetter
2018-03-21 8:52 ` [Intel-gfx] " Laurent Pinchart
2018-03-21 8:52 ` Laurent Pinchart
2018-03-27 6:41 ` [Intel-gfx] " Daniel Vetter
2018-03-27 6:41 ` Daniel Vetter
2018-03-15 14:45 ` [PATCH igt 3/8] lib/igt_gt: has_gpu_reset(): fix failed assertion on non-i915 platforms Ulrich Hecht
2018-03-15 14:45 ` Ulrich Hecht
2018-03-15 17:28 ` [Intel-gfx] " Ville Syrjälä
2018-03-15 17:28 ` Ville Syrjälä
2018-03-16 8:46 ` [Intel-gfx] " Daniel Vetter
2018-03-16 8:46 ` Daniel Vetter
2018-03-15 14:45 ` [PATCH igt 4/8] lib/igt_gt: check for presence of GPU reset before using it Ulrich Hecht
2018-03-15 14:45 ` Ulrich Hecht
2018-03-15 14:45 ` [PATCH igt 5/8] tests/kms_plane_lowres: skip i915-specific tests on other platforms Ulrich Hecht
2018-03-15 14:45 ` Ulrich Hecht
2018-03-15 17:33 ` [Intel-gfx] " Ville Syrjälä
2018-03-15 17:33 ` Ville Syrjälä
2018-03-15 14:45 ` [PATCH igt 6/8] lib/igt_pm: turn absence of autosuspend_delay_ms from fail to skip Ulrich Hecht
2018-03-15 14:45 ` Ulrich Hecht
2018-03-15 17:43 ` [Intel-gfx] " Ville Syrjälä
2018-03-15 17:43 ` Ville Syrjälä
2018-03-15 14:45 ` [PATCH igt 7/8] tests/kms_addfb_basic: size_tests(): reduce test buffer size Ulrich Hecht
2018-03-15 14:45 ` Ulrich Hecht
2018-03-16 8:53 ` [Intel-gfx] " Daniel Vetter
2018-03-16 8:53 ` Daniel Vetter
2018-03-15 14:45 ` [PATCH igt 8/8] test/kms_addfb_basic: tolerate absence of 8-bit format Ulrich Hecht
2018-03-15 14:45 ` Ulrich Hecht
2018-03-16 8:49 ` [Intel-gfx] " Daniel Vetter
2018-03-16 8:49 ` Daniel Vetter
2018-03-15 15:03 ` ✗ Fi.CI.BAT: failure for Non-Intel test suite fixes Patchwork
2018-03-16 8:55 ` [Intel-gfx] [PATCH igt 0/8] " Daniel Vetter
2018-03-16 8:55 ` Daniel Vetter
2018-03-19 16:41 ` [Intel-gfx] " Ulrich Hecht
2018-03-19 16:41 ` Ulrich Hecht
2018-03-20 11:32 ` Laurent Pinchart [this message]
2018-03-20 11:32 ` Laurent Pinchart
2018-03-21 8:37 ` [Intel-gfx] " Daniel Vetter
2018-03-21 8:37 ` Daniel Vetter
2018-04-27 16:03 ` Laurent Pinchart
2018-04-27 16:03 ` Laurent Pinchart
2018-05-08 16:03 ` Ulrich Hecht
2018-05-08 16:03 ` Ulrich Hecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1868096.KLcM8ItYGk@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=ulrich.hecht+renesas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.