All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
Cc: intel-gfx@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	laurent.pinchart@ideasonboard.com
Subject: Re: [Intel-gfx] [PATCH igt 6/8] lib/igt_pm: turn absence of autosuspend_delay_ms from fail to skip
Date: Thu, 15 Mar 2018 19:43:23 +0200	[thread overview]
Message-ID: <20180315174323.GY5453@intel.com> (raw)
In-Reply-To: <1521125144-28614-7-git-send-email-ulrich.hecht+renesas@gmail.com>

On Thu, Mar 15, 2018 at 03:45:42PM +0100, Ulrich Hecht wrote:
> Fixes false negatives on everything that doesn't happen to be at a
> specific hard-coded sysfs path...
> 
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
> ---
>  lib/igt_pm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/igt_pm.c b/lib/igt_pm.c
> index 5bf5b2e..641157b 100644
> --- a/lib/igt_pm.c
> +++ b/lib/igt_pm.c
> @@ -262,7 +262,7 @@ bool igt_setup_runtime_pm(void)
>  	 * suite goes faster and we have a higher probability of triggering race
>  	 * conditions. */
>  	fd = open(POWER_DIR "/autosuspend_delay_ms", O_WRONLY);

The hardocded path should probably go then.

igt_sysfs_path() + "/device/power" looks like it should dtrt.
Would need to plumb the fd down though. Hopefully every caller
has it handy.

> -	igt_assert_f(fd >= 0,
> +	igt_require_f(fd >= 0,
>  		     "Can't open " POWER_DIR "/autosuspend_delay_ms\n");
>  
>  	/* If we fail to write to the file, it means this system doesn't support
> -- 
> 2.7.4
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrj�l�
Intel OTC

WARNING: multiple messages have this Message-ID (diff)
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
Cc: linux-renesas-soc@vger.kernel.org,
	intel-gfx@lists.freedesktop.org,
	laurent.pinchart@ideasonboard.com
Subject: Re: [PATCH igt 6/8] lib/igt_pm: turn absence of autosuspend_delay_ms from fail to skip
Date: Thu, 15 Mar 2018 19:43:23 +0200	[thread overview]
Message-ID: <20180315174323.GY5453@intel.com> (raw)
In-Reply-To: <1521125144-28614-7-git-send-email-ulrich.hecht+renesas@gmail.com>

On Thu, Mar 15, 2018 at 03:45:42PM +0100, Ulrich Hecht wrote:
> Fixes false negatives on everything that doesn't happen to be at a
> specific hard-coded sysfs path...
> 
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
> ---
>  lib/igt_pm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/igt_pm.c b/lib/igt_pm.c
> index 5bf5b2e..641157b 100644
> --- a/lib/igt_pm.c
> +++ b/lib/igt_pm.c
> @@ -262,7 +262,7 @@ bool igt_setup_runtime_pm(void)
>  	 * suite goes faster and we have a higher probability of triggering race
>  	 * conditions. */
>  	fd = open(POWER_DIR "/autosuspend_delay_ms", O_WRONLY);

The hardocded path should probably go then.

igt_sysfs_path() + "/device/power" looks like it should dtrt.
Would need to plumb the fd down though. Hopefully every caller
has it handy.

> -	igt_assert_f(fd >= 0,
> +	igt_require_f(fd >= 0,
>  		     "Can't open " POWER_DIR "/autosuspend_delay_ms\n");
>  
>  	/* If we fail to write to the file, it means this system doesn't support
> -- 
> 2.7.4
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2018-03-15 17:43 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-15 14:45 [PATCH igt 0/8] Non-Intel test suite fixes Ulrich Hecht
2018-03-15 14:45 ` Ulrich Hecht
2018-03-15 14:45 ` [PATCH igt 1/8] tests/kms_addfb_basic: skip i915-specific tests on other platforms Ulrich Hecht
2018-03-15 14:45   ` Ulrich Hecht
2018-03-16  8:51   ` [Intel-gfx] " Daniel Vetter
2018-03-16  8:51     ` Daniel Vetter
2018-03-20 11:24   ` Laurent Pinchart
2018-03-20 11:24     ` Laurent Pinchart
2018-03-15 14:45 ` [PATCH igt 2/8] tests/kms_panel_fitting: check for i915 before checking version Ulrich Hecht
2018-03-15 14:45   ` Ulrich Hecht
2018-03-16  8:51   ` [Intel-gfx] " Daniel Vetter
2018-03-16  8:51     ` Daniel Vetter
2018-03-20 11:24   ` Laurent Pinchart
2018-03-20 11:24     ` Laurent Pinchart
2018-03-21  8:34     ` [Intel-gfx] " Daniel Vetter
2018-03-21  8:34       ` Daniel Vetter
2018-03-21  8:52       ` [Intel-gfx] " Laurent Pinchart
2018-03-21  8:52         ` Laurent Pinchart
2018-03-27  6:41         ` [Intel-gfx] " Daniel Vetter
2018-03-27  6:41           ` Daniel Vetter
2018-03-15 14:45 ` [PATCH igt 3/8] lib/igt_gt: has_gpu_reset(): fix failed assertion on non-i915 platforms Ulrich Hecht
2018-03-15 14:45   ` Ulrich Hecht
2018-03-15 17:28   ` [Intel-gfx] " Ville Syrjälä
2018-03-15 17:28     ` Ville Syrjälä
2018-03-16  8:46     ` [Intel-gfx] " Daniel Vetter
2018-03-16  8:46       ` Daniel Vetter
2018-03-15 14:45 ` [PATCH igt 4/8] lib/igt_gt: check for presence of GPU reset before using it Ulrich Hecht
2018-03-15 14:45   ` Ulrich Hecht
2018-03-15 14:45 ` [PATCH igt 5/8] tests/kms_plane_lowres: skip i915-specific tests on other platforms Ulrich Hecht
2018-03-15 14:45   ` Ulrich Hecht
2018-03-15 17:33   ` [Intel-gfx] " Ville Syrjälä
2018-03-15 17:33     ` Ville Syrjälä
2018-03-15 14:45 ` [PATCH igt 6/8] lib/igt_pm: turn absence of autosuspend_delay_ms from fail to skip Ulrich Hecht
2018-03-15 14:45   ` Ulrich Hecht
2018-03-15 17:43   ` Ville Syrjälä [this message]
2018-03-15 17:43     ` Ville Syrjälä
2018-03-15 14:45 ` [PATCH igt 7/8] tests/kms_addfb_basic: size_tests(): reduce test buffer size Ulrich Hecht
2018-03-15 14:45   ` Ulrich Hecht
2018-03-16  8:53   ` [Intel-gfx] " Daniel Vetter
2018-03-16  8:53     ` Daniel Vetter
2018-03-15 14:45 ` [PATCH igt 8/8] test/kms_addfb_basic: tolerate absence of 8-bit format Ulrich Hecht
2018-03-15 14:45   ` Ulrich Hecht
2018-03-16  8:49   ` [Intel-gfx] " Daniel Vetter
2018-03-16  8:49     ` Daniel Vetter
2018-03-15 15:03 ` ✗ Fi.CI.BAT: failure for Non-Intel test suite fixes Patchwork
2018-03-16  8:55 ` [Intel-gfx] [PATCH igt 0/8] " Daniel Vetter
2018-03-16  8:55   ` Daniel Vetter
2018-03-19 16:41   ` [Intel-gfx] " Ulrich Hecht
2018-03-19 16:41     ` Ulrich Hecht
2018-03-20 11:32     ` [Intel-gfx] " Laurent Pinchart
2018-03-20 11:32       ` Laurent Pinchart
2018-03-21  8:37       ` [Intel-gfx] " Daniel Vetter
2018-03-21  8:37         ` Daniel Vetter
2018-04-27 16:03 ` Laurent Pinchart
2018-04-27 16:03   ` Laurent Pinchart
2018-05-08 16:03   ` Ulrich Hecht
2018-05-08 16:03     ` Ulrich Hecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180315174323.GY5453@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=ulrich.hecht+renesas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.