Re: [B.A.T.M.A.N.] [PATCH 2/3] batman-adv: Introduce packet type independent TVLV handler API

[Sven Eckelmann <sven.eckelmann@open-mesh.com>]

[-- Attachment #1: Type: text/plain, Size: 1479 bytes --]

On Dienstag, 20. September 2016 14:12:44 CEST Linus Lüssing wrote:
[...]
> diff --git a/net/batman-adv/tvlv.c b/net/batman-adv/tvlv.c
> index 77654f0..b4a0442 100644
> --- a/net/batman-adv/tvlv.c
> +++ b/net/batman-adv/tvlv.c
[...]
> +		if (tvlv_value_cont_len > sizeof(tvlv_value_buff)) {
> +			pr_warn_once("batman-adv: TVLVs greater than 128 bytes unsupported for now, ignoring\n");
> +			goto skip_handler_call;
> +		}

Please add the include of linux/printk.h for pr_warn_once.

[...]
> +	WARN_ON(!orig_node);

Please add the include of linux/bug.h for pr_warn_once.


> diff --git a/net/batman-adv/tvlv.h b/net/batman-adv/tvlv.h
> index e4369b5..b3d604f 100644
> --- a/net/batman-adv/tvlv.h
> +++ b/net/batman-adv/tvlv.h
> @@ -30,12 +30,21 @@ void batadv_tvlv_container_register(struct batadv_priv *bat_priv,
>  u16 batadv_tvlv_container_ogm_append(struct batadv_priv *bat_priv,
>  				     unsigned char **packet_buff,
>  				     int *packet_buff_len, int packet_min_len);
> +void *batadv_tvlv_ogm_pack_ctx(struct batadv_orig_node *orig_node);
> +struct batadv_orig_node *batadv_tvlv_ogm_unpack_ctx(void *ctx);
>  void batadv_tvlv_ogm_receive(struct batadv_priv *bat_priv,
> -			     struct batadv_ogm_packet *batadv_ogm_packet,
> +			     const struct sk_buff *skb,
>  			     struct batadv_orig_node *orig_node);

The forward declaration for "struct batadv_ogm_packet;" should now be
replaced with "struct sk_buff;"

Thanks,
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 801 bytes --]