From: "Linus Lüssing" <linus.luessing@c0d3.blue>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH 1/3] batman-adv: Store and transmit own neighborhood hash
Date: Thu, 6 Oct 2016 05:03:15 +0200 [thread overview]
Message-ID: <20161006030315.GE19216@otheros> (raw)
In-Reply-To: <20161006015520.GC19216@otheros>
On Thu, Oct 06, 2016 at 03:55:21AM +0200, Linus Lüssing wrote:
> On Thu, Sep 29, 2016 at 05:31:27PM +0200, Sven Eckelmann wrote:
> > First you have to use hlist_add_head_rcu and hlist_add_behind_rcu here because
> > the readers use RCU to access the list. I think it would also be more
> > appropriate to replace the rcu_read_lock in the batadv_hardif_neigh_get_pre
> > function and instead use lockdep to mark the function as "requires
> > hard_iface->neigh_list_lock".
>
> Hm, I'm currently wondering... isn't this a bug we already have
> now, then? Shouldn't this have been an hlist_add_head_rcu() in the
> first place?
Now saw your patch for maint - so ignore my last comment :D.
next prev parent reply other threads:[~2016-10-06 3:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-20 12:12 [B.A.T.M.A.N.] Broadcast Avoidances, Neighborhood Hash Linus Lüssing
2016-09-20 12:12 ` [B.A.T.M.A.N.] [PATCH 1/3] batman-adv: Store and transmit own neighborhood hash Linus Lüssing
2016-09-20 13:01 ` Sven Eckelmann
2016-09-29 15:31 ` Sven Eckelmann
2016-10-06 1:55 ` Linus Lüssing
2016-10-06 3:03 ` Linus Lüssing [this message]
2016-10-06 15:41 ` Linus Lüssing
2016-09-29 16:05 ` Sven Eckelmann
2016-09-29 16:39 ` Sven Eckelmann
2016-09-20 12:12 ` [B.A.T.M.A.N.] [PATCH 2/3] batman-adv: Introduce packet type independent TVLV handler API Linus Lüssing
2016-09-29 16:05 ` Sven Eckelmann
2016-09-29 16:46 ` Sven Eckelmann
2016-09-20 12:12 ` [B.A.T.M.A.N.] [PATCH 3/3] batman-adv: Evaluate and use neighborhood hash TVLV Linus Lüssing
2016-09-29 15:48 ` Sven Eckelmann
2016-09-29 16:05 ` Sven Eckelmann
2016-09-29 16:55 ` Sven Eckelmann
2016-09-20 12:23 ` [B.A.T.M.A.N.] Broadcast Avoidances, Neighborhood Hash Linus Lüssing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161006030315.GE19216@otheros \
--to=linus.luessing@c0d3.blue \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.