Re: [B.A.T.M.A.N.] [PATCH 3/3] batman-adv: Evaluate and use neighborhood hash TVLV

[Sven Eckelmann <sven.eckelmann@open-mesh.com>]

[-- Attachment #1: Type: text/plain, Size: 1621 bytes --]

On Dienstag, 20. September 2016 14:12:45 CEST Linus Lüssing wrote:
> diff --git a/net/batman-adv/bat_v.c b/net/batman-adv/bat_v.c
> index 762b34c..75a4147 100644
> --- a/net/batman-adv/bat_v.c
> +++ b/net/batman-adv/bat_v.c
[...]
> +	hardif_neigh = batadv_v_elp_unpack_ctx(ctx);
> +	if (WARN_ON(!hardif_neigh))
> +		return NET_RX_DROP;

Please include linux/bug.h for WARN_ON.


> index ed5936c..69a9a94 100644
> --- a/net/batman-adv/bat_v_elp.h
> +++ b/net/batman-adv/bat_v_elp.h
[...]
> +bool batadv_v_elp_nhh_cmp(struct batadv_hardif_neigh_node *hardif_neigh);
> +bool batadv_v_elp_rx_ingress_bad(struct batadv_hardif_neigh_node *hardif_neigh);
> +bool batadv_v_elp_rx_egress_bad(struct batadv_hardif_neigh_node *hardif_neigh);
> +bool batadv_v_elp_tx_ingress_bad(struct batadv_hardif_neigh_node *hardif_neigh);
> +bool batadv_v_elp_tx_egress_bad(struct batadv_hardif_neigh_node *hardif_neigh);
> +bool batadv_v_elp_no_broadcast(struct batadv_hard_iface *if_outgoing,
> +			       struct batadv_hardif_neigh_node *hardif_neigh,
> +			       bool inverse_metric);

Please include linux/types.h for bool.

> diff --git a/net/batman-adv/bat_v_ogm.c b/net/batman-adv/bat_v_ogm.c
> index 606f899..147d746 100644
> --- a/net/batman-adv/bat_v_ogm.c
> +++ b/net/batman-adv/bat_v_ogm.c
> @@ -43,6 +43,7 @@
>  #include "hard-interface.h"
>  #include "hash.h"
>  #include "log.h"
> +#include "bat_v_ogm.h"
>  #include "originator.h"
>  #include "packet.h"
>  #include "routing.h"

Please remove this duplicate include. bat_v_ogm.h is the first include
in this file :)

Thanks,
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 801 bytes --]