All of lore.kernel.org
 help / color / mirror / Atom feed
From: mdalam@codeaurora.org
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: vigneshr@ti.com, richard@nod.at, linux-kernel@vger.kernel.org,
	boris.brezillon@collabora.com, linux-mtd@lists.infradead.org,
	manivannan.sadhasivam@linaro.org, sricharan@codeaurora.org
Subject: Re: [PATCH V3] mtd: rawnand: qcom: update last code word register
Date: Fri, 29 Jan 2021 10:35:12 +0530	[thread overview]
Message-ID: <189aaad7cfaf9e4cadd525b936430c8b@codeaurora.org> (raw)
In-Reply-To: <20210128231110.64266932@xps13>

On 2021-01-29 03:41, Miquel Raynal wrote:
> Hello,
> 
> mdalam@codeaurora.org wrote on Fri, 29 Jan 2021 03:18:46 +0530:
> 
>> On 2021-01-14 21:23, Miquel Raynal wrote:
>> > Hello,
>> >
>> > Md Sadre Alam <mdalam@codeaurora.org> wrote on Sun, 10 Jan 2021
>> > 09:31:45 +0530:
>> >
>> >> From QPIC version 2.0 onwards new register got added to
>> >
>> >                                 a
>> >
>> >> read last codeword. This change will update the same.
>> >
>> >        the?           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>> >                       Please reword this sentence.
>> 
>>    Fixed this in V4 patch.
>> >
>> >> For first three code word READ_LOCATION_n register will be
>> >> use.For last code word READ_LOCATION_LAST_CW_n register will be
>> >> use.
>> >
>> > "For the first three codewords, READ_LOCATION_n registers will be used.
>> > The last codeword register will be accessed through
>> > READ_LOCATION_LAST_CW_n."
>> >
>> > Also, please specify what these registers store.
>> 
>>    The location register is mainly use for reading controller
>>    buffer via BAM mode. The bits of the register 
>> "NAND_READ_LOCATION_LAST_CW_n, n=0..4"
>>    as follow:
> 
> Perhaps what I do not understand is: when is this "last_cw" register
> more useful than the previous set?

   From QPIC Version 2.0 onwards it is mandatory to use 
"NAND_READ_LOCATION_LAST_CW_n, n=0..4"
   register to extract last code word data from controller buffer. Using 
register "NAND_READ_LOCATION_n, n=0..4"
   we can extract all code words except last code word.
> 
>>    [9:0]-bits : (OFFSET) This bit defines the offset from the buffer 
>> base address to be picked up for DMA.
>>    [25:16]-bits: (SIZE) This bit of every register will define the 
>> size of the chunk for DMA.
>>    31-bit :      (LAST) If this bit is set, the controller takes the 
>> particular register to specify the last chunk
>>                        of data made available for DMA. This chunk is 
>> part of the internal buffer of the controller.
>> 
>> >
> 
> Thanks,
> Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: mdalam@codeaurora.org
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: manivannan.sadhasivam@linaro.org, richard@nod.at,
	vigneshr@ti.com, boris.brezillon@collabora.com,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
	sricharan@codeaurora.org
Subject: Re: [PATCH V3] mtd: rawnand: qcom: update last code word register
Date: Fri, 29 Jan 2021 10:35:12 +0530	[thread overview]
Message-ID: <189aaad7cfaf9e4cadd525b936430c8b@codeaurora.org> (raw)
In-Reply-To: <20210128231110.64266932@xps13>

On 2021-01-29 03:41, Miquel Raynal wrote:
> Hello,
> 
> mdalam@codeaurora.org wrote on Fri, 29 Jan 2021 03:18:46 +0530:
> 
>> On 2021-01-14 21:23, Miquel Raynal wrote:
>> > Hello,
>> >
>> > Md Sadre Alam <mdalam@codeaurora.org> wrote on Sun, 10 Jan 2021
>> > 09:31:45 +0530:
>> >
>> >> From QPIC version 2.0 onwards new register got added to
>> >
>> >                                 a
>> >
>> >> read last codeword. This change will update the same.
>> >
>> >        the?           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>> >                       Please reword this sentence.
>> 
>>    Fixed this in V4 patch.
>> >
>> >> For first three code word READ_LOCATION_n register will be
>> >> use.For last code word READ_LOCATION_LAST_CW_n register will be
>> >> use.
>> >
>> > "For the first three codewords, READ_LOCATION_n registers will be used.
>> > The last codeword register will be accessed through
>> > READ_LOCATION_LAST_CW_n."
>> >
>> > Also, please specify what these registers store.
>> 
>>    The location register is mainly use for reading controller
>>    buffer via BAM mode. The bits of the register 
>> "NAND_READ_LOCATION_LAST_CW_n, n=0..4"
>>    as follow:
> 
> Perhaps what I do not understand is: when is this "last_cw" register
> more useful than the previous set?

   From QPIC Version 2.0 onwards it is mandatory to use 
"NAND_READ_LOCATION_LAST_CW_n, n=0..4"
   register to extract last code word data from controller buffer. Using 
register "NAND_READ_LOCATION_n, n=0..4"
   we can extract all code words except last code word.
> 
>>    [9:0]-bits : (OFFSET) This bit defines the offset from the buffer 
>> base address to be picked up for DMA.
>>    [25:16]-bits: (SIZE) This bit of every register will define the 
>> size of the chunk for DMA.
>>    31-bit :      (LAST) If this bit is set, the controller takes the 
>> particular register to specify the last chunk
>>                        of data made available for DMA. This chunk is 
>> part of the internal buffer of the controller.
>> 
>> >
> 
> Thanks,
> Miquèl

  reply	other threads:[~2021-01-29  5:06 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-10  4:01 [PATCH V3] mtd: rawnand: qcom: update last code word register Md Sadre Alam
2021-01-10  4:01 ` Md Sadre Alam
2021-01-14 15:53 ` Miquel Raynal
2021-01-14 15:53   ` Miquel Raynal
2021-01-14 16:31   ` Manivannan Sadhasivam
2021-01-14 16:31     ` Manivannan Sadhasivam
2021-01-14 16:42     ` Miquel Raynal
2021-01-14 16:42       ` Miquel Raynal
2021-01-28 21:48   ` mdalam
2021-01-28 21:48     ` mdalam
2021-01-28 22:11     ` Miquel Raynal
2021-01-28 22:11       ` Miquel Raynal
2021-01-29  5:05       ` mdalam [this message]
2021-01-29  5:05         ` mdalam
2021-01-28  7:52 ` Manivannan Sadhasivam
2021-01-28  7:52   ` Manivannan Sadhasivam
2021-01-29  5:11   ` mdalam
2021-01-29  5:11     ` mdalam
2021-02-05 17:53     ` mdalam
2021-02-05 17:53       ` mdalam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=189aaad7cfaf9e4cadd525b936430c8b@codeaurora.org \
    --to=mdalam@codeaurora.org \
    --cc=boris.brezillon@collabora.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=sricharan@codeaurora.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.