All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan.Bruens@rwth-aachen.de (Brüns, Stefan)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 07/11] dmaengine: sun6i: Retrieve channel count/max request from devicetree
Date: Mon, 16 Oct 2017 14:21:02 +0000	[thread overview]
Message-ID: <1918888.BSE68NRsHe@sbruens-linux> (raw)
In-Reply-To: <20171016070217.GO30097@localhost>

On Montag, 16. Oktober 2017 09:02:17 CEST Vinod Koul wrote:
> On Thu, Sep 28, 2017 at 03:49:24AM +0200, Stefan Br?ns wrote:
> > To avoid introduction of a new compatible for each small SoC/DMA
> > controller
> > variation, move the definition of the channel count to the devicetree.
> > 
> > The number of vchans is no longer explicit, but limited by the highest
> > port/DMA request number. The result is a slight overallocation for SoCs
> > with a sparse port mapping.
> 
> This doesnt apply for me, please check

The hunk below fails after https://git.kernel.org/pub/scm/linux/kernel/git/
vkoul/slave-dma.git/commit/?h=topic/
sun&id=8f3b00347bf075fb457f90ce76573615f567e7bc
, which removed the "const struct of_device_id *device;" declaration.


> diff --git a/drivers/dma/sun6i-dma.c b/drivers/dma/sun6i-dma.c
> index 7fce976a13d8..b5906da2a975 100644
> --- a/drivers/dma/sun6i-dma.c
> +++ b/drivers/dma/sun6i-dma.c
> @@ -42,6 +42,9 @@
...
> @@ -1155,6 +1159,7 @@ MODULE_DEVICE_TABLE(of, sun6i_dma_match);
>  static int sun6i_dma_probe(struct platform_device *pdev)
>  {
>  	const struct of_device_id *device;
> +	struct device_node *np = pdev->dev.of_node;
>  	struct sun6i_dma_dev *sdc;
>  	struct resource *res;
>  	int ret, i;

Can you fix this up, or should I send a new version of this patch?

Kind regards,

Stefan

WARNING: multiple messages have this Message-ID (diff)
From: "Brüns, Stefan" <Stefan.Bruens-vA1bhqPz9FBZXbeN9DUtxg@public.gmane.org>
To: Vinod Koul <vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: "linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org"
	<linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org>,
	"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
	Andre Przywara <andre.przywara-5wv7dgnIgG8@public.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Dan Williams
	<dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Code Kipper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Maxime Ripard
	<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
	"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH v4 07/11] dmaengine: sun6i: Retrieve channel count/max request from devicetree
Date: Mon, 16 Oct 2017 14:21:02 +0000	[thread overview]
Message-ID: <1918888.BSE68NRsHe@sbruens-linux> (raw)
In-Reply-To: <20171016070217.GO30097@localhost>

On Montag, 16. Oktober 2017 09:02:17 CEST Vinod Koul wrote:
> On Thu, Sep 28, 2017 at 03:49:24AM +0200, Stefan Brüns wrote:
> > To avoid introduction of a new compatible for each small SoC/DMA
> > controller
> > variation, move the definition of the channel count to the devicetree.
> > 
> > The number of vchans is no longer explicit, but limited by the highest
> > port/DMA request number. The result is a slight overallocation for SoCs
> > with a sparse port mapping.
> 
> This doesnt apply for me, please check

The hunk below fails after https://git.kernel.org/pub/scm/linux/kernel/git/
vkoul/slave-dma.git/commit/?h=topic/
sun&id=8f3b00347bf075fb457f90ce76573615f567e7bc
, which removed the "const struct of_device_id *device;" declaration.


> diff --git a/drivers/dma/sun6i-dma.c b/drivers/dma/sun6i-dma.c
> index 7fce976a13d8..b5906da2a975 100644
> --- a/drivers/dma/sun6i-dma.c
> +++ b/drivers/dma/sun6i-dma.c
> @@ -42,6 +42,9 @@
..
> @@ -1155,6 +1159,7 @@ MODULE_DEVICE_TABLE(of, sun6i_dma_match);
>  static int sun6i_dma_probe(struct platform_device *pdev)
>  {
>  	const struct of_device_id *device;
> +	struct device_node *np = pdev->dev.of_node;
>  	struct sun6i_dma_dev *sdc;
>  	struct resource *res;
>  	int ret, i;

Can you fix this up, or should I send a new version of this patch?

Kind regards,

Stefan
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: "Brüns, Stefan" <Stefan.Bruens@rwth-aachen.de>
To: Vinod Koul <vinod.koul@intel.com>
Cc: "linux-sunxi@googlegroups.com" <linux-sunxi@googlegroups.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Chen-Yu Tsai <wens@csie.org>,
	Andre Przywara <andre.przywara@arm.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Dan Williams <dan.j.williams@intel.com>,
	Rob Herring <robh+dt@kernel.org>,
	"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
	Code Kipper <codekipper@gmail.com>,
	Maxime Ripard <maxime.ripard@free-electrons.com>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 07/11] dmaengine: sun6i: Retrieve channel count/max request from devicetree
Date: Mon, 16 Oct 2017 14:21:02 +0000	[thread overview]
Message-ID: <1918888.BSE68NRsHe@sbruens-linux> (raw)
In-Reply-To: <20171016070217.GO30097@localhost>

On Montag, 16. Oktober 2017 09:02:17 CEST Vinod Koul wrote:
> On Thu, Sep 28, 2017 at 03:49:24AM +0200, Stefan Brüns wrote:
> > To avoid introduction of a new compatible for each small SoC/DMA
> > controller
> > variation, move the definition of the channel count to the devicetree.
> > 
> > The number of vchans is no longer explicit, but limited by the highest
> > port/DMA request number. The result is a slight overallocation for SoCs
> > with a sparse port mapping.
> 
> This doesnt apply for me, please check

The hunk below fails after https://git.kernel.org/pub/scm/linux/kernel/git/
vkoul/slave-dma.git/commit/?h=topic/
sun&id=8f3b00347bf075fb457f90ce76573615f567e7bc
, which removed the "const struct of_device_id *device;" declaration.


> diff --git a/drivers/dma/sun6i-dma.c b/drivers/dma/sun6i-dma.c
> index 7fce976a13d8..b5906da2a975 100644
> --- a/drivers/dma/sun6i-dma.c
> +++ b/drivers/dma/sun6i-dma.c
> @@ -42,6 +42,9 @@
..
> @@ -1155,6 +1159,7 @@ MODULE_DEVICE_TABLE(of, sun6i_dma_match);
>  static int sun6i_dma_probe(struct platform_device *pdev)
>  {
>  	const struct of_device_id *device;
> +	struct device_node *np = pdev->dev.of_node;
>  	struct sun6i_dma_dev *sdc;
>  	struct resource *res;
>  	int ret, i;

Can you fix this up, or should I send a new version of this patch?

Kind regards,

Stefan

  reply	other threads:[~2017-10-16 14:21 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20170928014928.2272-1-stefan.bruens@rwth-aachen.de>
2017-09-28  1:49 ` [PATCH v4 01/11] dmaengine: sun6i: Correct setting of clock autogating register for A83T/H3 Stefan Brüns
2017-09-28  1:49   ` Stefan Brüns
2017-09-28  1:49   ` Stefan Brüns
2017-09-28  1:49 ` [PATCH v4 02/11] dmaengine: sun6i: Correct burst length field offsets for H3 Stefan Brüns
2017-09-28  1:49   ` Stefan Brüns
2017-09-28  1:49   ` Stefan Brüns
2017-09-28  1:49 ` [PATCH v4 03/11] dmaengine: sun6i: Restructure code to allow extension for new SoCs Stefan Brüns
2017-09-28  1:49   ` Stefan Brüns
2017-09-28  1:49   ` Stefan Brüns
2017-09-28  1:49 ` [PATCH v4 04/11] dmaengine: sun6i: Enable additional burst lengths/widths on H3 Stefan Brüns
2017-09-28  1:49   ` Stefan Brüns
2017-09-28  1:49   ` Stefan Brüns
2017-09-28  1:49 ` [PATCH v4 05/11] dmaengine: sun6i: Move number of pchans/vchans/request to device struct Stefan Brüns
2017-09-28  1:49   ` Stefan Brüns
2017-09-28  1:49   ` Stefan Brüns
2017-09-28  1:49 ` [PATCH v4 06/11] arm64: allwinner: a64: Add devicetree binding for DMA controller Stefan Brüns
2017-09-28  1:49   ` Stefan Brüns
2017-09-28  1:49   ` Stefan Brüns
2017-09-28  1:49 ` [PATCH v4 07/11] dmaengine: sun6i: Retrieve channel count/max request from devicetree Stefan Brüns
2017-09-28  1:49   ` Stefan Brüns
2017-09-28  1:49   ` Stefan Brüns
2017-10-16  7:02   ` Vinod Koul
2017-10-16  7:02     ` Vinod Koul
2017-10-16  7:02     ` Vinod Koul
2017-10-16 14:21     ` Brüns, Stefan [this message]
2017-10-16 14:21       ` Brüns, Stefan
2017-10-16 14:21       ` Brüns, Stefan
2017-10-16 17:15       ` Vinod Koul
2017-10-16 17:15         ` Vinod Koul
2017-10-16 17:15         ` Vinod Koul
2017-09-28  1:49 ` [PATCH v4 08/11] dmaengine: sun6i: Add support for Allwinner A64 and compatibles Stefan Brüns
2017-09-28  1:49   ` Stefan Brüns
2017-09-28  1:49   ` Stefan Brüns
2017-09-28  1:49 ` [PATCH v4 09/11] arm64: allwinner: a64: Add device node for DMA controller Stefan Brüns
2017-09-28  1:49   ` Stefan Brüns
2017-09-28  1:49   ` Stefan Brüns
2017-09-28  1:49 ` [PATCH v4 10/11] arm64: allwinner: a64: add dma controller references to spi nodes Stefan Brüns
2017-09-28  1:49   ` Stefan Brüns
2017-09-28  1:49   ` Stefan Brüns
2017-09-28  1:49 ` [PATCH v4 11/11] arm: allwinner: Correct unit name in devicetree binding example Stefan Brüns
2017-09-28  1:49   ` Stefan Brüns
2017-09-28  1:49   ` Stefan Brüns
2017-10-05 22:34   ` Rob Herring
2017-10-05 22:34     ` Rob Herring
2017-10-16 23:06 ` [PATCH v5 07/11] dmaengine: sun6i: Retrieve channel count/max request from devicetree Stefan Brüns
2017-10-16 23:06   ` Stefan Brüns
2017-10-16 23:06   ` Stefan Brüns
2017-10-23  6:15   ` Vinod Koul
2017-10-23  6:15     ` Vinod Koul
2017-10-23  6:15     ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1918888.BSE68NRsHe@sbruens-linux \
    --to=stefan.bruens@rwth-aachen.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.