From: Joey Lu <a0987203069@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
mcoquelin.stm32@gmail.com, richardcochran@gmail.com,
alexandre.torgue@foss.st.com, joabreu@synopsys.com,
ychuang3@nuvoton.com, schung@nuvoton.com, yclu4@nuvoton.com,
peppe.cavallaro@st.com, linux-arm-kernel@lists.infradead.org,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org,
linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH v3 3/3] net: stmmac: dwmac-nuvoton: Add dwmac glue for Nuvoton MA35 family
Date: Tue, 19 Nov 2024 18:08:14 +0800 [thread overview]
Message-ID: <191ebf4b-231d-4ebc-9ff2-4916ef718970@gmail.com> (raw)
In-Reply-To: <4d44bc93-6a81-4dc8-9f22-a103882f25e1@lunn.ch>
Andrew Lunn 於 11/19/2024 9:48 AM 寫道:
>> + if (of_property_read_u32(dev->of_node, "tx-internal-delay-ps", &arg)) {
>> + tx_delay = 0; /* Default value is 0 */
>> + } else {
>> + if (arg <= 2000) {
>> + tx_delay = (arg == 2000) ? 0xF : (arg / PATH_DELAY_DEC);
>> + dev_dbg(dev, "Set Tx path delay to 0x%x\n", tx_delay);
> The device tree binding says:
>
> + tx-internal-delay-ps:
> + enum: [0, 2000]
>
>
> So only two values are allowed. Yet the C code is
>
> arg / PATH_DELAY_DEC
>
> which seems to allow 16 values?
>
> Please make this consistent.
>
>
> Andrew
Oops. That was my misuse; I will change it to minimum and maximum.
Thanks!
BR,
Joey
>
> ---
> pw-bot: cr
WARNING: multiple messages have this Message-ID (diff)
From: Joey Lu <a0987203069@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: ychuang3@nuvoton.com, edumazet@google.com, schung@nuvoton.com,
yclu4@nuvoton.com, linux-stm32@st-md-mailman.stormreply.com,
robh@kernel.org, openbmc@lists.ozlabs.org, joabreu@synopsys.com,
kuba@kernel.org, pabeni@redhat.com, devicetree@vger.kernel.org,
conor+dt@kernel.org, richardcochran@gmail.com,
alexandre.torgue@foss.st.com, peppe.cavallaro@st.com,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, andrew+netdev@lunn.ch,
mcoquelin.stm32@gmail.com, krzk+dt@kernel.org,
davem@davemloft.net
Subject: Re: [PATCH v3 3/3] net: stmmac: dwmac-nuvoton: Add dwmac glue for Nuvoton MA35 family
Date: Tue, 19 Nov 2024 18:08:14 +0800 [thread overview]
Message-ID: <191ebf4b-231d-4ebc-9ff2-4916ef718970@gmail.com> (raw)
In-Reply-To: <4d44bc93-6a81-4dc8-9f22-a103882f25e1@lunn.ch>
Andrew Lunn 於 11/19/2024 9:48 AM 寫道:
>> + if (of_property_read_u32(dev->of_node, "tx-internal-delay-ps", &arg)) {
>> + tx_delay = 0; /* Default value is 0 */
>> + } else {
>> + if (arg <= 2000) {
>> + tx_delay = (arg == 2000) ? 0xF : (arg / PATH_DELAY_DEC);
>> + dev_dbg(dev, "Set Tx path delay to 0x%x\n", tx_delay);
> The device tree binding says:
>
> + tx-internal-delay-ps:
> + enum: [0, 2000]
>
>
> So only two values are allowed. Yet the C code is
>
> arg / PATH_DELAY_DEC
>
> which seems to allow 16 values?
>
> Please make this consistent.
>
>
> Andrew
Oops. That was my misuse; I will change it to minimum and maximum.
Thanks!
BR,
Joey
>
> ---
> pw-bot: cr
next prev parent reply other threads:[~2024-11-19 10:09 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-18 8:27 [PATCH v3 0/3] Add support for Nuvoton MA35D1 GMAC Joey Lu
2024-11-18 8:27 ` Joey Lu
2024-11-18 8:27 ` [PATCH v3 1/3] dt-bindings: net: nuvoton: Add schema for Nuvoton MA35 family GMAC Joey Lu
2024-11-18 8:27 ` Joey Lu
2024-11-19 18:12 ` Rob Herring
2024-11-19 18:12 ` Rob Herring
2024-11-20 8:39 ` Joey Lu
2024-11-18 8:27 ` [PATCH v3 2/3] arm64: dts: nuvoton: Add Ethernet nodes Joey Lu
2024-11-18 8:27 ` Joey Lu
2024-11-26 10:08 ` Krzysztof Kozlowski
2024-11-26 10:08 ` Krzysztof Kozlowski
2024-11-27 8:01 ` Joey Lu
2024-11-27 8:01 ` Joey Lu
2024-11-18 8:27 ` [PATCH v3 3/3] net: stmmac: dwmac-nuvoton: Add dwmac glue for Nuvoton MA35 family Joey Lu
2024-11-18 8:27 ` Joey Lu
2024-11-19 1:48 ` Andrew Lunn
2024-11-19 1:48 ` Andrew Lunn
2024-11-19 10:08 ` Joey Lu [this message]
2024-11-19 10:08 ` Joey Lu
2024-11-20 14:56 ` Uwe Kleine-König
2024-11-20 14:56 ` Uwe Kleine-König
2024-11-26 9:39 ` Joey Lu
2024-11-26 9:39 ` Joey Lu
2024-11-26 10:10 ` Krzysztof Kozlowski
2024-11-26 10:10 ` Krzysztof Kozlowski
2024-11-27 8:03 ` Joey Lu
2024-11-27 8:03 ` Joey Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=191ebf4b-231d-4ebc-9ff2-4916ef718970@gmail.com \
--to=a0987203069@gmail.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=joabreu@synopsys.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
--cc=schung@nuvoton.com \
--cc=ychuang3@nuvoton.com \
--cc=yclu4@nuvoton.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.