Re: [PATCH v8 6/6] coreaudio: Initialize the buffer for device change

[Christian Schoenebeck <qemu_oss@crudebyte.com>]

On Wednesday, 4 March 2026 07:16:59 CET Akihiko Odaki wrote:
> Reallocate buffers when the active device change as the required buffer
> size may differ.
> 
> Signed-off-by: Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>
> Reviewed-by: Phil Dennis-Jordan <phil@philjordan.eu>
> Acked-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
> ---
>  audio/coreaudio.m | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/audio/coreaudio.m b/audio/coreaudio.m
> index 23c3d1f80ac5..e4ec1df971c8 100644
> --- a/audio/coreaudio.m
> +++ b/audio/coreaudio.m
> @@ -471,6 +471,7 @@ static OSStatus init_out_device(CoreaudioVoiceOut *core)
> core->device_id = device_id;
>      core->device_frame_size = device_frame_size;
>      core->hw.samples = core->buffer_count * core->device_frame_size;
> +    audio_generic_initialize_buffer_out(&core->hw);
>      core->ioprocid = ioprocid;
> 
>      return 0;

There is no specific reason to insert that call between the struct
initializers here, or is there? I mean the device is suspended at this point,
so it should not matter. Just looks a bit weird.

But in general, LGTM:

Reviewed-by: Christian Schoenebeck <qemu_oss@crudebyte.com>