Re: [PATCH v8 0/6] coreaudio fixes

[Christian Schoenebeck <qemu_oss@crudebyte.com>]

On Wednesday, 4 March 2026 07:16:53 CET Akihiko Odaki wrote:
> This series contains two fixes for coreaudio. See each one for details.


Most of the patches in this series actually just do plain refactoring, which I
personally don't care for at all.

It would be therefore helpful to make it clear right from the patch commit log
whether a patch is just flipping names or really changing some behaviour.

/Christian


> Signed-off-by: Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>
> ---
> Changes in v8:
> - Rebased.
> - Link to v7:
> https://lore.kernel.org/qemu-devel/20250124-coreaudio-v7-0-9d9a4d91db37@day
> nix.com
> 
> Changes in v7:
> - Added patch "coreaudio: Remove extra whitespaces".
> - Link to v6:
> https://lore.kernel.org/qemu-devel/20250124-coreaudio-v6-0-11fbcb6c47cf@day
> nix.com
> 
> Changes in v6:
> - Added patch "coreaudio: Remove unnecessary explicit casts".
> - Link to v5:
> https://lore.kernel.org/qemu-devel/20250123-coreaudio-v5-0-6873df4215a0@day
> nix.com
> 
> Changes in v5:
> - Added patch "coreaudio: Improve naming", removing verbose names like
>   outputDeviceID and audioDevicePropertyBufferFrameSize altogether.
> - Link to v4:
> https://lore.kernel.org/r/20250117-coreaudio-v4-0-f8d4fa4cb5f4@daynix.com
> 
> Changes in v4:
> - Splitted patch "audio: Add functions to initialize buffers" from
>   patch "coreaudio: Initialize the buffer for device change".
> - Changed the message of patch "coreaudio: Commit the result of init in
>   the end" to tell that early returns happen when there is a fatal error
>   or the device gets unplugged.
> - Link to v3:
> https://lore.kernel.org/r/20250115-coreaudio-v3-0-bdb6bcb5bf9f@daynix.com
> 
> ---
> Akihiko Odaki (6):
>       coreaudio: Remove unnecessary explicit casts
>       coreaudio: Remove extra whitespaces
>       coreaudio: Improve naming
>       coreaudio: Commit the result of init in the end
>       audio: Add functions to initialize buffers
>       coreaudio: Initialize the buffer for device change
> 
>  audio/audio_int.h       |   2 +
>  audio/audio-mixeng-be.c |  24 ++++--
>  audio/coreaudio.m       | 206
> +++++++++++++++++++++++++----------------------- 3 files changed, 127
> insertions(+), 105 deletions(-)
> ---
> base-commit: ffcf1a7981793973ffbd8100a7c3c6042d02ae23
> change-id: 20250109-coreaudio-c984607e1d8c
> 
> Best regards,
> --
> Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>