Re: [PATCH v8 3/6] coreaudio: Improve naming

[Christian Schoenebeck <qemu_oss@crudebyte.com>]

On Wednesday, 4 March 2026 11:42:41 CET Akihiko Odaki wrote:
> On 2026/03/04 18:25, Christian Schoenebeck wrote:
> > On Wednesday, 4 March 2026 07:16:56 CET Akihiko Odaki wrote:
> >> coreaudio had names that are not conforming to QEMU codding style.
> > 
> > coding
> > 
> >> coreaudioVoiceOut also had some members that are prefixed with redundant
> >> words like "output" or "audio".
> >> Global names included "out" to tell they are specific to output devices,
> >> but this rule was not completely enforced.
> >> The frame size had three different names "frameSize", "bufferFrameSize",
> >> and "frameCount".
> >> 
> >> Replace identifiers to fix these problems.
> >> 
> >> Signed-off-by: Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>
> >> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
[...]
> >> @@ -349,16 +351,16 @@ static OSStatus audioDeviceIOProc(
> >> 
> >>           out += write_len;
> >>       
> >>       }
> >> 
> >> -    coreaudio_buf_unlock(core, "audioDeviceIOProc");
> >> +    coreaudio_voice_out_buf_unlock(core, "out_device_ioproc");
> > 
> > Behaviour change. Not pure refactoring. Should be split into a separate
> > patch.
> Two things are renamed here.
> - coreaudio_buf_unlock() is renamed to coreaudio_voice_out_buf_unlock().
> - "audioDeviceIOProc" is the name of this function. This function is
>    renamed to "out_device_ioproc".

Ah, these strings just end up being used in a log message. My bad, fine then!

/Christian