From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Kieran Bingham <kieran@ksquared.org.uk>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v4 2/4] dt-bindings: Add Renesas R-Car FDP1 bindings
Date: Mon, 24 Oct 2016 12:46:46 +0300 [thread overview]
Message-ID: <1923730.zaykC4sXJR@avalon> (raw)
In-Reply-To: <CAMuHMdUGy0+bv-t=8HXeQf0BpoMJMNP85cd2tubQzD4Zj8X9Gw@mail.gmail.com>
Hi Geert,
On Monday 24 Oct 2016 11:14:11 Geert Uytterhoeven wrote:
> On Mon, Oct 24, 2016 at 11:03 AM, Laurent Pinchart wrote:
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/renesas,fdp1.txt
> > @@ -0,0 +1,33 @@
> > +Renesas R-Car Fine Display Processor (FDP1)
> > +-------------------------------------------
> > +
> > +The FDP1 is a de-interlacing module which converts interlaced video to
> > +progressive video. It is capable of performing pixel format conversion
> > between +YCbCr/YUV formats and RGB formats. Only YCbCr/YUV formats are
> > supported as +an input to the module.
> > +
> > + - compatible: Must be the following
> > +
> > + - "renesas,fdp1" for generic compatible
> > +
> > + - reg: the register base and size for the device registers
> > + - interrupts : interrupt specifier for the FDP1 instance
> > + - clocks: reference to the functional clock
> > + - renesas,fcp: reference to the FCPF connected to the FDP1
> > +
> > +Optional properties:
> > + - power-domains : power-domain property defined with a power domain
> > specifier
> "power domain"?
>
> > + to respective power domain.
>
> Still, too many power domains in one sentence?
How about
- power-domains : reference to the power domain that the FDP1 belongs to, if
any.
--
Regards,
Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
To: Geert Uytterhoeven <geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
Cc: Laurent Pinchart
<laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>,
Linux Media Mailing List
<linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Linux-Renesas
<linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Kieran Bingham <kieran-7hKh/agyDeatmTQ+vhA3Yw@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v4 2/4] dt-bindings: Add Renesas R-Car FDP1 bindings
Date: Mon, 24 Oct 2016 12:46:46 +0300 [thread overview]
Message-ID: <1923730.zaykC4sXJR@avalon> (raw)
In-Reply-To: <CAMuHMdUGy0+bv-t=8HXeQf0BpoMJMNP85cd2tubQzD4Zj8X9Gw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
Hi Geert,
On Monday 24 Oct 2016 11:14:11 Geert Uytterhoeven wrote:
> On Mon, Oct 24, 2016 at 11:03 AM, Laurent Pinchart wrote:
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/renesas,fdp1.txt
> > @@ -0,0 +1,33 @@
> > +Renesas R-Car Fine Display Processor (FDP1)
> > +-------------------------------------------
> > +
> > +The FDP1 is a de-interlacing module which converts interlaced video to
> > +progressive video. It is capable of performing pixel format conversion
> > between +YCbCr/YUV formats and RGB formats. Only YCbCr/YUV formats are
> > supported as +an input to the module.
> > +
> > + - compatible: Must be the following
> > +
> > + - "renesas,fdp1" for generic compatible
> > +
> > + - reg: the register base and size for the device registers
> > + - interrupts : interrupt specifier for the FDP1 instance
> > + - clocks: reference to the functional clock
> > + - renesas,fcp: reference to the FCPF connected to the FDP1
> > +
> > +Optional properties:
> > + - power-domains : power-domain property defined with a power domain
> > specifier
> "power domain"?
>
> > + to respective power domain.
>
> Still, too many power domains in one sentence?
How about
- power-domains : reference to the power domain that the FDP1 belongs to, if
any.
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-10-24 9:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-24 9:03 [PATCH v4 0/4] v4l: platform: Add Renesas R-Car FDP1 Driver Laurent Pinchart
2016-10-24 9:03 ` Laurent Pinchart
2016-10-24 9:03 ` [PATCH v4 1/4] v4l: ctrls: Add deinterlacing mode control Laurent Pinchart
2016-10-24 9:03 ` Laurent Pinchart
2016-10-24 9:03 ` [PATCH v4 2/4] dt-bindings: Add Renesas R-Car FDP1 bindings Laurent Pinchart
2016-10-24 9:03 ` Laurent Pinchart
2016-10-24 9:14 ` Geert Uytterhoeven
2016-10-24 9:46 ` Laurent Pinchart [this message]
2016-10-24 9:46 ` Laurent Pinchart
2016-10-24 10:01 ` Geert Uytterhoeven
2016-10-24 11:47 ` [PATCH v4.1 " Laurent Pinchart
2016-10-24 11:47 ` Laurent Pinchart
2016-10-24 9:03 ` [PATCH v4 3/4] v4l: Add Renesas R-Car FDP1 Driver Laurent Pinchart
2016-10-24 9:03 ` Laurent Pinchart
2016-10-24 11:21 ` Kieran Bingham
2016-10-24 11:49 ` Laurent Pinchart
2016-10-24 9:03 ` [PATCH v4 4/4] arm64: dts: renesas: r8a7796: Add FDP1 instance Laurent Pinchart
2016-10-24 9:03 ` Laurent Pinchart
2016-10-24 10:31 ` Kieran Bingham
2016-10-24 11:03 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1923730.zaykC4sXJR@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=kieran@ksquared.org.uk \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.