From: Heiko Stuebner <heiko@sntech.de>
To: lpieralisi@kernel.org, kw@linux.com,
manivannan.sadhasivam@linaro.org, robh@kernel.org,
bhelgaas@google.com, cassel@kernel.org, ukleinek@debian.org,
dlemoal@kernel.org, yoshihiro.shimoda.uh@renesas.com,
Chen Ni <nichen@iscas.ac.cn>
Cc: linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Chen Ni <nichen@iscas.ac.cn>
Subject: Re: [PATCH] PCI: dw-rockchip: Remove redundant dev_err()
Date: Wed, 18 Sep 2024 10:21:25 +0200 [thread overview]
Message-ID: <1945968.taCxCBeP46@phil> (raw)
In-Reply-To: <20240918074401.2221146-1-nichen@iscas.ac.cn>
Am Mittwoch, 18. September 2024, 09:44:01 CEST schrieb Chen Ni:
> There is no need to call the dev_err() function directly to print a
> custom message when handling an error from platform_get_irq_byname()
> function as it is going to display an appropriate error message in case
> of a failure.
>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: lpieralisi@kernel.org, kw@linux.com,
manivannan.sadhasivam@linaro.org, robh@kernel.org,
bhelgaas@google.com, cassel@kernel.org, ukleinek@debian.org,
dlemoal@kernel.org, yoshihiro.shimoda.uh@renesas.com,
Chen Ni <nichen@iscas.ac.cn>
Cc: linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Chen Ni <nichen@iscas.ac.cn>
Subject: Re: [PATCH] PCI: dw-rockchip: Remove redundant dev_err()
Date: Wed, 18 Sep 2024 10:21:25 +0200 [thread overview]
Message-ID: <1945968.taCxCBeP46@phil> (raw)
In-Reply-To: <20240918074401.2221146-1-nichen@iscas.ac.cn>
Am Mittwoch, 18. September 2024, 09:44:01 CEST schrieb Chen Ni:
> There is no need to call the dev_err() function directly to print a
> custom message when handling an error from platform_get_irq_byname()
> function as it is going to display an appropriate error message in case
> of a failure.
>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2024-09-18 8:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-18 7:44 [PATCH] PCI: dw-rockchip: Remove redundant dev_err() Chen Ni
2024-09-18 7:44 ` Chen Ni
2024-09-18 8:21 ` Heiko Stuebner [this message]
2024-09-18 8:21 ` Heiko Stuebner
2024-09-24 14:21 ` Manivannan Sadhasivam
2024-09-24 14:21 ` Manivannan Sadhasivam
2024-10-06 7:39 ` Markus Elfring
2024-10-06 7:39 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1945968.taCxCBeP46@phil \
--to=heiko@sntech.de \
--cc=bhelgaas@google.com \
--cc=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=nichen@iscas.ac.cn \
--cc=robh@kernel.org \
--cc=ukleinek@debian.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.