* [PATCH] PCI: dw-rockchip: Remove redundant dev_err()
@ 2024-09-18 7:44 ` Chen Ni
0 siblings, 0 replies; 8+ messages in thread
From: Chen Ni @ 2024-09-18 7:44 UTC (permalink / raw)
To: lpieralisi, kw, manivannan.sadhasivam, robh, bhelgaas, heiko,
cassel, ukleinek, dlemoal, yoshihiro.shimoda.uh
Cc: linux-pci, linux-arm-kernel, linux-rockchip, linux-kernel,
Chen Ni
There is no need to call the dev_err() function directly to print a
custom message when handling an error from platform_get_irq_byname()
function as it is going to display an appropriate error message in case
of a failure.
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
drivers/pci/controller/dwc/pcie-dw-rockchip.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/pci/controller/dwc/pcie-dw-rockchip.c b/drivers/pci/controller/dwc/pcie-dw-rockchip.c
index 1170e1107508..3770e566b597 100644
--- a/drivers/pci/controller/dwc/pcie-dw-rockchip.c
+++ b/drivers/pci/controller/dwc/pcie-dw-rockchip.c
@@ -450,10 +450,8 @@ static int rockchip_pcie_configure_ep(struct platform_device *pdev,
return -ENODEV;
irq = platform_get_irq_byname(pdev, "sys");
- if (irq < 0) {
- dev_err(dev, "missing sys IRQ resource\n");
+ if (irq < 0)
return irq;
- }
ret = devm_request_threaded_irq(dev, irq, NULL,
rockchip_pcie_ep_sys_irq_thread,
--
2.25.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] PCI: dw-rockchip: Remove redundant dev_err()
2024-09-18 7:44 ` Chen Ni
@ 2024-09-18 8:21 ` Heiko Stuebner
-1 siblings, 0 replies; 8+ messages in thread
From: Heiko Stuebner @ 2024-09-18 8:21 UTC (permalink / raw)
To: lpieralisi, kw, manivannan.sadhasivam, robh, bhelgaas, cassel,
ukleinek, dlemoal, yoshihiro.shimoda.uh, Chen Ni
Cc: linux-pci, linux-arm-kernel, linux-rockchip, linux-kernel,
Chen Ni
Am Mittwoch, 18. September 2024, 09:44:01 CEST schrieb Chen Ni:
> There is no need to call the dev_err() function directly to print a
> custom message when handling an error from platform_get_irq_byname()
> function as it is going to display an appropriate error message in case
> of a failure.
>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] PCI: dw-rockchip: Remove redundant dev_err()
@ 2024-09-18 8:21 ` Heiko Stuebner
0 siblings, 0 replies; 8+ messages in thread
From: Heiko Stuebner @ 2024-09-18 8:21 UTC (permalink / raw)
To: lpieralisi, kw, manivannan.sadhasivam, robh, bhelgaas, cassel,
ukleinek, dlemoal, yoshihiro.shimoda.uh, Chen Ni
Cc: linux-pci, linux-arm-kernel, linux-rockchip, linux-kernel,
Chen Ni
Am Mittwoch, 18. September 2024, 09:44:01 CEST schrieb Chen Ni:
> There is no need to call the dev_err() function directly to print a
> custom message when handling an error from platform_get_irq_byname()
> function as it is going to display an appropriate error message in case
> of a failure.
>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] PCI: dw-rockchip: Remove redundant dev_err()
2024-09-18 7:44 ` Chen Ni
@ 2024-09-24 14:21 ` Manivannan Sadhasivam
-1 siblings, 0 replies; 8+ messages in thread
From: Manivannan Sadhasivam @ 2024-09-24 14:21 UTC (permalink / raw)
To: Chen Ni
Cc: lpieralisi, kw, robh, bhelgaas, heiko, cassel, ukleinek, dlemoal,
yoshihiro.shimoda.uh, linux-pci, linux-arm-kernel, linux-rockchip,
linux-kernel
On Wed, Sep 18, 2024 at 03:44:01PM +0800, Chen Ni wrote:
> There is no need to call the dev_err() function directly to print a
> custom message when handling an error from platform_get_irq_byname()
> function as it is going to display an appropriate error message in case
> of a failure.
>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
- Mani
> ---
> drivers/pci/controller/dwc/pcie-dw-rockchip.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/pci/controller/dwc/pcie-dw-rockchip.c b/drivers/pci/controller/dwc/pcie-dw-rockchip.c
> index 1170e1107508..3770e566b597 100644
> --- a/drivers/pci/controller/dwc/pcie-dw-rockchip.c
> +++ b/drivers/pci/controller/dwc/pcie-dw-rockchip.c
> @@ -450,10 +450,8 @@ static int rockchip_pcie_configure_ep(struct platform_device *pdev,
> return -ENODEV;
>
> irq = platform_get_irq_byname(pdev, "sys");
> - if (irq < 0) {
> - dev_err(dev, "missing sys IRQ resource\n");
> + if (irq < 0)
> return irq;
> - }
>
> ret = devm_request_threaded_irq(dev, irq, NULL,
> rockchip_pcie_ep_sys_irq_thread,
> --
> 2.25.1
>
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] PCI: dw-rockchip: Remove redundant dev_err()
@ 2024-09-24 14:21 ` Manivannan Sadhasivam
0 siblings, 0 replies; 8+ messages in thread
From: Manivannan Sadhasivam @ 2024-09-24 14:21 UTC (permalink / raw)
To: Chen Ni
Cc: lpieralisi, kw, robh, bhelgaas, heiko, cassel, ukleinek, dlemoal,
yoshihiro.shimoda.uh, linux-pci, linux-arm-kernel, linux-rockchip,
linux-kernel
On Wed, Sep 18, 2024 at 03:44:01PM +0800, Chen Ni wrote:
> There is no need to call the dev_err() function directly to print a
> custom message when handling an error from platform_get_irq_byname()
> function as it is going to display an appropriate error message in case
> of a failure.
>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
- Mani
> ---
> drivers/pci/controller/dwc/pcie-dw-rockchip.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/pci/controller/dwc/pcie-dw-rockchip.c b/drivers/pci/controller/dwc/pcie-dw-rockchip.c
> index 1170e1107508..3770e566b597 100644
> --- a/drivers/pci/controller/dwc/pcie-dw-rockchip.c
> +++ b/drivers/pci/controller/dwc/pcie-dw-rockchip.c
> @@ -450,10 +450,8 @@ static int rockchip_pcie_configure_ep(struct platform_device *pdev,
> return -ENODEV;
>
> irq = platform_get_irq_byname(pdev, "sys");
> - if (irq < 0) {
> - dev_err(dev, "missing sys IRQ resource\n");
> + if (irq < 0)
> return irq;
> - }
>
> ret = devm_request_threaded_irq(dev, irq, NULL,
> rockchip_pcie_ep_sys_irq_thread,
> --
> 2.25.1
>
--
மணிவண்ணன் சதாசிவம்
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] PCI: dw-rockchip: Remove redundant dev_err()
2024-09-18 7:44 ` Chen Ni
@ 2024-10-06 7:39 ` Markus Elfring
-1 siblings, 0 replies; 8+ messages in thread
From: Markus Elfring @ 2024-10-06 7:39 UTC (permalink / raw)
To: Chen Ni, linux-rockchip, linux-arm-kernel, linux-pci,
Bjorn Helgaas, Damien Le Moal, Heiko Stübner,
Krzysztof Wilczyński, Lorenzo Pieralisi,
Manivannan Sadhasivam, Niklas Cassel, Rob Herring,
Uwe Kleine-König, Yoshihiro Shimoda
Cc: LKML, kernel-janitors
> There is no need to call the dev_err() function directly to print a
> custom message when handling an error from platform_get_irq_byname()
> function as it is going to display an appropriate error message in case
call?
> of a failure.
Were any static source code analysis tools involved in the detection
of the presented change possibility?
By the way:
Such a patch can be generated also by the means of the semantic patch
language (Coccinelle software) for example.
Regards,
Markus
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] PCI: dw-rockchip: Remove redundant dev_err()
@ 2024-10-06 7:39 ` Markus Elfring
0 siblings, 0 replies; 8+ messages in thread
From: Markus Elfring @ 2024-10-06 7:39 UTC (permalink / raw)
To: Chen Ni, linux-rockchip, linux-arm-kernel, linux-pci,
Bjorn Helgaas, Damien Le Moal, Heiko Stübner,
Krzysztof Wilczyński, Lorenzo Pieralisi,
Manivannan Sadhasivam, Niklas Cassel, Rob Herring,
Uwe Kleine-König, Yoshihiro Shimoda
Cc: LKML, kernel-janitors
> There is no need to call the dev_err() function directly to print a
> custom message when handling an error from platform_get_irq_byname()
> function as it is going to display an appropriate error message in case
call?
> of a failure.
Were any static source code analysis tools involved in the detection
of the presented change possibility?
By the way:
Such a patch can be generated also by the means of the semantic patch
language (Coccinelle software) for example.
Regards,
Markus
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 8+ messages in thread