* [PATCH] [Outreachy kernel] staging: wfx: remove blank line
@ 2020-03-08 18:41 Payal Kshirsagar
2020-03-09 11:41 ` Stefano Brivio
0 siblings, 1 reply; 4+ messages in thread
From: Payal Kshirsagar @ 2020-03-08 18:41 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Payal Kshirsagar
Blank line is not necessary before a close brace '}', remove it.
Signed-off-by: Payal Kshirsagar <payalskshirsagar1234@gmail.com>
---
drivers/staging/wfx/data_rx.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/wfx/data_rx.c b/drivers/staging/wfx/data_rx.c
index 5d198457c6ce..2a09f6b978c3 100644
--- a/drivers/staging/wfx/data_rx.c
+++ b/drivers/staging/wfx/data_rx.c
@@ -62,7 +62,6 @@ static int wfx_drop_encrypt_data(struct wfx_dev *wdev,
memmove(skb->data + iv_len, skb->data, hdrlen);
skb_pull(skb, iv_len);
return 0;
-
}
void wfx_rx_cb(struct wfx_vif *wvif,
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] [Outreachy kernel] staging: wfx: remove blank line
2020-03-08 18:41 Payal Kshirsagar
@ 2020-03-09 11:41 ` Stefano Brivio
0 siblings, 0 replies; 4+ messages in thread
From: Stefano Brivio @ 2020-03-09 11:41 UTC (permalink / raw)
To: Payal Kshirsagar; +Cc: outreachy-kernel
On Mon, 9 Mar 2020 00:11:30 +0530
Payal Kshirsagar <payalskshirsagar1234@gmail.com> wrote:
> Blank line is not necessary before a close brace '}', remove it.
>
> Signed-off-by: Payal Kshirsagar <payalskshirsagar1234@gmail.com>
> ---
> drivers/staging/wfx/data_rx.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/wfx/data_rx.c b/drivers/staging/wfx/data_rx.c
> index 5d198457c6ce..2a09f6b978c3 100644
> --- a/drivers/staging/wfx/data_rx.c
> +++ b/drivers/staging/wfx/data_rx.c
> @@ -62,7 +62,6 @@ static int wfx_drop_encrypt_data(struct wfx_dev *wdev,
> memmove(skb->data + iv_len, skb->data, hdrlen);
> skb_pull(skb, iv_len);
> return 0;
> -
> }
>
> void wfx_rx_cb(struct wfx_vif *wvif,
As you're removing one single blank line from a single function, for
the future, the commit title could be more descriptive: "staging: wfx:
remove excess newline in wfx_drop_encrypt_data()". This might be
subject to personal taste, though. Change looks good per se.
Same here, you should Cc: more people.
--
Stefano
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] [Outreachy kernel] staging: wfx: remove blank line
@ 2020-03-09 16:55 Payal Kshirsagar
2020-03-09 17:36 ` Jérôme Pouiller
0 siblings, 1 reply; 4+ messages in thread
From: Payal Kshirsagar @ 2020-03-09 16:55 UTC (permalink / raw)
To: jerome.pouiller, gregkh, outreachy-kernel; +Cc: Payal Kshirsagar
Blank line is not necessary before a close brace '}', remove it.
Signed-off-by: Payal Kshirsagar <payalskshirsagar1234@gmail.com>
---
drivers/staging/wfx/data_rx.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/wfx/data_rx.c b/drivers/staging/wfx/data_rx.c
index 5d198457c6ce..2a09f6b978c3 100644
--- a/drivers/staging/wfx/data_rx.c
+++ b/drivers/staging/wfx/data_rx.c
@@ -62,7 +62,6 @@ static int wfx_drop_encrypt_data(struct wfx_dev *wdev,
memmove(skb->data + iv_len, skb->data, hdrlen);
skb_pull(skb, iv_len);
return 0;
-
}
void wfx_rx_cb(struct wfx_vif *wvif,
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] [Outreachy kernel] staging: wfx: remove blank line
2020-03-09 16:55 [PATCH] [Outreachy kernel] staging: wfx: remove blank line Payal Kshirsagar
@ 2020-03-09 17:36 ` Jérôme Pouiller
0 siblings, 0 replies; 4+ messages in thread
From: Jérôme Pouiller @ 2020-03-09 17:36 UTC (permalink / raw)
To: Payal Kshirsagar
Cc: gregkh@linuxfoundation.org, outreachy-kernel@googlegroups.com
On Monday 9 March 2020 17:55:28 CET Payal Kshirsagar wrote:
>
> Blank line is not necessary before a close brace '}', remove it.
>
> Signed-off-by: Payal Kshirsagar <payalskshirsagar1234@gmail.com>
> ---
> drivers/staging/wfx/data_rx.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/wfx/data_rx.c b/drivers/staging/wfx/data_rx.c
> index 5d198457c6ce..2a09f6b978c3 100644
> --- a/drivers/staging/wfx/data_rx.c
> +++ b/drivers/staging/wfx/data_rx.c
> @@ -62,7 +62,6 @@ static int wfx_drop_encrypt_data(struct wfx_dev *wdev,
> memmove(skb->data + iv_len, skb->data, hdrlen);
> skb_pull(skb, iv_len);
> return 0;
> -
> }
>
> void wfx_rx_cb(struct wfx_vif *wvif,
> --
> 2.17.1
Reviewed-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
--
Jérôme Pouiller
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-09 20:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-09 16:55 [PATCH] [Outreachy kernel] staging: wfx: remove blank line Payal Kshirsagar
2020-03-09 17:36 ` Jérôme Pouiller
-- strict thread matches above, loose matches on Subject: below --
2020-03-08 18:41 Payal Kshirsagar
2020-03-09 11:41 ` Stefano Brivio
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.