All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Song Bao Hua (Barry Song)" <song.bao.hua@hisilicon.com>
To: Colin King <colin.king@canonical.com>,
	Christoph Hellwig <hch@lst.de>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Robin Murphy <robin.murphy@arm.com>,
	"iommu@lists.linux-foundation.org"
	<iommu@lists.linux-foundation.org>
Cc: "kernel-janitors@vger.kernel.org"
	<kernel-janitors@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] dma-mapping: fix an uninitialized pointer read due to typo in argp assignment
Date: Wed, 25 Nov 2020 18:22:24 +0000	[thread overview]
Message-ID: <1b430a80dec14cb9aa612ff7e5dddac4@hisilicon.com> (raw)
In-Reply-To: <20201125135535.1880307-1-colin.king@canonical.com>

DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogQ29saW4gS2luZyBbbWFp
bHRvOmNvbGluLmtpbmdAY2Fub25pY2FsLmNvbV0NCj4gU2VudDogVGh1cnNkYXksIE5vdmVtYmVy
IDI2LCAyMDIwIDI6NTYgQU0NCj4gVG86IFNvbmcgQmFvIEh1YSAoQmFycnkgU29uZykgPHNvbmcu
YmFvLmh1YUBoaXNpbGljb24uY29tPjsgQ2hyaXN0b3BoDQo+IEhlbGx3aWcgPGhjaEBsc3QuZGU+
OyBNYXJlayBTenlwcm93c2tpIDxtLnN6eXByb3dza2lAc2Ftc3VuZy5jb20+Ow0KPiBSb2JpbiBN
dXJwaHkgPHJvYmluLm11cnBoeUBhcm0uY29tPjsgaW9tbXVAbGlzdHMubGludXgtZm91bmRhdGlv
bi5vcmcNCj4gQ2M6IGtlcm5lbC1qYW5pdG9yc0B2Z2VyLmtlcm5lbC5vcmc7IGxpbnV4LWtlcm5l
bEB2Z2VyLmtlcm5lbC5vcmcNCj4gU3ViamVjdDogW1BBVENIXSBkbWEtbWFwcGluZzogZml4IGFu
IHVuaW5pdGlhbGl6ZWQgcG9pbnRlciByZWFkIGR1ZSB0byB0eXBvIGluDQo+IGFyZ3AgYXNzaWdu
bWVudA0KPiANCj4gRnJvbTogQ29saW4gSWFuIEtpbmcgPGNvbGluLmtpbmdAY2Fub25pY2FsLmNv
bT4NCj4gDQo+IFRoZSBhc3NpZ25tZW50IG9mIGFyZ3AgaXMgY3VycmVudGx5IHVzaW5nIGFyZ3Ag
YXMgdGhlIHNvdXJjZSBiZWNhdXNlIG9mDQo+IGEgdHlwby4gRml4IHRoaXMgYnkgYXNzaWduaW5n
IGl0IHRoZSB2YWx1ZSBwYXNzZWQgaW4gYXJnIGluc3RlYWQuDQo+IA0KPiBBZGRyZXNzZXMtQ292
ZXJpdHk6ICgiVW5pbml0aWFsaXplZCBwb2ludGVyIHJlYWQiKQ0KPiBGaXhlczogYmZkMmRlZmVk
OTRkICgiZG1hLW1hcHBpbmc6IGFkZCBiZW5jaG1hcmsgc3VwcG9ydCBmb3Igc3RyZWFtaW5nDQo+
IERNQSBBUElzIikNCj4gU2lnbmVkLW9mZi1ieTogQ29saW4gSWFuIEtpbmcgPGNvbGluLmtpbmdA
Y2Fub25pY2FsLmNvbT4NCg0KQWNrZWQtYnk6IEJhcnJ5IFNvbmcgPHNvbmcuYmFvLmh1YUBoaXNp
bGljb24uY29tPg0KDQo+IC0tLQ0KPiAga2VybmVsL2RtYS9tYXBfYmVuY2htYXJrLmMgfCAyICst
DQo+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkNCj4gDQo+
IGRpZmYgLS1naXQgYS9rZXJuZWwvZG1hL21hcF9iZW5jaG1hcmsuYyBiL2tlcm5lbC9kbWEvbWFw
X2JlbmNobWFyay5jDQo+IGluZGV4IGNhNjE2YjY2NGY3Mi4uZTFlMzc2MDNkMDFiIDEwMDY0NA0K
PiAtLS0gYS9rZXJuZWwvZG1hL21hcF9iZW5jaG1hcmsuYw0KPiArKysgYi9rZXJuZWwvZG1hL21h
cF9iZW5jaG1hcmsuYw0KPiBAQCAtMTkyLDcgKzE5Miw3IEBAIHN0YXRpYyBsb25nIG1hcF9iZW5j
aG1hcmtfaW9jdGwoc3RydWN0IGZpbGUgKmZpbGUsDQo+IHVuc2lnbmVkIGludCBjbWQsDQo+ICAJ
CXVuc2lnbmVkIGxvbmcgYXJnKQ0KPiAgew0KPiAgCXN0cnVjdCBtYXBfYmVuY2htYXJrX2RhdGEg
Km1hcCA9IGZpbGUtPnByaXZhdGVfZGF0YTsNCj4gLQl2b2lkIF9fdXNlciAqYXJncCA9ICh2b2lk
IF9fdXNlciAqKWFyZ3A7DQo+ICsJdm9pZCBfX3VzZXIgKmFyZ3AgPSAodm9pZCBfX3VzZXIgKilh
cmc7DQo+ICAJdTY0IG9sZF9kbWFfbWFzazsNCj4gDQo+ICAJaW50IHJldDsNCj4gLS0NCj4gMi4y
OS4yDQoNClRoYW5rcw0KQmFycnkNCg0K

WARNING: multiple messages have this Message-ID (diff)
From: "Song Bao Hua (Barry Song)" <song.bao.hua@hisilicon.com>
To: Colin King <colin.king@canonical.com>,
	Christoph Hellwig <hch@lst.de>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Robin Murphy <robin.murphy@arm.com>,
	"iommu@lists.linux-foundation.org"
	<iommu@lists.linux-foundation.org>
Cc: "kernel-janitors@vger.kernel.org"
	<kernel-janitors@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] dma-mapping: fix an uninitialized pointer read due to typo in argp assignment
Date: Wed, 25 Nov 2020 18:22:24 +0000	[thread overview]
Message-ID: <1b430a80dec14cb9aa612ff7e5dddac4@hisilicon.com> (raw)
In-Reply-To: <20201125135535.1880307-1-colin.king@canonical.com>



> -----Original Message-----
> From: Colin King [mailto:colin.king@canonical.com]
> Sent: Thursday, November 26, 2020 2:56 AM
> To: Song Bao Hua (Barry Song) <song.bao.hua@hisilicon.com>; Christoph
> Hellwig <hch@lst.de>; Marek Szyprowski <m.szyprowski@samsung.com>;
> Robin Murphy <robin.murphy@arm.com>; iommu@lists.linux-foundation.org
> Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] dma-mapping: fix an uninitialized pointer read due to typo in
> argp assignment
> 
> From: Colin Ian King <colin.king@canonical.com>
> 
> The assignment of argp is currently using argp as the source because of
> a typo. Fix this by assigning it the value passed in arg instead.
> 
> Addresses-Coverity: ("Uninitialized pointer read")
> Fixes: bfd2defed94d ("dma-mapping: add benchmark support for streaming
> DMA APIs")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Acked-by: Barry Song <song.bao.hua@hisilicon.com>

> ---
>  kernel/dma/map_benchmark.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/dma/map_benchmark.c b/kernel/dma/map_benchmark.c
> index ca616b664f72..e1e37603d01b 100644
> --- a/kernel/dma/map_benchmark.c
> +++ b/kernel/dma/map_benchmark.c
> @@ -192,7 +192,7 @@ static long map_benchmark_ioctl(struct file *file,
> unsigned int cmd,
>  		unsigned long arg)
>  {
>  	struct map_benchmark_data *map = file->private_data;
> -	void __user *argp = (void __user *)argp;
> +	void __user *argp = (void __user *)arg;
>  	u64 old_dma_mask;
> 
>  	int ret;
> --
> 2.29.2

Thanks
Barry

_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

WARNING: multiple messages have this Message-ID (diff)
From: "Song Bao Hua (Barry Song)" <song.bao.hua@hisilicon.com>
To: Colin King <colin.king@canonical.com>,
	Christoph Hellwig <hch@lst.de>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Robin Murphy <robin.murphy@arm.com>,
	"iommu@lists.linux-foundation.org"
	<iommu@lists.linux-foundation.org>
Cc: "kernel-janitors@vger.kernel.org"
	<kernel-janitors@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] dma-mapping: fix an uninitialized pointer read due to typo in argp assignment
Date: Wed, 25 Nov 2020 18:22:24 +0000	[thread overview]
Message-ID: <1b430a80dec14cb9aa612ff7e5dddac4@hisilicon.com> (raw)
In-Reply-To: <20201125135535.1880307-1-colin.king@canonical.com>



> -----Original Message-----
> From: Colin King [mailto:colin.king@canonical.com]
> Sent: Thursday, November 26, 2020 2:56 AM
> To: Song Bao Hua (Barry Song) <song.bao.hua@hisilicon.com>; Christoph
> Hellwig <hch@lst.de>; Marek Szyprowski <m.szyprowski@samsung.com>;
> Robin Murphy <robin.murphy@arm.com>; iommu@lists.linux-foundation.org
> Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] dma-mapping: fix an uninitialized pointer read due to typo in
> argp assignment
> 
> From: Colin Ian King <colin.king@canonical.com>
> 
> The assignment of argp is currently using argp as the source because of
> a typo. Fix this by assigning it the value passed in arg instead.
> 
> Addresses-Coverity: ("Uninitialized pointer read")
> Fixes: bfd2defed94d ("dma-mapping: add benchmark support for streaming
> DMA APIs")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Acked-by: Barry Song <song.bao.hua@hisilicon.com>

> ---
>  kernel/dma/map_benchmark.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/dma/map_benchmark.c b/kernel/dma/map_benchmark.c
> index ca616b664f72..e1e37603d01b 100644
> --- a/kernel/dma/map_benchmark.c
> +++ b/kernel/dma/map_benchmark.c
> @@ -192,7 +192,7 @@ static long map_benchmark_ioctl(struct file *file,
> unsigned int cmd,
>  		unsigned long arg)
>  {
>  	struct map_benchmark_data *map = file->private_data;
> -	void __user *argp = (void __user *)argp;
> +	void __user *argp = (void __user *)arg;
>  	u64 old_dma_mask;
> 
>  	int ret;
> --
> 2.29.2

Thanks
Barry


  reply	other threads:[~2020-11-25 18:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-25 13:55 [PATCH] dma-mapping: fix an uninitialized pointer read due to typo in argp assignment Colin King
2020-11-25 13:55 ` Colin King
2020-11-25 18:22 ` Song Bao Hua (Barry Song) [this message]
2020-11-25 18:22   ` Song Bao Hua (Barry Song)
2020-11-25 18:22   ` Song Bao Hua (Barry Song)
2020-11-25 18:29   ` Christoph Hellwig
2020-11-25 18:29     ` Christoph Hellwig
2020-11-25 18:29     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1b430a80dec14cb9aa612ff7e5dddac4@hisilicon.com \
    --to=song.bao.hua@hisilicon.com \
    --cc=colin.king@canonical.com \
    --cc=hch@lst.de \
    --cc=iommu@lists.linux-foundation.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=robin.murphy@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.