From: "Rafał Miłecki" <zajec5@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Michael Walle" <michael@walle.cc>,
"Miquel Raynal" <miquel.raynal@bootlin.com>,
linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, u-boot@lists.denx.de,
"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH V2 3/5] nvmem: u-boot-env: use more nvmem subsystem helpers
Date: Tue, 19 Dec 2023 19:16:37 +0100 [thread overview]
Message-ID: <1b5d4c36-9963-476c-8edf-e807beceda80@gmail.com> (raw)
In-Reply-To: <2023121929-salami-pessimist-c943@gregkh>
On 19.12.2023 19:13, Greg Kroah-Hartman wrote:
> On Tue, Dec 19, 2023 at 06:40:23PM +0100, Rafał Miłecki wrote:
>> From: Rafał Miłecki <rafal@milecki.pl>
>>
>> 1. Use nvmem_dev_size() and nvmem_device_read() to make this driver less
>> mtd dependent
>> 2. Use nvmem_add_one_cell() to simplify adding NVMEM cells
>
> Shouldn't this be 2 different patches?
I used to maintainers complaining my patches are too small and not the
other way ;) I think it happened two or three times with mtd subsys.
Sure, I can split it.
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: "Rafał Miłecki" <zajec5@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Michael Walle" <michael@walle.cc>,
"Miquel Raynal" <miquel.raynal@bootlin.com>,
linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, u-boot@lists.denx.de,
"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH V2 3/5] nvmem: u-boot-env: use more nvmem subsystem helpers
Date: Tue, 19 Dec 2023 19:16:37 +0100 [thread overview]
Message-ID: <1b5d4c36-9963-476c-8edf-e807beceda80@gmail.com> (raw)
In-Reply-To: <2023121929-salami-pessimist-c943@gregkh>
On 19.12.2023 19:13, Greg Kroah-Hartman wrote:
> On Tue, Dec 19, 2023 at 06:40:23PM +0100, Rafał Miłecki wrote:
>> From: Rafał Miłecki <rafal@milecki.pl>
>>
>> 1. Use nvmem_dev_size() and nvmem_device_read() to make this driver less
>> mtd dependent
>> 2. Use nvmem_add_one_cell() to simplify adding NVMEM cells
>
> Shouldn't this be 2 different patches?
I used to maintainers complaining my patches are too small and not the
other way ;) I think it happened two or three times with mtd subsys.
Sure, I can split it.
WARNING: multiple messages have this Message-ID (diff)
From: "Rafał Miłecki" <zajec5@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Michael Walle" <michael@walle.cc>,
"Miquel Raynal" <miquel.raynal@bootlin.com>,
linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, u-boot@lists.denx.de,
"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH V2 3/5] nvmem: u-boot-env: use more nvmem subsystem helpers
Date: Tue, 19 Dec 2023 19:16:37 +0100 [thread overview]
Message-ID: <1b5d4c36-9963-476c-8edf-e807beceda80@gmail.com> (raw)
In-Reply-To: <2023121929-salami-pessimist-c943@gregkh>
On 19.12.2023 19:13, Greg Kroah-Hartman wrote:
> On Tue, Dec 19, 2023 at 06:40:23PM +0100, Rafał Miłecki wrote:
>> From: Rafał Miłecki <rafal@milecki.pl>
>>
>> 1. Use nvmem_dev_size() and nvmem_device_read() to make this driver less
>> mtd dependent
>> 2. Use nvmem_add_one_cell() to simplify adding NVMEM cells
>
> Shouldn't this be 2 different patches?
I used to maintainers complaining my patches are too small and not the
other way ;) I think it happened two or three times with mtd subsys.
Sure, I can split it.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-12-19 18:16 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 17:40 [PATCH V2 1/5] dt-bindings: nvmem: layouts: add U-Boot environment variables layout Rafał Miłecki
2023-12-19 17:40 ` Rafał Miłecki
2023-12-19 17:40 ` Rafał Miłecki
2023-12-19 17:40 ` [PATCH V2 2/5] nvmem: core: add nvmem_dev_size() helper Rafał Miłecki
2023-12-19 17:40 ` Rafał Miłecki
2023-12-19 17:40 ` Rafał Miłecki
2023-12-19 17:40 ` [PATCH V2 3/5] nvmem: u-boot-env: use more nvmem subsystem helpers Rafał Miłecki
2023-12-19 17:40 ` Rafał Miłecki
2023-12-19 17:40 ` Rafał Miłecki
2023-12-19 18:13 ` Greg Kroah-Hartman
2023-12-19 18:13 ` Greg Kroah-Hartman
2023-12-19 18:13 ` Greg Kroah-Hartman
2023-12-19 18:16 ` Rafał Miłecki [this message]
2023-12-19 18:16 ` Rafał Miłecki
2023-12-19 18:16 ` Rafał Miłecki
2023-12-20 7:17 ` Miquel Raynal
2023-12-20 7:17 ` Miquel Raynal
2023-12-20 7:17 ` Miquel Raynal
2023-12-19 17:40 ` [PATCH V2 4/5] nvmem: u-boot-env: improve coding style Rafał Miłecki
2023-12-19 17:40 ` Rafał Miłecki
2023-12-19 17:40 ` Rafał Miłecki
2023-12-20 7:19 ` Miquel Raynal
2023-12-20 7:19 ` Miquel Raynal
2023-12-20 7:19 ` Miquel Raynal
2023-12-19 17:40 ` [PATCH V2 5/5] nvmem: layouts: add U-Boot env layout Rafał Miłecki
2023-12-19 17:40 ` Rafał Miłecki
2023-12-19 17:40 ` Rafał Miłecki
2023-12-20 7:27 ` Miquel Raynal
2023-12-20 7:27 ` Miquel Raynal
2023-12-20 7:27 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b5d4c36-9963-476c-8edf-e807beceda80@gmail.com \
--to=zajec5@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=michael@walle.cc \
--cc=miquel.raynal@bootlin.com \
--cc=rafal@milecki.pl \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.