All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Michael Walle" <michael@walle.cc>,
	linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, u-boot@lists.denx.de,
	"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH V2 4/5] nvmem: u-boot-env: improve coding style
Date: Wed, 20 Dec 2023 08:19:24 +0100	[thread overview]
Message-ID: <20231220081924.39b96ec4@xps-13> (raw)
In-Reply-To: <20231219174025.15228-4-zajec5@gmail.com>

Hi Rafał,

zajec5@gmail.com wrote on Tue, 19 Dec 2023 18:40:24 +0100:

> From: Rafał Miłecki <rafal@milecki.pl>
> 
> 1. Prefer kzalloc() over kcalloc()
>    See memory-allocation.rst which says: "to be on the safe side it's
>    best to use routines that set memory to zero, like kzalloc()"
> 2. Drop dev_err() for u_boot_env_add_cells() fail
>    It can fail only on -ENOMEM. We don't want to print error then.
> 3. Add extra "crc32_addr" variable
>    It makes code reading header's crc32 easier to understand / review.
> 
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>

Looks much nicer :)

Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Michael Walle" <michael@walle.cc>,
	linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, u-boot@lists.denx.de,
	"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH V2 4/5] nvmem: u-boot-env: improve coding style
Date: Wed, 20 Dec 2023 08:19:24 +0100	[thread overview]
Message-ID: <20231220081924.39b96ec4@xps-13> (raw)
In-Reply-To: <20231219174025.15228-4-zajec5@gmail.com>

Hi Rafał,

zajec5@gmail.com wrote on Tue, 19 Dec 2023 18:40:24 +0100:

> From: Rafał Miłecki <rafal@milecki.pl>
> 
> 1. Prefer kzalloc() over kcalloc()
>    See memory-allocation.rst which says: "to be on the safe side it's
>    best to use routines that set memory to zero, like kzalloc()"
> 2. Drop dev_err() for u_boot_env_add_cells() fail
>    It can fail only on -ENOMEM. We don't want to print error then.
> 3. Add extra "crc32_addr" variable
>    It makes code reading header's crc32 easier to understand / review.
> 
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>

Looks much nicer :)

Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>

Thanks,
Miquèl

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Michael Walle" <michael@walle.cc>,
	linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, u-boot@lists.denx.de,
	"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH V2 4/5] nvmem: u-boot-env: improve coding style
Date: Wed, 20 Dec 2023 08:19:24 +0100	[thread overview]
Message-ID: <20231220081924.39b96ec4@xps-13> (raw)
In-Reply-To: <20231219174025.15228-4-zajec5@gmail.com>

Hi Rafał,

zajec5@gmail.com wrote on Tue, 19 Dec 2023 18:40:24 +0100:

> From: Rafał Miłecki <rafal@milecki.pl>
> 
> 1. Prefer kzalloc() over kcalloc()
>    See memory-allocation.rst which says: "to be on the safe side it's
>    best to use routines that set memory to zero, like kzalloc()"
> 2. Drop dev_err() for u_boot_env_add_cells() fail
>    It can fail only on -ENOMEM. We don't want to print error then.
> 3. Add extra "crc32_addr" variable
>    It makes code reading header's crc32 easier to understand / review.
> 
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>

Looks much nicer :)

Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>

Thanks,
Miquèl

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-12-20  7:19 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-19 17:40 [PATCH V2 1/5] dt-bindings: nvmem: layouts: add U-Boot environment variables layout Rafał Miłecki
2023-12-19 17:40 ` Rafał Miłecki
2023-12-19 17:40 ` Rafał Miłecki
2023-12-19 17:40 ` [PATCH V2 2/5] nvmem: core: add nvmem_dev_size() helper Rafał Miłecki
2023-12-19 17:40   ` Rafał Miłecki
2023-12-19 17:40   ` Rafał Miłecki
2023-12-19 17:40 ` [PATCH V2 3/5] nvmem: u-boot-env: use more nvmem subsystem helpers Rafał Miłecki
2023-12-19 17:40   ` Rafał Miłecki
2023-12-19 17:40   ` Rafał Miłecki
2023-12-19 18:13   ` Greg Kroah-Hartman
2023-12-19 18:13     ` Greg Kroah-Hartman
2023-12-19 18:13     ` Greg Kroah-Hartman
2023-12-19 18:16     ` Rafał Miłecki
2023-12-19 18:16       ` Rafał Miłecki
2023-12-19 18:16       ` Rafał Miłecki
2023-12-20  7:17       ` Miquel Raynal
2023-12-20  7:17         ` Miquel Raynal
2023-12-20  7:17         ` Miquel Raynal
2023-12-19 17:40 ` [PATCH V2 4/5] nvmem: u-boot-env: improve coding style Rafał Miłecki
2023-12-19 17:40   ` Rafał Miłecki
2023-12-19 17:40   ` Rafał Miłecki
2023-12-20  7:19   ` Miquel Raynal [this message]
2023-12-20  7:19     ` Miquel Raynal
2023-12-20  7:19     ` Miquel Raynal
2023-12-19 17:40 ` [PATCH V2 5/5] nvmem: layouts: add U-Boot env layout Rafał Miłecki
2023-12-19 17:40   ` Rafał Miłecki
2023-12-19 17:40   ` Rafał Miłecki
2023-12-20  7:27   ` Miquel Raynal
2023-12-20  7:27     ` Miquel Raynal
2023-12-20  7:27     ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231220081924.39b96ec4@xps-13 \
    --to=miquel.raynal@bootlin.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=michael@walle.cc \
    --cc=rafal@milecki.pl \
    --cc=robh+dt@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=u-boot@lists.denx.de \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.