From: Dave Hansen <dave.hansen@intel.com>
To: Ali Saidi <alisaidi@amazon.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, x86@kernel.org
Cc: Kees Cook <keescook@chromium.org>,
Peter Zijlstra <peterz@infradead.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Will Deacon <will.deacon@arm.com>, Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <bp@alien8.de>, Andy Lutomirski <luto@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
David Woodhouse <dwmw@amazon.co.uk>,
Anthony Liguori <aliguori@amazon.com>
Subject: Re: [PATCH 2/2] x86/mmap: handle worst-case heap randomization in mmap_base
Date: Wed, 13 Mar 2019 09:25:38 -0700 [thread overview]
Message-ID: <1bd04037-698f-00c7-aa91-2bfec751bb0e@intel.com> (raw)
In-Reply-To: <20190312173248.13490-3-alisaidi@amazon.com>
On 3/12/19 10:32 AM, Ali Saidi wrote:
> + /* Provide space for brk randomization */
> + pad += SZ_32M;
Just curious: Why is the padding in your other patch conditional on the
32-bit vs. 64-bit apps, but here it's always 32M?
Also, did you hit this problem in practice somehow?
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave.hansen@intel.com>
To: Ali Saidi <alisaidi@amazon.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, x86@kernel.org
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
Kees Cook <keescook@chromium.org>, Borislav Petkov <bp@alien8.de>,
Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Andy Lutomirski <luto@kernel.org>,
Dave Hansen <dave.hansen@linux.intel.com>,
Will Deacon <will.deacon@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
David Woodhouse <dwmw@amazon.co.uk>,
Anthony Liguori <aliguori@amazon.com>
Subject: Re: [PATCH 2/2] x86/mmap: handle worst-case heap randomization in mmap_base
Date: Wed, 13 Mar 2019 09:25:38 -0700 [thread overview]
Message-ID: <1bd04037-698f-00c7-aa91-2bfec751bb0e@intel.com> (raw)
In-Reply-To: <20190312173248.13490-3-alisaidi@amazon.com>
On 3/12/19 10:32 AM, Ali Saidi wrote:
> + /* Provide space for brk randomization */
> + pad += SZ_32M;
Just curious: Why is the padding in your other patch conditional on the
32-bit vs. 64-bit apps, but here it's always 32M?
Also, did you hit this problem in practice somehow?
next prev parent reply other threads:[~2019-03-13 16:25 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-12 17:32 [PATCH 0/2] handle worst-case heap randomization in mmap_base Ali Saidi
2019-03-12 17:32 ` Ali Saidi
2019-03-12 17:32 ` [PATCH 1/2] arm64/mmap: " Ali Saidi
2019-03-12 17:32 ` Ali Saidi
2019-03-12 17:32 ` [PATCH 2/2] x86/mmap: " Ali Saidi
2019-03-12 17:32 ` Ali Saidi
2019-03-13 16:25 ` Dave Hansen [this message]
2019-03-13 16:25 ` Dave Hansen
2019-03-17 15:52 ` Saidi, Ali
2019-03-17 15:52 ` Saidi, Ali
2019-03-13 22:58 ` Kees Cook
2019-03-13 22:58 ` Kees Cook
2019-03-27 19:51 ` Kees Cook
2019-03-27 19:51 ` Kees Cook
2019-04-15 16:03 ` Saidi, Ali
2019-04-15 16:03 ` Saidi, Ali
2019-04-19 8:51 ` Ingo Molnar
2019-04-19 8:51 ` Ingo Molnar
2019-04-19 15:00 ` Kees Cook
2019-04-19 15:00 ` Kees Cook
2019-03-21 14:09 ` Thomas Gleixner
2019-03-21 14:09 ` Thomas Gleixner
2019-03-26 2:13 ` Saidi, Ali
2019-03-26 2:13 ` Saidi, Ali
2019-03-26 8:43 ` Thomas Gleixner
2019-03-26 8:43 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1bd04037-698f-00c7-aa91-2bfec751bb0e@intel.com \
--to=dave.hansen@intel.com \
--cc=akpm@linux-foundation.org \
--cc=aliguori@amazon.com \
--cc=alisaidi@amazon.com \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=dave.hansen@linux.intel.com \
--cc=dwmw@amazon.co.uk \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.