All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Sumit Garg <sumit.garg@linaro.org>
Cc: mark.rutland@arm.com, daniel.thompson@linaro.org,
	jason@lakedaemon.net, catalin.marinas@arm.com,
	ito-yuichi@fujitsu.com, dianders@chromium.org,
	linux-kernel@vger.kernel.org, julien.thierry.kdev@gmail.com,
	jason.wessel@windriver.com, kgdb-bugreport@lists.sourceforge.net,
	tglx@linutronix.de, msys.mizuma@gmail.com, will@kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 3/5] arm64: smp: Allocate and setup IPI as NMI
Date: Mon, 19 Oct 2020 12:59:42 +0100	[thread overview]
Message-ID: <1c68b74251dc72b0cd74706280ea96f7@kernel.org> (raw)
In-Reply-To: <1602673931-28782-4-git-send-email-sumit.garg@linaro.org>

On 2020-10-14 12:12, Sumit Garg wrote:
> Allocate an unused IPI that can be turned as NMI using ipi_nmi 
> framework.

This doesn't do any allocation, as far as I can see. It relies on
the initial grant from the interrupt controller to be larger than
what the kernel currently uses.

> Also, invoke corresponding NMI setup/teardown APIs.
> 
> Signed-off-by: Sumit Garg <sumit.garg@linaro.org>
> ---
>  arch/arm64/kernel/smp.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
> index 82e75fc..129ebfb 100644
> --- a/arch/arm64/kernel/smp.c
> +++ b/arch/arm64/kernel/smp.c
> @@ -43,6 +43,7 @@
>  #include <asm/daifflags.h>
>  #include <asm/kvm_mmu.h>
>  #include <asm/mmu_context.h>
> +#include <asm/nmi.h>
>  #include <asm/numa.h>
>  #include <asm/processor.h>
>  #include <asm/smp_plat.h>
> @@ -962,6 +963,8 @@ static void ipi_setup(int cpu)
> 
>  	for (i = 0; i < nr_ipi; i++)
>  		enable_percpu_irq(ipi_irq_base + i, 0);
> +
> +	ipi_nmi_setup(cpu);
>  }
> 
>  #ifdef CONFIG_HOTPLUG_CPU
> @@ -974,6 +977,8 @@ static void ipi_teardown(int cpu)
> 
>  	for (i = 0; i < nr_ipi; i++)
>  		disable_percpu_irq(ipi_irq_base + i);
> +
> +	ipi_nmi_teardown(cpu);
>  }
>  #endif
> 
> @@ -995,6 +1000,9 @@ void __init set_smp_ipi_range(int ipi_base, int n)
>  		irq_set_status_flags(ipi_base + i, IRQ_HIDDEN);
>  	}
> 
> +	if (n > nr_ipi)
> +		set_smp_ipi_nmi(ipi_base + nr_ipi);
> +
>  	ipi_irq_base = ipi_base;
> 
>  	/* Setup the boot CPU immediately */

Thanks,

         M.
-- 
Jazz is not dead. It just smells funny...

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Sumit Garg <sumit.garg@linaro.org>
Cc: catalin.marinas@arm.com, will@kernel.org,
	linux-arm-kernel@lists.infradead.org, tglx@linutronix.de,
	jason@lakedaemon.net, mark.rutland@arm.com,
	julien.thierry.kdev@gmail.com, dianders@chromium.org,
	daniel.thompson@linaro.org, jason.wessel@windriver.com,
	msys.mizuma@gmail.com, ito-yuichi@fujitsu.com,
	kgdb-bugreport@lists.sourceforge.net,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 3/5] arm64: smp: Allocate and setup IPI as NMI
Date: Mon, 19 Oct 2020 12:59:42 +0100	[thread overview]
Message-ID: <1c68b74251dc72b0cd74706280ea96f7@kernel.org> (raw)
In-Reply-To: <1602673931-28782-4-git-send-email-sumit.garg@linaro.org>

On 2020-10-14 12:12, Sumit Garg wrote:
> Allocate an unused IPI that can be turned as NMI using ipi_nmi 
> framework.

This doesn't do any allocation, as far as I can see. It relies on
the initial grant from the interrupt controller to be larger than
what the kernel currently uses.

> Also, invoke corresponding NMI setup/teardown APIs.
> 
> Signed-off-by: Sumit Garg <sumit.garg@linaro.org>
> ---
>  arch/arm64/kernel/smp.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
> index 82e75fc..129ebfb 100644
> --- a/arch/arm64/kernel/smp.c
> +++ b/arch/arm64/kernel/smp.c
> @@ -43,6 +43,7 @@
>  #include <asm/daifflags.h>
>  #include <asm/kvm_mmu.h>
>  #include <asm/mmu_context.h>
> +#include <asm/nmi.h>
>  #include <asm/numa.h>
>  #include <asm/processor.h>
>  #include <asm/smp_plat.h>
> @@ -962,6 +963,8 @@ static void ipi_setup(int cpu)
> 
>  	for (i = 0; i < nr_ipi; i++)
>  		enable_percpu_irq(ipi_irq_base + i, 0);
> +
> +	ipi_nmi_setup(cpu);
>  }
> 
>  #ifdef CONFIG_HOTPLUG_CPU
> @@ -974,6 +977,8 @@ static void ipi_teardown(int cpu)
> 
>  	for (i = 0; i < nr_ipi; i++)
>  		disable_percpu_irq(ipi_irq_base + i);
> +
> +	ipi_nmi_teardown(cpu);
>  }
>  #endif
> 
> @@ -995,6 +1000,9 @@ void __init set_smp_ipi_range(int ipi_base, int n)
>  		irq_set_status_flags(ipi_base + i, IRQ_HIDDEN);
>  	}
> 
> +	if (n > nr_ipi)
> +		set_smp_ipi_nmi(ipi_base + nr_ipi);
> +
>  	ipi_irq_base = ipi_base;
> 
>  	/* Setup the boot CPU immediately */

Thanks,

         M.
-- 
Jazz is not dead. It just smells funny...

  parent reply	other threads:[~2020-10-19 12:01 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-14 11:12 [PATCH v5 0/5] arm64: Add framework to turn an IPI as NMI Sumit Garg
2020-10-14 11:12 ` Sumit Garg
2020-10-14 11:12 ` [PATCH v5 1/5] arm64: Add framework to turn " Sumit Garg
2020-10-14 11:12   ` Sumit Garg
2020-10-15  1:15   ` Masayoshi Mizuma
2020-10-15  1:15     ` Masayoshi Mizuma
2020-10-19 11:37   ` Marc Zyngier
2020-10-19 11:37     ` Marc Zyngier
2020-10-20  6:43     ` Sumit Garg
2020-10-20  6:43       ` Sumit Garg
2020-10-20 10:08       ` Marc Zyngier
2020-10-20 10:08         ` Marc Zyngier
2020-10-20 11:22         ` Sumit Garg
2020-10-20 11:22           ` Sumit Garg
2020-10-20 12:25           ` Daniel Thompson
2020-10-20 12:25             ` Daniel Thompson
2020-10-20 12:32             ` Marc Zyngier
2020-10-20 12:32               ` Marc Zyngier
2020-10-21  5:22               ` Sumit Garg
2020-10-21  5:22                 ` Sumit Garg
2020-10-21 10:27           ` Marc Zyngier
2020-10-21 10:27             ` Marc Zyngier
2020-10-22 11:52             ` Sumit Garg
2020-10-22 11:52               ` Sumit Garg
2020-10-19 11:56   ` Marc Zyngier
2020-10-19 11:56     ` Marc Zyngier
2020-10-20  7:07     ` Sumit Garg
2020-10-20  7:07       ` Sumit Garg
2020-10-14 11:12 ` [PATCH v5 2/5] irqchip/gic-v3: Enable support for SGIs to act as NMIs Sumit Garg
2020-10-14 11:12   ` Sumit Garg
2020-10-15  1:16   ` Masayoshi Mizuma
2020-10-15  1:16     ` Masayoshi Mizuma
2020-10-19 12:07   ` Marc Zyngier
2020-10-19 12:07     ` Marc Zyngier
2020-10-20  7:24     ` Sumit Garg
2020-10-20  7:24       ` Sumit Garg
2020-10-14 11:12 ` [PATCH v5 3/5] arm64: smp: Allocate and setup IPI as NMI Sumit Garg
2020-10-14 11:12   ` Sumit Garg
2020-10-15  1:16   ` Masayoshi Mizuma
2020-10-15  1:16     ` Masayoshi Mizuma
2020-10-19 11:59   ` Marc Zyngier [this message]
2020-10-19 11:59     ` Marc Zyngier
2020-10-20  7:16     ` Sumit Garg
2020-10-20  7:16       ` Sumit Garg
2020-10-14 11:12 ` [PATCH v5 4/5] arm64: kgdb: Round up cpus using " Sumit Garg
2020-10-14 11:12   ` Sumit Garg
2020-10-19 12:15   ` Marc Zyngier
2020-10-19 12:15     ` Marc Zyngier
2020-10-20  8:51     ` Sumit Garg
2020-10-20  8:51       ` Sumit Garg
2020-10-14 11:12 ` [PATCH v5 5/5] arm64: ipi_nmi: Add support for NMI backtrace Sumit Garg
2020-10-14 11:12   ` Sumit Garg
2020-10-15  1:17   ` Masayoshi Mizuma
2020-10-15  1:17     ` Masayoshi Mizuma
2020-10-19 12:20   ` Marc Zyngier
2020-10-19 12:20     ` Marc Zyngier
2020-10-20  9:13     ` Sumit Garg
2020-10-20  9:13       ` Sumit Garg
2020-10-21 10:32       ` Marc Zyngier
2020-10-21 10:32         ` Marc Zyngier
2020-10-21 11:28         ` Sumit Garg
2020-10-21 11:28           ` Sumit Garg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1c68b74251dc72b0cd74706280ea96f7@kernel.org \
    --to=maz@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=daniel.thompson@linaro.org \
    --cc=dianders@chromium.org \
    --cc=ito-yuichi@fujitsu.com \
    --cc=jason.wessel@windriver.com \
    --cc=jason@lakedaemon.net \
    --cc=julien.thierry.kdev@gmail.com \
    --cc=kgdb-bugreport@lists.sourceforge.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=msys.mizuma@gmail.com \
    --cc=sumit.garg@linaro.org \
    --cc=tglx@linutronix.de \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.