From: Chao Yu <chao@kernel.org>
To: Jaegeuk Kim <jaegeuk@kernel.org>,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Cc: chao@kernel.org
Subject: Re: [f2fs-dev] [PATCH v3] f2fs: don't leave the hashed inode while it's unlinked
Date: Tue, 25 Aug 2026 10:15:58 +0800 [thread overview]
Message-ID: <1f2d21bc-4b06-471c-a06d-faeebf76a525@kernel.org> (raw)
In-Reply-To: <aoylp9llX9zlKm-g@google.com>
On 8/25/26 04:12, Jaegeuk Kim via Linux-f2fs-devel wrote:
> f2fs_symlink()
> 1. f2fs_new_inode
> 2. f2fs_add_link
> 3. write_being|end to fill the symlink path
> 4. flush dirty pages and or checkpoint
>
> Step 4 is nice to succeed, which doesn't become a reason to roll back
> the created symlink. OTOH, if we get an error till step 3, don't leave
> its dentry and its inode.
>
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
v3 fixes generic/233 failure, looks good to me.
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
WARNING: multiple messages have this Message-ID (diff)
From: Chao Yu via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: Jaegeuk Kim <jaegeuk@kernel.org>,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH v3] f2fs: don't leave the hashed inode while it's unlinked
Date: Tue, 25 Aug 2026 10:15:58 +0800 [thread overview]
Message-ID: <1f2d21bc-4b06-471c-a06d-faeebf76a525@kernel.org> (raw)
In-Reply-To: <aoylp9llX9zlKm-g@google.com>
On 8/25/26 04:12, Jaegeuk Kim via Linux-f2fs-devel wrote:
> f2fs_symlink()
> 1. f2fs_new_inode
> 2. f2fs_add_link
> 3. write_being|end to fill the symlink path
> 4. flush dirty pages and or checkpoint
>
> Step 4 is nice to succeed, which doesn't become a reason to roll back
> the created symlink. OTOH, if we get an error till step 3, don't leave
> its dentry and its inode.
>
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
v3 fixes generic/233 failure, looks good to me.
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2026-08-25 2:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-18 20:01 [PATCH] f2fs: don't leave the hashed inode while it's unlinked Jaegeuk Kim
2026-08-18 20:01 ` [f2fs-dev] " Jaegeuk Kim via Linux-f2fs-devel
2026-08-19 2:56 ` Chao Yu via Linux-f2fs-devel
2026-08-19 2:56 ` Chao Yu
2026-08-21 15:23 ` [f2fs-dev] [PATCH v2] " Jaegeuk Kim via Linux-f2fs-devel
2026-08-21 15:23 ` Jaegeuk Kim
2026-08-22 7:37 ` Chao Yu via Linux-f2fs-devel
2026-08-22 7:37 ` Chao Yu
2026-08-23 9:56 ` Wenjie Qi
2026-08-23 9:56 ` Wenjie Qi
2026-08-24 15:12 ` [f2fs-dev] " Jaegeuk Kim via Linux-f2fs-devel
2026-08-24 15:12 ` Jaegeuk Kim
2026-08-24 13:16 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2026-08-24 13:16 ` Chao Yu
2026-08-24 20:12 ` [f2fs-dev] [PATCH v3] " Jaegeuk Kim
2026-08-24 20:12 ` Jaegeuk Kim via Linux-f2fs-devel
2026-08-25 2:15 ` Chao Yu [this message]
2026-08-25 2:15 ` Chao Yu via Linux-f2fs-devel
2026-08-25 2:39 ` Wenjie Qi
2026-08-25 2:39 ` Wenjie Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f2d21bc-4b06-471c-a06d-faeebf76a525@kernel.org \
--to=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.