[PATCH] GART driver support for generic AGP 3.0 device detection/ enabling & Intel 7505 chipset support

[PATCH] GART driver support for generic AGP 3.0 device detection/ enabling & Intel 7505 chipset support

[Tolentino, Matthew E]

[-- Attachment #1: Type: text/plain, Size: 813 bytes --]

Attached is a patch for generic AGP 3.0 device detection and enabling
routines as well as specific support for the Intel 7505 chipset against the
2.5.43 kernel.   

This patch adds a new file agp3.c which contains generic enabling and
detection routines based on the AGP 3.0 spec.  Some of the new features
include detection of multiple devices and proper isochronous bandwidth
allocation to each discovered device, as well as the typical host bridge
initialization.  This patch also adds another file i7505-agp.c which
contains the chipset specific support.  It is prudent to note that this
patch does not yet implement all of the capabilities defined by the AGP 3.0
spec.

For comments, kindly include my address in your mail as I am not currently
subscribed....

thanks,
matt

 <<linux-2.5.43-agp3.patch.gz>> 

[-- Attachment #2: linux-2.5.43-agp3.patch.gz --]
[-- Type: application/octet-stream, Size: 8222 bytes --]

Re: [PATCH] GART driver support for generic AGP 3.0 device detection/ enabling & Intel 7505 chipset support

[Greg KH]

On Thu, Oct 17, 2002 at 11:13:19AM -0700, Tolentino, Matthew E wrote:
> Attached is a patch for generic AGP 3.0 device detection and enabling
> routines as well as specific support for the Intel 7505 chipset against the
> 2.5.43 kernel.   

Just a minor comment:


diff -urN linux-2.5.43-vanilla/drivers/char/agp/Makefile linux-2.5.43/drivers/char/agp/Makefile
--- linux-2.5.43-vanilla/drivers/char/agp/Makefile	Tue Oct 15 20:27:49 2002
+++ linux-2.5.43/drivers/char/agp/Makefile	Thu Oct 17 10:12:41 2002
@@ -3,12 +3,13 @@
 # space ioctl interface to use agp memory.  It also adds a kernel interface
 # that other drivers could use to manipulate agp memory.
 
-export-objs := agp.o
+export-objs := agp.o agp3.o
 
-agpgart-y := agp.o frontend.o
+agpgart-y := agp.o agp3.o frontend.o 
 
 agpgart-$(CONFIG_AGP_INTEL)	+= i8x0-agp.o
 agpgart-$(CONFIG_AGP_I810)	+= i810-agp.o
+agpgart-$(CONFIG_AGP_I7505)	+= i7505-agp.o
 agpgart-$(CONFIG_AGP_VIA)	+= via-agp.o
 agpgart-$(CONFIG_AGP_AMD)	+= amd-agp.o
 agpgart-$(CONFIG_AGP_SIS)	+= sis-agp.o


You should probably not build agp3.o unless i7505-agp.o is built too, or
do some of the other drivers need functions in agp3.c?


thanks,

greg k-h

Re: [PATCH] GART driver support for generic AGP 3.0 device detection/ enabling & Intel 7505 chipset support

[Dave Jones]

On Thu, Oct 17, 2002 at 08:57:20PM -0700, Greg KH wrote:

 > You should probably not build agp3.o unless i7505-agp.o is built too, or
 > do some of the other drivers need functions in agp3.c?

The AMD 8151 is AGP 3.0 compliant too, but the current driver is just
the page remapping support.  It's possible that some functionality
implemented both there and in agp3.c can be propagated both ways.

I'll look into this next week.
Despite it being support for a major protocol version bump, it's
still just another driver, which means it could go in after the
freeze if needbe.

Looks fine for merging afaics though.

		Dave

-- 
| Dave Jones.        http://www.codemonkey.org.uk