* [parisc-linux] [PATCH] fix masking error in fesetround() on hppa
@ 2002-12-03 2:43 Carlos O'Donell
2002-12-03 2:51 ` [parisc-linux] " Roland McGrath
` (3 more replies)
0 siblings, 4 replies; 18+ messages in thread
From: Carlos O'Donell @ 2002-12-03 2:43 UTC (permalink / raw)
To: libc-alpha; +Cc: debian-glibc, parisc-linux
[-- Attachment #1: Type: text/plain, Size: 620 bytes --]
libc-alpha,
Thanks to HP's testdrive users, we found and fixed a small masking bug
in fesetround(). Should use ~FE_DOWNWARD since this is the rounding mask
set to all ones, and will clear the mask before or'ing the round value.
It was suggested that a test case could be made of this, where glibc
tries to set and get various combinations of FE_DOWNWARD, FE_UPWARD,
FE_TONEAREST, and FE_UPWARD. I could provide such a testcase if it was
deemed usefull.
c.
---
2002-12-02 Carlos O'Donell <carlos@baldric.uwo.ca>
* sysdeps/hppa/fpu/fesetround.c:
(fesetround): Use ~FE_DOWNWARD so both bits of RM are cleared.
[-- Attachment #2: 03-glibc23-hppa-fesetround --]
[-- Type: text/plain, Size: 396 bytes --]
--- glibc-2.3.1/sysdeps/hppa/fpu/fesetround.c 2002-12-02 16:36:36.000000000 -0500
+++ glibc-2.3.1/sysdeps/hppa/fpu/fesetround.c 2002-12-02 16:36:59.000000000 -0500
@@ -31,7 +31,7 @@
/* Get the current status word. */
__asm__ ("fstd %%fr0,0(%1)" : "=m" (*sw) : "r" (sw));
- sw[0] &= ~FE_UPWARD;
+ sw[0] &= ~FE_DOWNWARD;
sw[0] |= round;
__asm__ ("fldd 0(%0),%%fr0" : : "r" (sw));
^ permalink raw reply [flat|nested] 18+ messages in thread* [parisc-linux] Re: [PATCH] fix masking error in fesetround() on hppa
2002-12-03 2:43 [parisc-linux] [PATCH] fix masking error in fesetround() on hppa Carlos O'Donell
@ 2002-12-03 2:51 ` Roland McGrath
2002-12-03 2:51 ` Roland McGrath
` (2 subsequent siblings)
3 siblings, 0 replies; 18+ messages in thread
From: Roland McGrath @ 2002-12-03 2:51 UTC (permalink / raw)
To: Carlos O'Donell; +Cc: libc-alpha, debian-glibc, parisc-linux
I've put that fix in. I'm not quite sure what you are suggesting for a new
test, but test cases that fail on known bug regressions (i.e. one that
fails before your fix and works after it) are always welcome.
Thanks,
Roland
^ permalink raw reply [flat|nested] 18+ messages in thread* [parisc-linux] Re: [PATCH] fix masking error in fesetround() on hppa
2002-12-03 2:43 [parisc-linux] [PATCH] fix masking error in fesetround() on hppa Carlos O'Donell
2002-12-03 2:51 ` [parisc-linux] " Roland McGrath
@ 2002-12-03 2:51 ` Roland McGrath
2002-12-04 22:13 ` [parisc-linux] FATAL: kernel too old John David Anglin
2002-12-04 22:13 ` John David Anglin
3 siblings, 0 replies; 18+ messages in thread
From: Roland McGrath @ 2002-12-03 2:51 UTC (permalink / raw)
To: Carlos O'Donell; +Cc: libc-alpha, debian-glibc, parisc-linux
I've put that fix in. I'm not quite sure what you are suggesting for a new
test, but test cases that fail on known bug regressions (i.e. one that
fails before your fix and works after it) are always welcome.
Thanks,
Roland
^ permalink raw reply [flat|nested] 18+ messages in thread
* [parisc-linux] FATAL: kernel too old
2002-12-03 2:43 [parisc-linux] [PATCH] fix masking error in fesetround() on hppa Carlos O'Donell
2002-12-03 2:51 ` [parisc-linux] " Roland McGrath
2002-12-03 2:51 ` Roland McGrath
@ 2002-12-04 22:13 ` John David Anglin
2002-12-04 22:13 ` John David Anglin
3 siblings, 0 replies; 18+ messages in thread
From: John David Anglin @ 2002-12-04 22:13 UTC (permalink / raw)
To: Carlos O'Donell; +Cc: libc-alpha, debian-glibc, parisc-linux
I'm getting the following error building glibc-2.3.1-5:
CPP='/home/dave/opt/gnu/bin/gcc -E -x c-header' /home/dave/glibc-2.3.1-5/glibc-
2.3.1/objdir/elf/ld.so.1 --library-path /home/dave/glibc-2.3.1-5/glibc-2.3.1/obj
dir:/home/dave/glibc-2.3.1-5/glibc-2.3.1/objdir/math:/home/dave/glibc-2.3.1-5/gl
ibc-2.3.1/objdir/elf:/home/dave/glibc-2.3.1-5/glibc-2.3.1/objdir/dlfcn:/home/dav
e/glibc-2.3.1-5/glibc-2.3.1/objdir/nss:/home/dave/glibc-2.3.1-5/glibc-2.3.1/objd
ir/nis:/home/dave/glibc-2.3.1-5/glibc-2.3.1/objdir/rt:/home/dave/glibc-2.3.1-5/g
libc-2.3.1/objdir/resolv:/home/dave/glibc-2.3.1-5/glibc-2.3.1/objdir/crypt:/home
/dave/glibc-2.3.1-5/glibc-2.3.1/objdir/linuxthreads /home/dave/glibc-2.3.1-5/gli
bc-2.3.1/objdir/sunrpc/rpcgen -Y ../scripts -c rpcsvc/bootparam_prot.x -o /home/
dave/glibc-2.3.1-5/glibc-2.3.1/objdir/sunrpc/xbootparam_prot.T
FATAL: kernel too old
make[2]: *** [/home/dave/glibc-2.3.1-5/glibc-2.3.1/objdir/sunrpc/xbootparam_prot
.stmp] Error 1
Is 2.4.18-pa52 really too old?
I configured with
../glibc/configure --build=hppa-linux --host=hppa-linux --target=hppa-linux --prefix=/home/dave/opt/gnu --disable-profile --without-cvs --enable-add-ons --enable-hacker-mode --enable-kernel=2.4.8
Oh, I noticed that hppa-linux is not listed in INSTALL or README.
Dave
--
J. David Anglin dave.anglin@nrc.ca
National Research Council of Canada (613) 990-0752 (FAX: 952-6605)
^ permalink raw reply [flat|nested] 18+ messages in thread
* [parisc-linux] FATAL: kernel too old
2002-12-03 2:43 [parisc-linux] [PATCH] fix masking error in fesetround() on hppa Carlos O'Donell
` (2 preceding siblings ...)
2002-12-04 22:13 ` [parisc-linux] FATAL: kernel too old John David Anglin
@ 2002-12-04 22:13 ` John David Anglin
2002-12-04 22:17 ` [parisc-linux] " Roland McGrath
` (5 more replies)
3 siblings, 6 replies; 18+ messages in thread
From: John David Anglin @ 2002-12-04 22:13 UTC (permalink / raw)
To: Carlos O'Donell; +Cc: libc-alpha, debian-glibc, parisc-linux
I'm getting the following error building glibc-2.3.1-5:
CPP='/home/dave/opt/gnu/bin/gcc -E -x c-header' /home/dave/glibc-2.3.1-5/glibc-
2.3.1/objdir/elf/ld.so.1 --library-path /home/dave/glibc-2.3.1-5/glibc-2.3.1/obj
dir:/home/dave/glibc-2.3.1-5/glibc-2.3.1/objdir/math:/home/dave/glibc-2.3.1-5/gl
ibc-2.3.1/objdir/elf:/home/dave/glibc-2.3.1-5/glibc-2.3.1/objdir/dlfcn:/home/dav
e/glibc-2.3.1-5/glibc-2.3.1/objdir/nss:/home/dave/glibc-2.3.1-5/glibc-2.3.1/objd
ir/nis:/home/dave/glibc-2.3.1-5/glibc-2.3.1/objdir/rt:/home/dave/glibc-2.3.1-5/g
libc-2.3.1/objdir/resolv:/home/dave/glibc-2.3.1-5/glibc-2.3.1/objdir/crypt:/home
/dave/glibc-2.3.1-5/glibc-2.3.1/objdir/linuxthreads /home/dave/glibc-2.3.1-5/gli
bc-2.3.1/objdir/sunrpc/rpcgen -Y ../scripts -c rpcsvc/bootparam_prot.x -o /home/
dave/glibc-2.3.1-5/glibc-2.3.1/objdir/sunrpc/xbootparam_prot.T
FATAL: kernel too old
make[2]: *** [/home/dave/glibc-2.3.1-5/glibc-2.3.1/objdir/sunrpc/xbootparam_prot
.stmp] Error 1
Is 2.4.18-pa52 really too old?
I configured with
../glibc/configure --build=hppa-linux --host=hppa-linux --target=hppa-linux --prefix=/home/dave/opt/gnu --disable-profile --without-cvs --enable-add-ons --enable-hacker-mode --enable-kernel=2.4.8
Oh, I noticed that hppa-linux is not listed in INSTALL or README.
Dave
--
J. David Anglin dave.anglin@nrc.ca
National Research Council of Canada (613) 990-0752 (FAX: 952-6605)
^ permalink raw reply [flat|nested] 18+ messages in thread* [parisc-linux] Re: FATAL: kernel too old
2002-12-04 22:13 ` John David Anglin
@ 2002-12-04 22:17 ` Roland McGrath
2002-12-04 22:17 ` Roland McGrath
` (4 subsequent siblings)
5 siblings, 0 replies; 18+ messages in thread
From: Roland McGrath @ 2002-12-04 22:17 UTC (permalink / raw)
To: John David Anglin
Cc: Carlos O'Donell, libc-alpha, debian-glibc, parisc-linux
Check that _dl_osversion (_rtld_global._dl_osversion) is getting initialized.
^ permalink raw reply [flat|nested] 18+ messages in thread* [parisc-linux] Re: FATAL: kernel too old
2002-12-04 22:13 ` John David Anglin
2002-12-04 22:17 ` [parisc-linux] " Roland McGrath
@ 2002-12-04 22:17 ` Roland McGrath
2002-12-04 22:25 ` [parisc-linux] " M. Grabert
` (3 subsequent siblings)
5 siblings, 0 replies; 18+ messages in thread
From: Roland McGrath @ 2002-12-04 22:17 UTC (permalink / raw)
To: John David Anglin
Cc: Carlos O'Donell, libc-alpha, debian-glibc, parisc-linux
Check that _dl_osversion (_rtld_global._dl_osversion) is getting initialized.
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [parisc-linux] FATAL: kernel too old
2002-12-04 22:13 ` John David Anglin
2002-12-04 22:17 ` [parisc-linux] " Roland McGrath
2002-12-04 22:17 ` Roland McGrath
@ 2002-12-04 22:25 ` M. Grabert
2002-12-04 22:25 ` M. Grabert
` (2 subsequent siblings)
5 siblings, 0 replies; 18+ messages in thread
From: M. Grabert @ 2002-12-04 22:25 UTC (permalink / raw)
To: John David Anglin
Cc: Carlos O'Donell, libc-alpha, debian-glibc, parisc-linux
On Wed, 4 Dec 2002, John David Anglin wrote:
> I'm getting the following error building glibc-2.3.1-5:
>
> CPP='/home/dave/opt/gnu/bin/gcc -E -x c-header' /home/dave/glibc-2.3.1-5/glibc-
> 2.3.1/objdir/elf/ld.so.1 --library-path /home/dave/glibc-2.3.1-5/glibc-2.3.1/obj
> dir:/home/dave/glibc-2.3.1-5/glibc-2.3.1/objdir/math:/home/dave/glibc-2.3.1-5/gl
> ibc-2.3.1/objdir/elf:/home/dave/glibc-2.3.1-5/glibc-2.3.1/objdir/dlfcn:/home/dav
> e/glibc-2.3.1-5/glibc-2.3.1/objdir/nss:/home/dave/glibc-2.3.1-5/glibc-2.3.1/objd
> ir/nis:/home/dave/glibc-2.3.1-5/glibc-2.3.1/objdir/rt:/home/dave/glibc-2.3.1-5/g
> libc-2.3.1/objdir/resolv:/home/dave/glibc-2.3.1-5/glibc-2.3.1/objdir/crypt:/home
> /dave/glibc-2.3.1-5/glibc-2.3.1/objdir/linuxthreads /home/dave/glibc-2.3.1-5/gli
> bc-2.3.1/objdir/sunrpc/rpcgen -Y ../scripts -c rpcsvc/bootparam_prot.x -o /home/
> dave/glibc-2.3.1-5/glibc-2.3.1/objdir/sunrpc/xbootparam_prot.T
> FATAL: kernel too old
> make[2]: *** [/home/dave/glibc-2.3.1-5/glibc-2.3.1/objdir/sunrpc/xbootparam_prot
> .stmp] Error 1
>
> Is 2.4.18-pa52 really too old?
>
> I configured with
>
> ../glibc/configure --build=hppa-linux --host=hppa-linux --target=hppa-linux
> --prefix=/home/dave/opt/gnu --disable-profile --without-cvs
> --enable-add-ons --enable-hacker-mode --enable-kernel=2.4.8
^^^^^
2.4.8 ? Not 2.4.18? But I don't know whether this make a difference!?
BTW, wasn't there a option for --with-kernel-headers= ?
Perhaps the kernel headers weren't picked up properly ...
greetings max
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [parisc-linux] FATAL: kernel too old
2002-12-04 22:13 ` John David Anglin
` (2 preceding siblings ...)
2002-12-04 22:25 ` [parisc-linux] " M. Grabert
@ 2002-12-04 22:25 ` M. Grabert
2002-12-04 22:30 ` [parisc-linux] " Jeff Bailey
2002-12-04 22:30 ` Jeff Bailey
5 siblings, 0 replies; 18+ messages in thread
From: M. Grabert @ 2002-12-04 22:25 UTC (permalink / raw)
To: John David Anglin
Cc: Carlos O'Donell, libc-alpha, debian-glibc, parisc-linux
On Wed, 4 Dec 2002, John David Anglin wrote:
> I'm getting the following error building glibc-2.3.1-5:
>
> CPP='/home/dave/opt/gnu/bin/gcc -E -x c-header' /home/dave/glibc-2.3.1-5/glibc-
> 2.3.1/objdir/elf/ld.so.1 --library-path /home/dave/glibc-2.3.1-5/glibc-2.3.1/obj
> dir:/home/dave/glibc-2.3.1-5/glibc-2.3.1/objdir/math:/home/dave/glibc-2.3.1-5/gl
> ibc-2.3.1/objdir/elf:/home/dave/glibc-2.3.1-5/glibc-2.3.1/objdir/dlfcn:/home/dav
> e/glibc-2.3.1-5/glibc-2.3.1/objdir/nss:/home/dave/glibc-2.3.1-5/glibc-2.3.1/objd
> ir/nis:/home/dave/glibc-2.3.1-5/glibc-2.3.1/objdir/rt:/home/dave/glibc-2.3.1-5/g
> libc-2.3.1/objdir/resolv:/home/dave/glibc-2.3.1-5/glibc-2.3.1/objdir/crypt:/home
> /dave/glibc-2.3.1-5/glibc-2.3.1/objdir/linuxthreads /home/dave/glibc-2.3.1-5/gli
> bc-2.3.1/objdir/sunrpc/rpcgen -Y ../scripts -c rpcsvc/bootparam_prot.x -o /home/
> dave/glibc-2.3.1-5/glibc-2.3.1/objdir/sunrpc/xbootparam_prot.T
> FATAL: kernel too old
> make[2]: *** [/home/dave/glibc-2.3.1-5/glibc-2.3.1/objdir/sunrpc/xbootparam_prot
> .stmp] Error 1
>
> Is 2.4.18-pa52 really too old?
>
> I configured with
>
> ../glibc/configure --build=hppa-linux --host=hppa-linux --target=hppa-linux
> --prefix=/home/dave/opt/gnu --disable-profile --without-cvs
> --enable-add-ons --enable-hacker-mode --enable-kernel=2.4.8
^^^^^
2.4.8 ? Not 2.4.18? But I don't know whether this make a difference!?
BTW, wasn't there a option for --with-kernel-headers= ?
Perhaps the kernel headers weren't picked up properly ...
greetings max
^ permalink raw reply [flat|nested] 18+ messages in thread* [parisc-linux] Re: FATAL: kernel too old
2002-12-04 22:13 ` John David Anglin
` (3 preceding siblings ...)
2002-12-04 22:25 ` M. Grabert
@ 2002-12-04 22:30 ` Jeff Bailey
2002-12-04 22:42 ` John David Anglin
2002-12-04 22:42 ` John David Anglin
2002-12-04 22:30 ` Jeff Bailey
5 siblings, 2 replies; 18+ messages in thread
From: Jeff Bailey @ 2002-12-04 22:30 UTC (permalink / raw)
To: John David Anglin
Cc: Carlos O'Donell, libc-alpha, debian-glibc, parisc-linux
On Wed, Dec 04, 2002 at 05:13:07PM -0500, John David Anglin wrote:
> Is 2.4.18-pa52 really too old?
Yes. hppa-linux requires 2.4.19
Tks,
Jeff Bailey
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [parisc-linux] Re: FATAL: kernel too old
2002-12-04 22:30 ` [parisc-linux] " Jeff Bailey
@ 2002-12-04 22:42 ` John David Anglin
2002-12-04 22:42 ` John David Anglin
1 sibling, 0 replies; 18+ messages in thread
From: John David Anglin @ 2002-12-04 22:42 UTC (permalink / raw)
To: Jeff Bailey; +Cc: carlos, libc-alpha, debian-glibc, parisc-linux
> On Wed, Dec 04, 2002 at 05:13:07PM -0500, John David Anglin wrote:
>
> > Is 2.4.18-pa52 really too old?
>
> Yes. hppa-linux requires 2.4.19
Ok, I try one of the other builds but none so far have been particularly
stable on a rp2470c.
Thanks,
Dave
--
J. David Anglin dave.anglin@nrc.ca
National Research Council of Canada (613) 990-0752 (FAX: 952-6605)
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [parisc-linux] Re: FATAL: kernel too old
2002-12-04 22:30 ` [parisc-linux] " Jeff Bailey
2002-12-04 22:42 ` John David Anglin
@ 2002-12-04 22:42 ` John David Anglin
2002-12-04 22:55 ` Grant Grundler
2002-12-04 22:55 ` Grant Grundler
1 sibling, 2 replies; 18+ messages in thread
From: John David Anglin @ 2002-12-04 22:42 UTC (permalink / raw)
To: Jeff Bailey; +Cc: carlos, libc-alpha, debian-glibc, parisc-linux
> On Wed, Dec 04, 2002 at 05:13:07PM -0500, John David Anglin wrote:
>
> > Is 2.4.18-pa52 really too old?
>
> Yes. hppa-linux requires 2.4.19
Ok, I try one of the other builds but none so far have been particularly
stable on a rp2470c.
Thanks,
Dave
--
J. David Anglin dave.anglin@nrc.ca
National Research Council of Canada (613) 990-0752 (FAX: 952-6605)
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [parisc-linux] Re: FATAL: kernel too old
2002-12-04 22:42 ` John David Anglin
@ 2002-12-04 22:55 ` Grant Grundler
2002-12-04 22:55 ` Grant Grundler
1 sibling, 0 replies; 18+ messages in thread
From: Grant Grundler @ 2002-12-04 22:55 UTC (permalink / raw)
To: John David Anglin
Cc: Jeff Bailey, carlos, libc-alpha, debian-glibc, parisc-linux
On Wed, Dec 04, 2002 at 05:42:00PM -0500, John David Anglin wrote:
> Ok, I try one of the other builds but none so far have been particularly
> stable on a rp2470c.
Dave,
I can build a UP 2.4.20 for the rp2470 and see how that fairs.
SMP has in fact not been especially stable for the 2.4.19 hppa releases.
thanks,
grant
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [parisc-linux] Re: FATAL: kernel too old
2002-12-04 22:42 ` John David Anglin
2002-12-04 22:55 ` Grant Grundler
@ 2002-12-04 22:55 ` Grant Grundler
2002-12-04 23:01 ` John David Anglin
2002-12-04 23:01 ` John David Anglin
1 sibling, 2 replies; 18+ messages in thread
From: Grant Grundler @ 2002-12-04 22:55 UTC (permalink / raw)
To: John David Anglin
Cc: Jeff Bailey, carlos, libc-alpha, debian-glibc, parisc-linux
On Wed, Dec 04, 2002 at 05:42:00PM -0500, John David Anglin wrote:
> Ok, I try one of the other builds but none so far have been particularly
> stable on a rp2470c.
Dave,
I can build a UP 2.4.20 for the rp2470 and see how that fairs.
SMP has in fact not been especially stable for the 2.4.19 hppa releases.
thanks,
grant
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [parisc-linux] Re: FATAL: kernel too old
2002-12-04 22:55 ` Grant Grundler
@ 2002-12-04 23:01 ` John David Anglin
2002-12-04 23:01 ` John David Anglin
1 sibling, 0 replies; 18+ messages in thread
From: John David Anglin @ 2002-12-04 23:01 UTC (permalink / raw)
To: Grant Grundler; +Cc: jbailey, carlos, libc-alpha, debian-glibc, parisc-linux
> Dave,
> I can build a UP 2.4.20 for the rp2470 and see how that fairs.
> SMP has in fact not been especially stable for the 2.4.19 hppa releases.
That would be great. I was going to try vmlinux-2.4.20-rc1-pa7
after the gcc testsuite run that is in progress completes. I seem
to recall that vmlinux-2.4.20-rc1-pa7 wasn't very stable, so it
would be nice to find something later than 2.4.18 that works reasonably
reliably.
I was trying to get a feel whether of not the current gcc mainline
would successfully build the latest glibc.
Dave
--
J. David Anglin dave.anglin@nrc.ca
National Research Council of Canada (613) 990-0752 (FAX: 952-6605)
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [parisc-linux] Re: FATAL: kernel too old
2002-12-04 22:55 ` Grant Grundler
2002-12-04 23:01 ` John David Anglin
@ 2002-12-04 23:01 ` John David Anglin
1 sibling, 0 replies; 18+ messages in thread
From: John David Anglin @ 2002-12-04 23:01 UTC (permalink / raw)
To: Grant Grundler; +Cc: jbailey, carlos, libc-alpha, debian-glibc, parisc-linux
> Dave,
> I can build a UP 2.4.20 for the rp2470 and see how that fairs.
> SMP has in fact not been especially stable for the 2.4.19 hppa releases.
That would be great. I was going to try vmlinux-2.4.20-rc1-pa7
after the gcc testsuite run that is in progress completes. I seem
to recall that vmlinux-2.4.20-rc1-pa7 wasn't very stable, so it
would be nice to find something later than 2.4.18 that works reasonably
reliably.
I was trying to get a feel whether of not the current gcc mainline
would successfully build the latest glibc.
Dave
--
J. David Anglin dave.anglin@nrc.ca
National Research Council of Canada (613) 990-0752 (FAX: 952-6605)
^ permalink raw reply [flat|nested] 18+ messages in thread
* [parisc-linux] Re: FATAL: kernel too old
2002-12-04 22:13 ` John David Anglin
` (4 preceding siblings ...)
2002-12-04 22:30 ` [parisc-linux] " Jeff Bailey
@ 2002-12-04 22:30 ` Jeff Bailey
5 siblings, 0 replies; 18+ messages in thread
From: Jeff Bailey @ 2002-12-04 22:30 UTC (permalink / raw)
To: John David Anglin
Cc: Carlos O'Donell, libc-alpha, debian-glibc, parisc-linux
On Wed, Dec 04, 2002 at 05:13:07PM -0500, John David Anglin wrote:
> Is 2.4.18-pa52 really too old?
Yes. hppa-linux requires 2.4.19
Tks,
Jeff Bailey
^ permalink raw reply [flat|nested] 18+ messages in thread
* [parisc-linux] [PATCH] fix masking error in fesetround() on hppa
@ 2002-12-03 2:43 Carlos O'Donell
0 siblings, 0 replies; 18+ messages in thread
From: Carlos O'Donell @ 2002-12-03 2:43 UTC (permalink / raw)
To: libc-alpha; +Cc: debian-glibc, parisc-linux
[-- Attachment #1: Type: text/plain, Size: 620 bytes --]
libc-alpha,
Thanks to HP's testdrive users, we found and fixed a small masking bug
in fesetround(). Should use ~FE_DOWNWARD since this is the rounding mask
set to all ones, and will clear the mask before or'ing the round value.
It was suggested that a test case could be made of this, where glibc
tries to set and get various combinations of FE_DOWNWARD, FE_UPWARD,
FE_TONEAREST, and FE_UPWARD. I could provide such a testcase if it was
deemed usefull.
c.
---
2002-12-02 Carlos O'Donell <carlos@baldric.uwo.ca>
* sysdeps/hppa/fpu/fesetround.c:
(fesetround): Use ~FE_DOWNWARD so both bits of RM are cleared.
[-- Attachment #2: 03-glibc23-hppa-fesetround --]
[-- Type: text/plain, Size: 396 bytes --]
--- glibc-2.3.1/sysdeps/hppa/fpu/fesetround.c 2002-12-02 16:36:36.000000000 -0500
+++ glibc-2.3.1/sysdeps/hppa/fpu/fesetround.c 2002-12-02 16:36:59.000000000 -0500
@@ -31,7 +31,7 @@
/* Get the current status word. */
__asm__ ("fstd %%fr0,0(%1)" : "=m" (*sw) : "r" (sw));
- sw[0] &= ~FE_UPWARD;
+ sw[0] &= ~FE_DOWNWARD;
sw[0] |= round;
__asm__ ("fldd 0(%0),%%fr0" : : "r" (sw));
^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2002-12-04 23:26 UTC | newest]
Thread overview: 18+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-12-03 2:43 [parisc-linux] [PATCH] fix masking error in fesetround() on hppa Carlos O'Donell
2002-12-03 2:51 ` [parisc-linux] " Roland McGrath
2002-12-03 2:51 ` Roland McGrath
2002-12-04 22:13 ` [parisc-linux] FATAL: kernel too old John David Anglin
2002-12-04 22:13 ` John David Anglin
2002-12-04 22:17 ` [parisc-linux] " Roland McGrath
2002-12-04 22:17 ` Roland McGrath
2002-12-04 22:25 ` [parisc-linux] " M. Grabert
2002-12-04 22:25 ` M. Grabert
2002-12-04 22:30 ` [parisc-linux] " Jeff Bailey
2002-12-04 22:42 ` John David Anglin
2002-12-04 22:42 ` John David Anglin
2002-12-04 22:55 ` Grant Grundler
2002-12-04 22:55 ` Grant Grundler
2002-12-04 23:01 ` John David Anglin
2002-12-04 23:01 ` John David Anglin
2002-12-04 22:30 ` Jeff Bailey
-- strict thread matches above, loose matches on Subject: below --
2002-12-03 2:43 [parisc-linux] [PATCH] fix masking error in fesetround() on hppa Carlos O'Donell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.